Skip to content

Conversation

@FrederikBolding
Copy link
Member

Alters getJsonSizeUnsafe to not use TextEncoder as this has proven slow on mobile. We don't need full byte length accuracy for the uses of getJsonSizeUnsafe anyway, so this is an OK tradeoff for performance.

@FrederikBolding FrederikBolding requested a review from a team as a code owner April 24, 2025 09:50
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (b8792af) to head (e1b9432).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3348   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         402      402           
  Lines       11112    11112           
  Branches     1754     1754           
=======================================
  Hits        10894    10894           
  Misses        218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit ae4e83b Apr 24, 2025
168 checks passed
@FrederikBolding FrederikBolding deleted the fb/speed-up-json-sizing branch April 24, 2025 10:23
@Veeezo
Copy link

Veeezo commented May 3, 2025

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants