Skip to content

perf: Speed up JSON size calculation #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 2 commits into from
Apr 24, 2025
Merged

perf: Speed up JSON size calculation #3348

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bde2545
perf: Speed up JSON size calculation
FrederikBolding Apr 24, 2025
e1b9432
Update packages/snaps-utils/src/json.ts
FrederikBolding Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/snaps-utils/src/json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,13 @@ export function parseJson<Type extends Json = Json>(json: string) {
*
* This may sometimes be preferred over `getJsonSize` for performance reasons.
*
* Note: This function does not encode the string to bytes, thus the input may
* be about 4x larger in practice. Use this function with caution.
*
* @param value - The JSON value to get the size of.
* @returns The size of the JSON value in bytes.
*/
export function getJsonSizeUnsafe(value: Json): number {
const json = JSON.stringify(value);
return new TextEncoder().encode(json).byteLength;
return json.length;
}
Loading