Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 12, 2025

This fixes an edge case in the unused permission detection, for endowments that can have multiple handlers. For example, endowment:lifecycle-hooks enables two (optional) handlers, onInstall and onUpdate. Previously the endowment would be detected as unused, even if one of the two was exported.

After this change, either can be specified, and the endowment will be considered used.

@Mrtenz Mrtenz changed the title Fix unused permission detection for endowments with multiple handlers fix: Fix unused permission detection for endowments with multiple handlers Jun 12, 2025
@Mrtenz Mrtenz marked this pull request as ready for review June 12, 2025 12:41
@Mrtenz Mrtenz requested a review from a team as a code owner June 12, 2025 12:41
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (08bb538) to head (1ddb7ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3452   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         399      399           
  Lines       11136    11140    +4     
  Branches     1746     1748    +2     
=======================================
+ Hits        10934    10938    +4     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit d41194d Jun 12, 2025
117 checks passed
@FrederikBolding FrederikBolding deleted the mrtenz/fix-multiple-handler-endowments branch June 12, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants