fix: Fix unused permission detection for endowments with multiple handlers#3452
Merged
FrederikBolding merged 2 commits intomainfrom Jun 12, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3452 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 399 399
Lines 11136 11140 +4
Branches 1746 1748 +2
=======================================
+ Hits 10934 10938 +4
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an edge case in the unused permission detection, for endowments that can have multiple handlers. For example,
endowment:lifecycle-hooksenables two (optional) handlers,onInstallandonUpdate. Previously the endowment would be detected as unused, even if one of the two was exported.After this change, either can be specified, and the endowment will be considered used.