Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jun 17, 2025

Fixes a couple of issues after the merge of the WebSockets PR. Adds the proper types for the RPC methods and allows local WebSocket URLs in snap_openWebSocket.

Also fixes the formatting for Uri validation errors.

Closes #3457

@FrederikBolding FrederikBolding requested a review from a team as a code owner June 17, 2025 08:02
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (1f4fc7a) to head (149524a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3459   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         404      404           
  Lines       11314    11317    +3     
  Branches     1763     1764    +1     
=======================================
+ Hits        11112    11115    +3     
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Mrtenz
Mrtenz previously approved these changes Jun 17, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 443340f Jun 17, 2025
117 checks passed
@FrederikBolding FrederikBolding deleted the fb/ws-fixes branch June 17, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error messages from Uri struct

3 participants