fix: Add missing WS types and allow local URLs#3459
Merged
FrederikBolding merged 4 commits intomainfrom Jun 17, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 404 404
Lines 11314 11317 +3
Branches 1763 1764 +1
=======================================
+ Hits 11112 11115 +3
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
previously approved these changes
Jun 17, 2025
Mrtenz
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues after the merge of the WebSockets PR. Adds the proper types for the RPC methods and allows local WebSocket URLs in
snap_openWebSocket.Also fixes the formatting for Uri validation errors.
Closes #3457