fix: Properly stop Snaps when clearing state #3552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
GuillaumeRx
previously approved these changes
Aug 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
==========================================
- Coverage 98.28% 98.27% -0.01%
==========================================
Files 417 417
Lines 11765 11762 -3
Branches 1827 1826 -1
==========================================
- Hits 11563 11559 -4
- Misses 202 203 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
GuillaumeRx
reviewed
Aug 1, 2025
GuillaumeRx
approved these changes
Aug 1, 2025
FrederikBolding
deleted the
fb/properly-terminate-snaps-when-clearing-state
branch
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`.
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`.
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`.
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`.
runway-github bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`.
runway-github bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
…earing state (#17810) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`.
tommasini
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 5, 2025
…earing state (#17926) - fix: cp-7.53.0 Properly stop Snaps when clearing state (#17810) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`. [a17c422](a17c422) Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: tommasini <[email protected]> Co-authored-by: Nico MASSART <[email protected]>
sethkfman
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 27, 2025
…earing state (#17926) - fix: cp-7.53.0 Properly stop Snaps when clearing state (#17810) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on `snaps-controllers`. [a17c422](a17c422) Co-authored-by: Frederik Bolding <[email protected]> Co-authored-by: tommasini <[email protected]> Co-authored-by: Nico MASSART <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly stop Snaps instead of only terminating their execution when clearing state. This properly cleans up stuck requests that are not terminated gracefully.