Skip to content

fix: cp-7.53.0 Properly stop Snaps when clearing state #17810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrederikBolding merged 1 commit into from
Aug 5, 2025
Merged

fix: cp-7.53.0 Properly stop Snaps when clearing state #17810

FrederikBolding merged 1 commit into from
Aug 5, 2025

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 1, 2025

Description

Properly stop Snaps when clearing state. Patching in a fix from MetaMask/snaps#3552 because mobile is a few versions behind on snaps-controllers.

@metamaskbot metamaskbot added team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) INVALID-PR-TEMPLATE PR's body doesn't match template labels Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6035449
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3aa1202-3313-4110-86a9-c74856f29063

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@FrederikBolding FrederikBolding marked this pull request as ready for review August 1, 2025 12:22
@FrederikBolding FrederikBolding requested review from a team and GuillaumeRx August 1, 2025 12:22
tommasini
tommasini approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixing a bug? Asking because 7.53.0 was cut yesterday

@FrederikBolding
Copy link
Member Author

FrederikBolding commented Aug 1, 2025

Is this fixing a bug? Asking because 7.53.0 was cut yesterday

Yes. It is unclear if it needs to be cherry-picked in, but it made onboarding seem broken in another PR.

@FrederikBolding FrederikBolding force-pushed the fb/patch-snapcontroller-clear-state branch from 6035449 to e68c20a Compare August 4, 2025 08:20
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e68c20a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2c0da047-cbc7-4f2b-8066-22546635b535

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@FrederikBolding FrederikBolding force-pushed the fb/patch-snapcontroller-clear-state branch from e68c20a to d842247 Compare August 4, 2025 12:11
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d842247
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2fa3275d-9b59-401c-8d9b-c8a7f2fa7e00

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@FrederikBolding FrederikBolding changed the title fix: Properly stop Snaps when clearing state fix: cp-7.53.0 Properly stop Snaps when clearing state Aug 4, 2025
@FrederikBolding FrederikBolding force-pushed the fb/patch-snapcontroller-clear-state branch from d842247 to 6d660f5 Compare August 4, 2025 21:09
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6d660f5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c116dab0-a3a3-46b4-9e1a-298d0200ec56

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FrederikBolding
Copy link
Member Author

FrederikBolding commented Aug 5, 2025

Skipping E2E since this needs to go into an RC and I'm convinced the only blocking tests are flaky.

@FrederikBolding FrederikBolding added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit a17c422 Aug 5, 2025
95 of 102 checks passed
@FrederikBolding FrederikBolding deleted the fb/patch-snapcontroller-clear-state branch August 5, 2025 07:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 5, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FrederikBolding @GuillaumeRx @tommasini @metamaskbot