Skip to content

fix: cp-7.53.0 Properly stop Snaps when clearing state #17810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Aug 5, 2025
Merged

fix: cp-7.53.0 Properly stop Snaps when clearing state #17810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions patches/@metamask+snaps-controllers+14.1.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
diff --git a/node_modules/@metamask/snaps-controllers/dist/snaps/SnapController.cjs b/node_modules/@metamask/snaps-controllers/dist/snaps/SnapController.cjs
index 908f4e7..8f66c3f 100644
--- a/node_modules/@metamask/snaps-controllers/dist/snaps/SnapController.cjs
+++ b/node_modules/@metamask/snaps-controllers/dist/snaps/SnapController.cjs
@@ -963,12 +963,7 @@ class SnapController extends base_controller_1.BaseController {
*/
async clearState() {
const snapIds = Object.keys(this.state.snaps);
- if (this.#closeAllConnections) {
- snapIds.forEach((snapId) => {
- this.#closeAllConnections?.(snapId);
- });
- }
- await this.messagingSystem.call('ExecutionService:terminateAllSnaps');
+ await this.stopAllSnaps();
snapIds.forEach((snapId) => this.#revokeAllSnapPermissions(snapId));
this.update((state) => {
state.snaps = {};
Loading