Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 2, 2025

Swap JSON-RPC failure validation to a faster implementation since we control the responses we know that the error is valid.


Note

Replace JSON-RPC failure detection with a direct error property check in AbstractExecutionService.#command, updating related imports/types.

Written by Cursor Bugbot for commit 02ed670. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 2, 2025 07:53
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (36f2212) to head (02ed670).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3661      +/-   ##
==========================================
- Coverage   98.30%   98.27%   -0.03%     
==========================================
  Files         417      417              
  Lines       11927    11902      -25     
  Branches     1844     1843       -1     
==========================================
- Hits        11725    11697      -28     
- Misses        202      205       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 0c693f0 Oct 2, 2025
228 of 234 checks passed
@FrederikBolding FrederikBolding deleted the fb/json-rpc-failure-perf branch October 2, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants