Skip to content

perf: Simplify JSON-RPC failure validation #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Oct 2, 2025
Merged

perf: Simplify JSON-RPC failure validation #3661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/snaps-controllers/src/services/AbstractExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type { SnapRpcHookArgs } from '@metamask/snaps-utils';
import { SNAP_STREAM_NAMES, logError, logWarning } from '@metamask/snaps-utils';
import type {
Json,
JsonRpcError as JsonRpcErrorType,
JsonRpcNotification,
JsonRpcRequest,
} from '@metamask/utils';
Expand All @@ -15,7 +16,6 @@ import {
assertIsJsonRpcRequest,
hasProperty,
inMilliseconds,
isJsonRpcFailure,
} from '@metamask/utils';
import { nanoid } from 'nanoid';
import { pipeline } from 'readable-stream';
Expand Down Expand Up @@ -441,12 +441,10 @@ export abstract class AbstractExecutionService<WorkerType>
log('Parent: Sending Command', message);
const response = await job.rpcEngine.handle(message);

if (isJsonRpcFailure(response)) {
throw new JsonRpcError(
response.error.code,
response.error.message,
response.error.data,
);
// We don't need full validation of the response here because we control it.
if (hasProperty(response, 'error')) {
const error = response.error as JsonRpcErrorType;
throw new JsonRpcError(error.code, error.message, error.data);
}

return response.result;
Expand Down