Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 27, 2025

Bump Playwright to the latest version, resolving some Dependabot alerts while also moving our browser tests to newer browsers.


Note

Upgrade Playwright to ^1.57.0 and point snaps-utils vitest iframe to the execution-environments build output.

  • Dependencies:
    • Upgrade playwright to ^1.57.0 and align playwright-core in yarn.lock.
  • Testing/Config:
    • In packages/snaps-utils/vitest.config.mts, change IFRAME_PATH to ../snaps-execution-environments/dist/webpack/iframe and update server.fs.allow accordingly.

Written by Cursor Bugbot for commit 35760b9. This will update automatically on new commits. Configure here.

@socket-security
Copy link

socket-security bot commented Oct 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedplaywright@​1.49.1 ⏵ 1.57.0100100 +1610099100

View full report

@socket-security
Copy link

socket-security bot commented Oct 27, 2025

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Warn Low
Potential code anomaly (AI signal): npm playwright-core is 100.0% likely to have a medium risk anomaly

Notes: This is a legitimate browser installation helper script that is part of Microsoft Playwright's testing framework. The script downloads and installs Microsoft Edge Dev browser packages on macOS systems. While the script does have security weaknesses (downloads packages from user-supplied URLs without integrity checks and installs them with sudo privileges), this appears to be intentional functionality for automated testing environments where the URL would be controlled and trusted. The script is not malware but rather a utility for test automation that assumes it will be used in controlled environments with trusted package sources.

Confidence: 1.00

Severity: 0.60

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Potential code anomaly (AI signal): npm playwright-core is 100.0% likely to have a medium risk anomaly

Notes: The code implements an evaluation sandbox with serialization/deserialization capabilities. The most significant security concern is the use of eval on untrusted input, which can lead to arbitrary code execution. While there are protections around DOM-like objects and careful serialization, these do not fully mitigate the inherent risk of evaluating external expressions. No clear malware indicators (data exfiltration, backdoors, or hardcoded secrets) are present in this fragment, but the eval path represents a high-risk sink that could be misused if the surrounding system passes untrusted input. Treat this as a high-risk component requiring strict input validation, sandboxing, or avoidance of eval in favor of safer alternatives. Overall security risk is moderate to high due to eval exposure, with malware likelihood low unless the component is misused in a broader attack chain.

Confidence: 1.00

Severity: 0.60

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Potential code anomaly (AI signal): npm playwright-core is 100.0% likely to have a medium risk anomaly

Notes: The code segment functions as a legitimate, platform-aware dependency management utility used by Playwright-like tooling to ensure required browser dependencies are present and Docker-version alignment is maintained. There is no explicit malicious activity detected, but the capability to perform privileged installs (sudo/su) and to write diagnostic data to the filesystem warrants secure execution contexts and access controls. Regular reviews and sandboxed execution are recommended to mitigate supply-chain risk in compromised environments.

Confidence: 1.00

Severity: 0.60

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Ignoring alerts on:

View full report

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore npm/[email protected]

Network access expected.

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore npm/[email protected]

Network access expected.

@FrederikBolding FrederikBolding marked this pull request as ready for review December 19, 2025 10:18
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 19, 2025 10:18
import tsconfigPaths from 'vite-tsconfig-paths';
import { defineConfig } from 'vitest/config';

const IFRAME_PATH = join(import.meta.dirname, './dist/webpack/iframe');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this ever worked

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (b58a9d1) to head (35760b9).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3703   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         420      420           
  Lines       12032    12032           
  Branches     1874     1874           
=======================================
  Hits        11832    11832           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 3624460 Dec 19, 2025
126 checks passed
@FrederikBolding FrederikBolding deleted the fb/bump-playwright branch December 19, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants