Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Oct 28, 2025

Following #3679, we want test-snaps to be publishable to NPM. Currently only TypeScript packages are built, so test-snaps wouldn't be published properly. I've added an extra step to build test-snaps before running the NPM publish job.


Note

Updates the publish-release workflow to install dependencies in a dedicated step and build @metamask/test-snaps so it’s included in release artifacts/NPM publish.

  • CI (GitHub Actions):
    • publish-release job:
      • Add dedicated Install dependencies step (yarn install --immutable).
      • Build all packages with yarn build.
      • New step to build @metamask/test-snaps (yarn workspace @metamask/test-snaps build) so artifacts include it.

Written by Cursor Bugbot for commit 4ffbc25. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz requested a review from a team as a code owner October 28, 2025 14:12
@Mrtenz Mrtenz enabled auto-merge October 28, 2025 14:15
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.28%. Comparing base (313198b) to head (4ffbc25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3712   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         418      418           
  Lines       12152    12152           
  Branches     1876     1876           
=======================================
  Hits        11943    11943           
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mrtenz Mrtenz added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 5452ac5 Oct 28, 2025
122 checks passed
@Mrtenz Mrtenz deleted the mrtenz/include-test-snaps-in-release branch October 28, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants