ci: Build test-snaps in publish-release job to include it in NPM publishing#3712
Merged
ci: Build test-snaps in publish-release job to include it in NPM publishing#3712
test-snaps in publish-release job to include it in NPM publishing#3712Conversation
FrederikBolding
approved these changes
Oct 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3712 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 418 418
Lines 12152 12152
Branches 1876 1876
=======================================
Hits 11943 11943
Misses 209 209 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #3679, we want
test-snapsto be publishable to NPM. Currently only TypeScript packages are built, sotest-snapswouldn't be published properly. I've added an extra step to buildtest-snapsbefore running the NPM publish job.Note
Updates the publish-release workflow to install dependencies in a dedicated step and build
@metamask/test-snapsso it’s included in release artifacts/NPM publish.publish-releasejob:Install dependenciesstep (yarn install --immutable).yarn build.@metamask/test-snaps(yarn workspace @metamask/test-snaps build) so artifacts include it.Written by Cursor Bugbot for commit 4ffbc25. This will update automatically on new commits. Configure here.