Skip to content

Re-introduce expanded view notifications via snap_notify #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 16 commits into from
Dec 3, 2024
Merged

Re-introduce expanded view notifications via snap_notify #2881

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
46a1828
Revert "Revert `snap_notify` changes (#2837)"
hmalik88 Nov 12, 2024
6d3f715
update snap notify to include content type in interface creation
hmalik88 Nov 12, 2024
8f25885
update test to expect new args
hmalik88 Nov 12, 2024
66b4d37
rebuild
hmalik88 Nov 12, 2024
358773c
address PR comments
hmalik88 Nov 13, 2024
f7712de
Merge branch 'main' into hm/reverse-snap-notify-revert
hmalik88 Nov 13, 2024
7e9b73d
Merge branch 'main' into hm/reverse-snap-notify-revert
hmalik88 Nov 17, 2024
297b6b9
Merge branch 'main' into hm/reverse-snap-notify-revert
hmalik88 Nov 28, 2024
0d28da3
recalculate shasum and coverage
hmalik88 Nov 28, 2024
4e5d376
Merge branch 'main' into hm/reverse-snap-notify-revert
hmalik88 Dec 2, 2024
cb5c517
remove unnecessary validation
hmalik88 Dec 2, 2024
1acc601
simplify types
hmalik88 Dec 3, 2024
213360a
allow any JSX element for notification detailed view
hmalik88 Dec 3, 2024
7a44fe7
recalculate shasum
hmalik88 Dec 3, 2024
da47242
update coverage
hmalik88 Dec 3, 2024
7dd44f5
revert type name change
hmalik88 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/examples/packages/browserify-plugin/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "4yLB19XYAdGgHBPFlVOzCkb/JUZCjSajPRSQWs+a3uE=",
"shasum": "wA5+OSQqdueoT6u58pWjf6IUo93q2sDobZShY+23/ag=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/browserify/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "+0hxp1uhfCqe9KR+4RPDSPGHFTgRyGULKLn9XWwCmsY=",
"shasum": "ztaZDSaolLQCDFN8p9l4KA3gSlY3idxJFml3x6Yz/7Q=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
6 changes: 3 additions & 3 deletions packages/snaps-rpc-methods/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ module.exports = deepmerge(baseConfig, {
],
coverageThreshold: {
global: {
branches: 92.88,
branches: 92.94,
functions: 97.26,
lines: 97.84,
statements: 97.36,
lines: 97.87,
statements: 97.4,
},
},
});
Loading
Loading