Add sol to supported currency in snap_getCurrencyRate#2904
Closed
GuillaumeRx wants to merge 1 commit intomainfrom
Closed
Add sol to supported currency in snap_getCurrencyRate#2904GuillaumeRx wants to merge 1 commit intomainfrom
sol to supported currency in snap_getCurrencyRate#2904GuillaumeRx wants to merge 1 commit intomainfrom
Conversation
|
|
||
| const GetCurrencyRateParametersStruct = object({ | ||
| currency: union([currency('btc')]), | ||
| currency: union([currency('btc'), currency('sol')]), |
Member
There was a problem hiding this comment.
Why does our getCurrencyRate RPC method only support such a limited subset of assets? I would assume we have a lot more rates available?
Contributor
Author
There was a problem hiding this comment.
Because the RateController is pretty limited :(
Contributor
Author
There was a problem hiding this comment.
|
|
||
| const GetCurrencyRateParametersStruct = object({ | ||
| currency: union([currency('btc')]), | ||
| currency: union([currency('btc'), currency('sol')]), |
Member
There was a problem hiding this comment.
Should we not be using CAIP-19 for this API already?
Contributor
Author
There was a problem hiding this comment.
I can refactor to use CAIP-19 IDs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 487 487
Lines 10427 10427
Branches 1598 1598
=======================================
Hits 9852 9852
Misses 575 575 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
solto the supported currency union insnap_getCurrencyRateparams