feat: Allow async initialization logic#2918
Merged
FrederikBolding merged 5 commits intomainfrom Dec 9, 2024
Merged
Conversation
8e0f188 to
f216494
Compare
Mrtenz
reviewed
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 487 487
Lines 10441 10442 +1
Branches 1600 1600
=======================================
+ Hits 9866 9867 +1
Misses 575 575 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow async initialization logic for Snaps by altering the CLI config to do direct assignment of the exports to
module.exports. This lets Snap developers use async initialization logic such as top-level await (which has been re-enabled) and asynchronous instantiation of WASM modules (which has been introduced in favor of sync). A minor change was also made to the execution environment to await the exposed module after evaluating it.Snaps are still subject to a 60 second initialization timeout, so the asynchronous logic must finish before that timer runs out.
Closes #2919
Closes #2359