Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2969 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 497 497
Lines 10802 10802
Branches 1649 1649
=======================================
Hits 10231 10231
Misses 571 571 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/unblock-signtypeddata
branch
from
e4beb01 to
cf30710
Compare
Mrtenz
approved these changes
Jan 6, 2025
FrederikBolding
force-pushed
the
fb/unblock-signtypeddata
branch
from
cf30710 to
c665c07
Compare
Mrtenz
pushed a commit
that referenced
this pull request
Jan 8, 2025
Unblock all variants of `eth_signTypedData` as they are deemed lower risk following UI changes on the clients. Also adds logic to use it in the Ethereum provider example Snap.
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
Unblock all variants of `eth_signTypedData` as they are deemed lower risk following UI changes on the clients. Also adds logic to use it in the Ethereum provider example Snap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblock all variants of
eth_signTypedDataas they are deemed lower risk following UI changes on the clients.Also adds logic to use it in the Ethereum provider example Snap.