Skip to content

fix: Stop storing messenger manually in CronjobController #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Jan 10, 2025
Merged

fix: Stop storing messenger manually in CronjobController #3006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/snaps-controllers/src/cronjob/CronjobController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ export class CronjobController extends BaseController<
CronjobControllerState,
CronjobControllerMessenger
> {
#messenger: CronjobControllerMessenger;

#dailyTimer!: Timer;

#timers: Map<string, Timer>;
Expand All @@ -147,7 +145,6 @@ export class CronjobController extends BaseController<
});
this.#timers = new Map();
this.#snapIds = new Map();
this.#messenger = messenger;

this._handleSnapRegisterEvent = this._handleSnapRegisterEvent.bind(this);
this._handleSnapUnregisterEvent =
Expand Down Expand Up @@ -227,7 +224,7 @@ export class CronjobController extends BaseController<
* @returns Array of Cronjob specifications.
*/
#getSnapJobs(snapId: SnapId): Cronjob[] | undefined {
const permissions = this.#messenger.call(
const permissions = this.messagingSystem.call(
'PermissionController:getPermissions',
snapId,
);
Expand Down Expand Up @@ -303,7 +300,7 @@ export class CronjobController extends BaseController<
*/
async #executeCronjob(job: Cronjob) {
this.#updateJobLastRunState(job.id, Date.now());
await this.#messenger.call('SnapController:handleRequest', {
await this.messagingSystem.call('SnapController:handleRequest', {
snapId: job.snapId,
origin: '',
handler: HandlerType.OnCronjob,
Expand Down Expand Up @@ -387,7 +384,7 @@ export class CronjobController extends BaseController<

const timer = new Timer(ms);
timer.start(() => {
this.#messenger
this.messagingSystem
.call('SnapController:handleRequest', {
snapId: event.snapId,
origin: '',
Expand Down
Loading