Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 12, 2025

Allows us to run Snaps locally on mobile by instantiating a WebView per Snap. This PR changes the WebViewExecutionService to let it instantiate and remove webviews (this will need support on the mobile implementation side). Additionally alters the WebView bundle so it no longer functions as a "proxy executor", but instead inherits from the iframe executor implementation.

Breaking changes

  • WebViewExecutionService now requires createWebView and removeWebView constructor arguments, getWebView is no longer supported.
  • The WebView bundle in snaps-execution-environments no longer supports proxy executor calls and functions as a single executor.

@FrederikBolding FrederikBolding force-pushed the fb/mobile-local-execution branch from e6c4719 to 076e53d Compare February 17, 2025 13:00
@FrederikBolding FrederikBolding changed the title wip: Attempt local execution on mobile feat!: Run a WebView per Snap on mobile Feb 17, 2025
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.90%. Comparing base (d7e2167) to head (2a04db7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../snaps-execution-environments/src/webview/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   94.88%   94.90%   +0.01%     
==========================================
  Files         506      506              
  Lines       11121    11119       -2     
  Branches     1709     1709              
==========================================
  Hits        10552    10552              
+ Misses        569      567       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding marked this pull request as ready for review February 18, 2025 09:24
@FrederikBolding FrederikBolding requested a review from a team as a code owner February 18, 2025 09:24
@FrederikBolding FrederikBolding force-pushed the fb/mobile-local-execution branch from 1b75670 to 11558c8 Compare February 18, 2025 09:24
@FrederikBolding FrederikBolding merged commit 492b056 into main Feb 18, 2025
170 of 171 checks passed
@FrederikBolding FrederikBolding deleted the fb/mobile-local-execution branch February 18, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants