feat!: Run a WebView per Snap on mobile #3085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to run Snaps locally on mobile by instantiating a WebView per Snap. This PR changes the
WebViewExecutionServiceto let it instantiate and remove webviews (this will need support on the mobile implementation side). Additionally alters the WebView bundle so it no longer functions as a "proxy executor", but instead inherits from the iframe executor implementation.Breaking changes
WebViewExecutionServicenow requirescreateWebViewandremoveWebViewconstructor arguments,getWebViewis no longer supported.snaps-execution-environmentsno longer supports proxy executor calls and functions as a single executor.