Skip to content

fix(simulation): Unintentionally narrow type for onKeyringRequest helper #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Feb 14, 2025
Merged

fix(simulation): Unintentionally narrow type for onKeyringRequest helper #3109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions packages/snaps-simulation/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,7 @@ export type SnapHelpers = {
* @param keyringRequest - Keyring request.
* @returns The response.
*/
onKeyringRequest(
keyringRequest: KeyringOptions,
): Promise<SnapResponseWithoutInterface>;
onKeyringRequest(keyringRequest: KeyringOptions): SnapRequest;

/**
* Get the response from the Snap's `onInstall` handler.
Expand Down Expand Up @@ -270,12 +268,10 @@ export function getHelpers({
});
};

const onKeyringRequest = async (
request: KeyringOptions,
): Promise<SnapResponseWithoutInterface> => {
const onKeyringRequest = (request: KeyringOptions) => {
log('Sending keyring request %o.', request);

const response = await handleRequest({
return handleRequest({
snapId,
store,
executionService,
Expand All @@ -284,8 +280,6 @@ export function getHelpers({
handler: HandlerType.OnKeyringRequest,
request,
});

return response;
};

return {
Expand Down
Loading