Skip to content

fix(controllers): Properly pass down execution service constructor args #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Feb 17, 2025
Merged

fix(controllers): Properly pass down execution service constructor args #3110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/snaps-controllers/src/services/AbstractExecutionService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ import type { ExecutionServiceArgs } from './AbstractExecutionService';
import { NodeThreadExecutionService } from './node';

class MockExecutionService extends NodeThreadExecutionService {
constructor({ messenger, setupSnapProvider }: ExecutionServiceArgs) {
constructor({ messenger, setupSnapProvider, ...args }: ExecutionServiceArgs) {
super({
...args,
messenger,
setupSnapProvider,
initTimeout: inMilliseconds(5, Duration.Second),
Expand Down
2 changes: 2 additions & 0 deletions packages/snaps-controllers/src/services/iframe/IframeExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ export class IframeExecutionService extends AbstractExecutionService<Window> {
iframeUrl,
messenger,
setupSnapProvider,
...args
}: IframeExecutionEnvironmentServiceArgs) {
super({
...args,
messenger,
setupSnapProvider,
});
Expand Down
2 changes: 2 additions & 0 deletions packages/snaps-controllers/src/services/offscreen/OffscreenExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ export class OffscreenExecutionService extends ProxyExecutionService {
messenger,
setupSnapProvider,
offscreenPromise,
...args
}: OffscreenExecutionEnvironmentServiceArgs) {
super({
...args,
messenger,
setupSnapProvider,
stream: new BrowserRuntimePostMessageStream({
Expand Down
2 changes: 2 additions & 0 deletions packages/snaps-controllers/src/services/proxy/ProxyExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ export class ProxyExecutionService extends AbstractExecutionService<string> {
stream,
messenger,
setupSnapProvider,
...args
}: ProxyExecutionEnvironmentServiceArgs) {
super({
...args,
messenger,
setupSnapProvider,
usePing: false,
Expand Down
2 changes: 2 additions & 0 deletions packages/snaps-controllers/src/services/webview/WebViewExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ export class WebViewExecutionService extends ProxyExecutionService {
messenger,
setupSnapProvider,
getWebView,
...args
}: WebViewExecutionServiceArgs) {
super({
...args,
messenger,
setupSnapProvider,
stream: new WebViewMessageStream({
Expand Down
2 changes: 2 additions & 0 deletions packages/snaps-controllers/src/services/webworker/WebWorkerExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ export class WebWorkerExecutionService extends AbstractExecutionService<string>
documentUrl,
messenger,
setupSnapProvider,
...args
}: WebWorkerExecutionEnvironmentServiceArgs) {
super({
...args,
messenger,
setupSnapProvider,
});
Expand Down
Loading