Skip to content

Fix example build script #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrtenz merged 1 commit into from
Feb 17, 2025
Merged

Fix example build script #3116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"sideEffects": false,
"files": [],
"scripts": {
"build": "yarn workspaces foreach --worktree --parallel --verbose --no-private run build",
"build": "yarn workspaces filter --include 'packages/examples/packages/**' --parallel --no-private run build",
Copy link
Contributor

@hmalik88 hmalik88 Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between doing yarn workspaces filter --include and yarn workspaces foreach --include? Why don't we need --verbose any more?

Copy link
Member

@FrederikBolding FrederikBolding Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--verbose doesn't exist on filter

Copy link
Member Author

@Mrtenz Mrtenz Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workspaces filter's --include supports glob patterns, whereas workspaces foreach only supports exact package names. --verbose is also enabled by default on workspaces filter.

"build:clean": "yarn clean && yarn build",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/example-snaps",
"changelog:validates": "yarn workspaces foreach --worktree --parallel --verbose run changelog:validate",
Expand Down
Loading