Use Vitest for browser tests #3236
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "branches": 93.44, | ||
| "functions": 97.38, | ||
| "lines": 98.34, | ||
| "statements": 98.08 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,26 +11,35 @@ | |
| <script> | ||
| (function () { | ||
| try { | ||
| // Parent is the iframe created by Vitest containing the Snap iframe | ||
| // and this page as a sibling iframe. We try to access the Snap iframe | ||
| // from the parent iframe. | ||
| const snap = parent.document.querySelector( | ||
| 'iframe[data-testid="snaps-iframe"]', | ||
| ); | ||
| if (!snap) { | ||
| window.parent.postMessage('Failed to find Snap iframe.', '*'); | ||
| return; | ||
| } | ||
|
|
||
| // We try to access the snap iframe document. If this works, it means | ||
| // that the iframe is not sandboxed. Otherwise it will throw an error. | ||
|
Comment on lines
-14
to
-27
Member
Author
There was a problem hiding this comment. This test was wrong in the first place. The iframe was served from a different origin, and trying to access
So the I confirmed that the new test properly tests the sandboxing behaviour, as it's now served from the same origin. Removing the sandbox property from the iframe now results in a test failure. |
||
| if (snap.contentDocument === null) { | ||
| window.parent.postMessage( | ||
| 'Failed to access document of the snap iframe.', | ||
| '*', | ||
| ); | ||
| return; | ||
| } | ||
| } catch (e) { | ||
| window.parent.postMessage( | ||
| `An unknown error occurred: ${e.toString()}`, | ||
| '*', | ||
| ); | ||
| } | ||
|
|
||
| // Fall through case, which should not happen. | ||
| window.parent.postMessage('Unexpected success.', '*'); | ||
| })(); | ||
| </script> | ||
| </body> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work locally? Do you need to run any commands besides
yarnandyarn testto run browser tests locally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Vitest will tell you to run
yarn playwright installon the first time runningyarn test.