Skip to content

fix: Increase Snap interface context size limit slightly #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Mar 20, 2025
Merged

fix: Increase Snap interface context size limit slightly #3246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/snaps-controllers/src/interface/SnapInterfaceController.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,9 @@ describe('SnapInterfaceController', () => {
'SnapInterfaceController:createInterface',
MOCK_SNAP_ID,
element,
{ foo: 'a'.repeat(1_000_000) },
{ foo: 'a'.repeat(5_000_000) },
),
).rejects.toThrow('A Snap interface context may not be larger than 1 MB');
).rejects.toThrow('A Snap interface context may not be larger than 5 MB');
});

it('throws if a link is on the phishing list', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/snaps-controllers/src/interface/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ export function constructState(
return newState;
}

const MAX_CONTEXT_SIZE = 1_000_000; // 1 mb
const MAX_CONTEXT_SIZE = 5_000_000; // 5 mb

/**
* Validate a JSON blob to be used as the interface context.
Expand Down
Loading