Skip to content

fix: Improve error messages for AddressStruct #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 2 commits into from
Mar 27, 2025
Merged

fix: Improve error messages for AddressStruct #3270

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fbc107
fix: Improve error messages for AddressStruct
FrederikBolding Mar 27, 2025
163a478
Update manifests
FrederikBolding Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/snaps-sdk/src/jsx/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,12 @@ export const DropdownStruct: Describe<DropdownElement> = element('Dropdown', {
* A struct for the {@link AddressElement} type.
*/
export const AddressStruct: Describe<AddressElement> = element('Address', {
address: nullUnion([HexChecksumAddressStruct, CaipAccountIdStruct]),
address: selectiveUnion((value) => {
if (typeof value === 'string' && value.startsWith('0x')) {
return HexChecksumAddressStruct;
}
return CaipAccountIdStruct;
}),
truncate: optional(boolean()),
displayName: optional(boolean()),
avatar: optional(boolean()),
Expand Down
Loading