Skip to content

perf: Simplify executor return #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Apr 24, 2025
Merged

perf: Simplify executor return #3349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/snaps-execution-environments/coverage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"branches": 90.74,
"branches": 90.78,
"functions": 94.96,
"lines": 90.86,
"statements": 90.28
Expand Down
6 changes: 3 additions & 3 deletions packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,14 @@ export class BaseSnapExecutor {
return null;
}

let result = await this.executeInSnapContext(target, async () =>
const result = await this.executeInSnapContext(target, async () =>
// TODO: fix handler args type cast
handler(args as any),
);

// The handler might not return anything, but undefined is not valid JSON.
if (result === undefined) {
result = null;
if (result === undefined || result === null) {
return null;
}

// /!\ Always return only sanitized JSON to prevent security flaws. /!\
Expand Down
Loading