Skip to content

ci: Lint changelogs in CI #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrtenz merged 1 commit into from
Jun 28, 2025
Merged

ci: Lint changelogs in CI #3512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ jobs:
is-high-risk-environment: false
- name: Lint
run: yarn lint
- name: Validate changelogs
run: yarn changelog:validate
- name: Require clean working directory
shell: bash
run: |
Expand Down
1 change: 0 additions & 1 deletion packages/examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"scripts": {
"build": "yarn workspaces filter --include 'packages/examples/packages/**' --parallel --no-private run build",
"build:clean": "yarn clean && yarn build",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/example-snaps",
"changelog:validates": "yarn workspaces foreach --worktree --parallel --verbose run changelog:validate",
"clean": "yarn workspaces foreach --worktree --parallel --verbose --no-private run clean",
"lint": "yarn workspaces foreach --worktree --parallel --verbose --interlaced --no-private run lint && yarn lint:dependencies",
Expand Down
1 change: 0 additions & 1 deletion packages/examples/packages/invoke-snap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"scripts": {
"build": "yarn workspaces foreach --worktree --parallel --verbose run build",
"build:clean": "yarn clean && yarn build",
"changelog:validate": "../../../../scripts/validate-changelog.sh @metamask/invoke-snap-example-snap",
"clean": "yarn workspaces foreach --worktree --parallel --verbose run clean",
"lint": "yarn workspaces foreach --worktree --parallel --verbose --interlaced run lint && yarn lint:dependencies",
"lint:ci": "yarn lint:eslint && yarn lint:misc --check",
Expand Down
26 changes: 12 additions & 14 deletions yarn.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,20 +148,18 @@ module.exports = defineConfig({

// All non-root package must have valid "changelog:update" and
// "changelog:validate" scripts.
expectWorkspaceField(
workspace,
'scripts.changelog:validate',
`${getRelativePath(workspace, 'scripts/validate-changelog.sh')} ${
workspace.manifest.name
}`,
);
expectWorkspaceField(
workspace,
'scripts.changelog:validate',
`${getRelativePath(workspace, 'scripts/validate-changelog.sh')} ${
workspace.manifest.name
}`,
);
if (
workspace.cwd !== 'packages/examples' &&
workspace.cwd !== 'packages/examples/packages/invoke-snap'
) {
expectWorkspaceField(
workspace,
'scripts.changelog:validate',
`${getRelativePath(workspace, 'scripts/validate-changelog.sh')} ${
workspace.manifest.name
}`,
);
}

// All non-root packages must have a valid "since-latest-release" script.
expectWorkspaceField(
Expand Down
Loading