fix: Add snap metadata to simulation accounts#3528
Merged
GuillaumeRx merged 5 commits intomainfrom Jul 4, 2025
Merged
Conversation
| ...account, | ||
| metadata: { | ||
| snap: { | ||
| id: snapId, |
Member
There was a problem hiding this comment.
Suggested change
| id: snapId, | |
| id: snapId, | |
| enabled: true, |
Contributor
Author
There was a problem hiding this comment.
We don't care about enabled 🤔
| address, | ||
| assets = [], | ||
| selected = false, | ||
| owned = false, |
Member
There was a problem hiding this comment.
Wondering if the default should be owned or not 🤔
Contributor
Author
There was a problem hiding this comment.
I don't have a strong preference, we set selected to false and I treat those flags as optionally toggle-able if you really need them
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3528 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 410 411 +1
Lines 11588 11606 +18
Branches 1804 1808 +4
=======================================
+ Hits 11386 11404 +18
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Interface controller in the simulation environment would fail if the
AccountSelectoruseshideExternalAccountsdue to the missing snap metadata in the partial account object we use in the simulation.This adds some logic to generate this metadata if the account is flagged as
ownedin the simulation options.