Skip to content

fix: Disable base64 optimization in ReactNative #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 5 commits into from
Aug 7, 2025
Merged

fix: Disable base64 optimization in ReactNative #3564

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50d6e48
fix: Disable base64 optimization in ReactNative
FrederikBolding Aug 7, 2025
94b049b
Optional chain navigator
FrederikBolding Aug 7, 2025
6374f0e
Update comment
FrederikBolding Aug 7, 2025
3f11a9e
Tweak RN check
FrederikBolding Aug 7, 2025
a4b2363
Fix coverage
FrederikBolding Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/snaps-utils/src/base64.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import type { VirtualFile } from './virtual-file';
*/
export async function encodeBase64(input: Uint8Array | VirtualFile | string) {
const bytes = getBytes(input);
// In the browser, FileReader is much faster than bytesToBase64.
if ('FileReader' in globalThis) {
const isReactNative =
typeof navigator !== 'undefined' && navigator.product === 'ReactNative';
// In the browser, FileReader is much faster than bytesToBase64. This is not supported in React Native however.
if ('FileReader' in globalThis && !isReactNative) {
return await new Promise((resolve, reject) => {
const reader = Object.assign(new FileReader(), {
onload: () =>
Expand Down
Loading