Skip to content

perf: Stop creating error before needing to throw #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 1 commit into from
Oct 7, 2025
Merged

perf: Stop creating error before needing to throw #3664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/snaps-controllers/src/snaps/SnapController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1952,7 +1952,7 @@ export class SnapController extends BaseController<
*/
getExpect(snapId: SnapId): Snap {
const snap = this.get(snapId);
assert(snap !== undefined, new Error(`Snap "${snapId}" not found.`));
assert(snap !== undefined, `Snap "${snapId}" not found.`);
return snap;
}

Expand Down Expand Up @@ -4169,7 +4169,7 @@ export class SnapController extends BaseController<
#createRollbackSnapshot(snapId: SnapId): RollbackSnapshot {
assert(
this.#rollbackSnapshots.get(snapId) === undefined,
new Error(`Snap "${snapId}" rollback snapshot already exists.`),
`Snap "${snapId}" rollback snapshot already exists.`,
);

this.#rollbackSnapshots.set(snapId, {
Expand All @@ -4182,7 +4182,7 @@ export class SnapController extends BaseController<

assert(
newRollbackSnapshot !== undefined,
new Error(`Snapshot creation failed for ${snapId}.`),
`Snapshot creation failed for ${snapId}.`,
);
return newRollbackSnapshot;
}
Expand Down Expand Up @@ -4272,10 +4272,7 @@ export class SnapController extends BaseController<

#getRuntimeExpect(snapId: SnapId): SnapRuntimeData {
const runtime = this.#getRuntime(snapId);
assert(
runtime !== undefined,
new Error(`Snap "${snapId}" runtime data not found`),
);
assert(runtime !== undefined, `Snap "${snapId}" runtime data not found`);
return runtime;
}

Expand Down
16 changes: 5 additions & 11 deletions packages/snaps-controllers/src/snaps/Timer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class Timer {
cancel() {
assert(
this.status === 'paused' || this.status === 'running',
new Error('Tried to cancel a not running Timer'),
'Tried to cancel a not running Timer',
);
this.onFinish(false);
}
Expand All @@ -65,10 +65,7 @@ export class Timer {
* @throws {@link Error}. If it wasn't running or paused.
*/
finish() {
assert(
this.status !== 'finished',
new Error('Tried to finish a finished Timer.'),
);
assert(this.status !== 'finished', 'Tried to finish a finished Timer.');
this.onFinish(true);
}

Expand All @@ -80,7 +77,7 @@ export class Timer {
pause() {
assert(
this.state.value === 'running',
new Error('Tried to pause a not running Timer'),
'Tried to pause a not running Timer',
);

const { callback, start, timeout, remaining } = this.state;
Expand All @@ -102,7 +99,7 @@ export class Timer {
start(callback: () => void) {
assert(
this.state.value === 'stopped',
new Error('Tried to start an already running Timer'),
'Tried to start an already running Timer',
);

const { remaining } = this.state;
Expand All @@ -116,10 +113,7 @@ export class Timer {
* @throws {@link Error}. If it wasn't paused.
*/
resume() {
assert(
this.state.value === 'paused',
new Error('Tried to resume not paused Timer'),
);
assert(this.state.value === 'paused', 'Tried to resume not paused Timer');
const { remaining, callback } = this.state;
const start = Date.now();

Expand Down
Loading