-
Notifications
You must be signed in to change notification settings - Fork 637
chore: Bump @metamask/phishing-controller from 13.1.0 to 14.1.1 #3674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d007a70
eff849e
653b9d2
7485f7c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,7 @@ | |
| }, | ||
| "@metamask/utils>@noble/hashes": { | ||
| "globals": { | ||
| "TextDecoder": true, | ||
| "TextEncoder": true | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,6 +113,7 @@ | |
| }, | ||
| "@metamask/utils>@noble/hashes": { | ||
| "globals": { | ||
| "TextDecoder": true, | ||
| "TextEncoder": true | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,6 +113,7 @@ | |
| }, | ||
| "@metamask/utils>@noble/hashes": { | ||
| "globals": { | ||
| "TextDecoder": true, | ||
| "TextEncoder": true | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,7 @@ | |
| }, | ||
| "@metamask/utils>@noble/hashes": { | ||
| "globals": { | ||
| "TextDecoder": true, | ||
| "TextEncoder": true | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2884,7 +2884,7 @@ __metadata: | |
| languageName: unknown | ||
| linkType: soft | ||
|
|
||
| "@metamask/base-controller@npm:^8.0.0, @metamask/base-controller@npm:^8.0.1, @metamask/base-controller@npm:^8.4.1": | ||
| "@metamask/base-controller@npm:^8.0.0, @metamask/base-controller@npm:^8.4.1": | ||
| version: 8.4.1 | ||
| resolution: "@metamask/base-controller@npm:8.4.1" | ||
| dependencies: | ||
|
|
@@ -3012,7 +3012,7 @@ __metadata: | |
| languageName: unknown | ||
| linkType: soft | ||
|
|
||
| "@metamask/controller-utils@npm:^11.11.0, @metamask/controller-utils@npm:^11.5.0": | ||
| "@metamask/controller-utils@npm:^11.14.1, @metamask/controller-utils@npm:^11.5.0": | ||
| version: 11.14.1 | ||
| resolution: "@metamask/controller-utils@npm:11.14.1" | ||
| dependencies: | ||
|
|
@@ -3924,18 +3924,20 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@metamask/phishing-controller@npm:^13.1.0": | ||
| version: 13.1.0 | ||
| resolution: "@metamask/phishing-controller@npm:13.1.0" | ||
| "@metamask/phishing-controller@npm:^14.1.1": | ||
| version: 14.1.1 | ||
| resolution: "@metamask/phishing-controller@npm:14.1.1" | ||
| dependencies: | ||
| "@metamask/base-controller": "npm:^8.0.1" | ||
| "@metamask/controller-utils": "npm:^11.11.0" | ||
| "@noble/hashes": "npm:^1.4.0" | ||
| "@metamask/base-controller": "npm:^8.4.1" | ||
| "@metamask/controller-utils": "npm:^11.14.1" | ||
| "@noble/hashes": "npm:^1.8.0" | ||
| "@types/punycode": "npm:^2.1.0" | ||
| ethereum-cryptography: "npm:^2.1.2" | ||
| fastest-levenshtein: "npm:^1.0.16" | ||
| punycode: "npm:^2.1.1" | ||
| checksum: 10/c62f71291736dfd635cc69b2d422687d8d610591a5e1cd9a6b4806cdc19221a72fe7699c0cabe0a2a108b49c3cc4dcb88a5b283fba374fe13e54d5813fb77902 | ||
| peerDependencies: | ||
| "@metamask/transaction-controller": ^60.4.0 | ||
| checksum: 10/c1e61a3cadb404a0c74f2d4d8f6b7c1f144563000db701cccf3402a72bfa143ce7e4e3deaa6763882e6e1ea209433aaade9453388324ad90c93a6b289f984e2d | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Phishing Controller Dependency IssueThe update to Additional Locations (2) |
||
| languageName: node | ||
| linkType: hard | ||
|
|
||
|
|
@@ -4252,7 +4254,7 @@ __metadata: | |
| "@metamask/key-tree": "npm:^10.1.1" | ||
| "@metamask/object-multiplex": "npm:^2.1.0" | ||
| "@metamask/permission-controller": "npm:^11.0.6" | ||
| "@metamask/phishing-controller": "npm:^13.1.0" | ||
| "@metamask/phishing-controller": "npm:^14.1.1" | ||
| "@metamask/post-message-stream": "npm:^10.0.0" | ||
| "@metamask/rpc-errors": "npm:^7.0.3" | ||
| "@metamask/snaps-registry": "npm:^3.2.3" | ||
|
|
@@ -4544,7 +4546,7 @@ __metadata: | |
| "@metamask/json-rpc-middleware-stream": "npm:^8.0.8" | ||
| "@metamask/key-tree": "npm:^10.1.1" | ||
| "@metamask/permission-controller": "npm:^11.0.6" | ||
| "@metamask/phishing-controller": "npm:^13.1.0" | ||
| "@metamask/phishing-controller": "npm:^14.1.1" | ||
| "@metamask/snaps-controllers": "workspace:^" | ||
| "@metamask/snaps-execution-environments": "workspace:^" | ||
| "@metamask/snaps-rpc-methods": "workspace:^" | ||
|
|
@@ -4920,13 +4922,20 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@noble/hashes@npm:1.7.1, @noble/hashes@npm:^1.1.2, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:^1.4.0, @noble/hashes@npm:^1.7.1": | ||
| "@noble/hashes@npm:1.7.1": | ||
| version: 1.7.1 | ||
| resolution: "@noble/hashes@npm:1.7.1" | ||
| checksum: 10/ca3120da0c3e7881d6a481e9667465cc9ebbee1329124fb0de442e56d63fef9870f8cc96f264ebdb18096e0e36cebc0e6e979a872d545deb0a6fed9353f17e05 | ||
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@noble/hashes@npm:^1.1.2, @noble/hashes@npm:^1.3.1, @noble/hashes@npm:^1.3.2, @noble/hashes@npm:^1.7.1, @noble/hashes@npm:^1.8.0": | ||
| version: 1.8.0 | ||
| resolution: "@noble/hashes@npm:1.8.0" | ||
| checksum: 10/474b7f56bc6fb2d5b3a42132561e221b0ea4f91e590f4655312ca13667840896b34195e2b53b7f097ec080a1fdd3b58d902c2a8d0fbdf51d2e238b53808a177e | ||
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@noble/secp256k1@npm:^1.7.1": | ||
| version: 1.7.1 | ||
| resolution: "@noble/secp256k1@npm:1.7.1" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unmet Peer Dependency Causes Issues
Updating
@metamask/phishing-controllerto14.1.1introduces a new peer dependency on@metamask/transaction-controller: ^60.4.0. This dependency isn't satisfied, which may cause peer dependency warnings or runtime errors.Additional Locations (1)
packages/snaps-simulation/package.json#L63-L64