fix: Wait for unlock before handling manageAccounts requests#3686
Merged
FrederikBolding merged 2 commits intomainfrom Oct 16, 2025
Merged
fix: Wait for unlock before handling manageAccounts requests#3686FrederikBolding merged 2 commits intomainfrom
manageAccounts requests#3686FrederikBolding merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 417 417
Lines 11924 11925 +1
Branches 1851 1851
=======================================
+ Hits 11721 11722 +1
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSnapKeyringfails when the client is locked since we cannot access theKeyringController. As with every other Snaps API, we want to wait for the client to be unlocked before allowing use of functionality that accesses the vault.Note
Adds
getUnlockPromisetomanageAccountsand awaits unlock before routing requests to the snap keyring, with tests updated accordingly.snap_manageAccounts:getUnlockPromiseto method hooks and awaitgetUnlockPromise(true)before callinggetSnapKeyringand routing tohandleKeyringSnapMessageinmanageAccounts.ts.specificationBuilderandmanageAccountsBuilder.methodHooksto includegetUnlockPromise.manageAccounts.test.tsto includegetUnlockPromisein hooks and mocks; maintain validation and routing assertions.jest.config.js.Written by Cursor Bugbot for commit ba55813. This will update automatically on new commits. Configure here.