-
-
Notifications
You must be signed in to change notification settings - Fork 96
Bump @metamask/eslint-config-typescript from 14.0.0 to 15.0.0 #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump @metamask/eslint-config-typescript from 14.0.0 to 15.0.0 #443
Conversation
Bumps [@metamask/eslint-config-typescript](https://github.com/MetaMask/eslint-config) from 14.0.0 to 15.0.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](https://github.com/MetaMask/eslint-config/compare/@metamask/eslint-config-typescript@14.0.0...@metamask/eslint-config-typescript@15.0.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-typescript" dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
| "@metamask/eslint-config-jest": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer dependency mismatch on eslint-config
High Severity
Upgrading @metamask/eslint-config-typescript to 15.0.0 requires @metamask/eslint-config at version ^15.0.0 as a peer dependency, but the package remains at ^14.0.0. This mismatch will cause peer dependency warnings during installation and potential runtime conflicts. The related packages @metamask/eslint-config-browser, @metamask/eslint-config-jest, and @metamask/eslint-config-nodejs also need upgrading to 15.0.0 for consistency.
Additional Locations (1)
| "@metamask/eslint-config-jest": "^14.0.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeScript-ESLint version below peer dependency requirement
Medium Severity
The upgraded @metamask/eslint-config-typescript@15.0.0 requires typescript-eslint@^8.39.0 as a peer dependency, but the package specifies ^8.6.0. While the caret range allows higher versions, the existing yarn.lock will keep the installed version at 8.6.0, causing peer dependency warnings and potentially missing compatibility fixes or features required by the new eslint config version.
Bumps @metamask/eslint-config-typescript from 14.0.0 to 15.0.0.
Release notes
Sourced from
@metamask/eslint-config-typescript's releases.... (truncated)
Commits
0b8cf6dRelease/15.0.0 (#431)9568eb3fix: Disablejsdoc/check-indentationto fix bullet list formatting (#430)7837174feat: Loosen@typescript-eslint/naming-conventionfor object literal proper...cf93ef1fix: Disableimport-x/no-duplicatesin TypeScript files (#427)f3246f7chore: Disable redudant lint rule (#425)383fbecfeat: Disable@typescript-eslint/no-unnecessary-type-arguments(#426)a0e0bc8feat: Convert all warnings to errors (#424)b243e90chore: Increase minimumtypescript-eslintversion (#423)b116974Allow remaining TypeScript 5.x versions (#422)c70a3ffBREAKING: Updatejsdoc/require-jsdocto require documentation for more thin...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade linter config to v15
@metamask/eslint-config-typescriptfrom^14to^15inpackage.jsonyarn.lockto resolve v15, including peer changes:@metamask/eslint-config^15,typescriptrange widened (>=4.8.4 <6), andtypescript-eslintraised to^8.39.0Scope: Dev-only lint configuration; no runtime code changes.
Written by Cursor Bugbot for commit 586534c. This will update automatically on new commits. Configure here.