make @metamask/vault-decryptor site publishable #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "files": [ | ||
| "index.html", | ||
| "bundle.js" | ||
| ], |
There was a problem hiding this comment.
Main entry point file excluded from published package
Medium Severity
The files array specifies only index.html and bundle.js to be included in the published package, but the main field still references index.js, which won't be published. When consumers try to require('@metamask/vault-decryptor'), npm will attempt to load index.js and fail because that file doesn't exist in the published package. The main field should either be removed, updated to point to an included file, or index.js (and its dependencies in lib/ and app/) should be added to files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make @metamask/vault-decryptor site publishable.
Part of the larger effort to remove live requests from E2E tests: MMQA-273
JIRA task: MMQA-669
Note
Prepares the package for public npm publishing.
private: truefrompackage.jsonfileswhitelist to publish onlyindex.htmlandbundle.jspublishConfigwithaccess: publicand npm registry URLpackageManagerformatting adjustmentWritten by Cursor Bugbot for commit 47a36a1. This will update automatically on new commits. Configure here.