-
-
Notifications
You must be signed in to change notification settings - Fork 188
make @metamask/vault-decryptor site publishable #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Unik0rnMaggie
wants to merge
7
commits into
master
Choose a base branch
from
site-npm-package
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
75b4cb9
make @metamask/vault-decryptor site publishable
Unik0rnMaggie 6a063e6
update files
Unik0rnMaggie 47a36a1
Merge branch 'master' into site-npm-package
Unik0rnMaggie e8f0613
update for Bugbot comment
Unik0rnMaggie d582297
resolve review comment-add GHA workflow for deplayment
Unik0rnMaggie 0290553
update workflow deplay-pages
Unik0rnMaggie ec94841
updates for review comment
Unik0rnMaggie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| { | ||
| "name": "@metamask/vault-decryptor", | ||
| "version": "1.0.0", | ||
| "private": true, | ||
| "description": "Utility for decrypting MetaMask vault data", | ||
| "main": "index.js", | ||
| "files": [ | ||
| "index.html", | ||
| "bundle.js" | ||
| ], | ||
Unik0rnMaggie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "scripts": { | ||
| "start": "beefy index.js:bundle.js --live --open", | ||
| "test": "jest && jest-it-up", | ||
|
|
@@ -72,5 +75,9 @@ | |
| "engines": { | ||
| "node": ">=18.0.0" | ||
| }, | ||
| "packageManager": "[email protected]" | ||
| "packageManager": "[email protected]", | ||
| "publishConfig": { | ||
| "access": "public", | ||
| "registry": "https://registry.npmjs.org/" | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this PR is not just about making the site publishable, we are also making the package public as well. Do we want to set this version to 0.0.0? Otherwise, when we make a PR to release the package, the version won't be changed (or maybe it will, but it might go from 1.0.0 to something 0.1.0 which would be strange).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Updated version to 0.0.0