Fix/copy swarm file #145
Merged
Fix/copy swarm file #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update: mapper find method - update: usages in service and storage - fix: copy function to check for id value
JoaoSRaposo
approved these changes
Jun 17, 2025
Collaborator
JoaoSRaposo
left a comment
JoaoSRaposo
left a comment
There was a problem hiding this comment.
I tested the following features in the local development environment (NC 30):
Export: ok
Comments: ok
Upload: ok.
Download: ok.
Archive Files and Folders: ok.
Unarchive Files and Folders: ok.
Rename files: ok
Rename folder: ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
SwarmFileentity and its associated mapper and services, replacing thefileIdproperty withidfor consistency and simplifying the codebase. The changes span several files, including updates to method names, property definitions, and logic adjustments to align with the new naming convention.Refactoring of
SwarmFileEntity:fileIdproperty and its associated getter and setter methods fromSwarmFile. Updated the constructor to exclude thefileIdtype definition. (lib/Db/SwarmFile.php: [1] [2] [3]Updates to
SwarmFileMapper:findByFileIdmethod tofindByIdand updated the query logic to useidinstead offileId. (lib/Db/SwarmFileMapper.php: lib/Db/SwarmFileMapper.phpL47-R53)Adjustments in Service and Storage Logic:
getTokenmethod inEthswarmServiceto usefindByIdinstead offindByFileId. (lib/Service/EthswarmService.php: lib/Service/EthswarmService.phpL77-R78)copymethod inBeeSwarmto usegetIdinstead ofgetFileIdand added support for copying thevisibilityproperty from the source file to the new file entry. (lib/Storage/BeeSwarm.php: [1] [2]