Feat/watchers logs #114
Feat/watchers logs #114
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces significant enhancements to the eVault Core and W3ID systems. It adds new documentation for eVault Core and W3ID integration, implements a Fastify-based HTTP server with GraphQL and REST endpoints, and integrates a secure secrets store for cryptographic key management. The W3ID module is refactored to support log-based identity management with multi-signature proofs, key rotation, and watcher signature requests. TypeScript configuration and dependencies are updated, and new tests are added for log storage. Docker Compose and Nomad job specifications are updated to support new environment variables and volume mounts. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant FastifyServer
participant W3ID
participant LogService
participant SecretsStore
participant Watcher
Client->>FastifyServer: POST /watchers/request (w3id, logEntryId)
FastifyServer->>W3ID: Resolve W3ID and logEntryId
W3ID->>LogService: Retrieve log entry
FastifyServer->>Watcher: Send signature request (signed JWT)
Watcher-->>FastifyServer: Respond with requestId
FastifyServer-->>Client: Return requestId
Client->>FastifyServer: POST /watchers/sign (w3id, logEntryId, proof)
FastifyServer->>W3ID: Resolve W3ID
W3ID->>LogService: Retrieve log entry
FastifyServer->>SecretsStore: Verify signature
FastifyServer-->>LogService: Append proof to log event
FastifyServer-->>Client: Return success/failure
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 22
🧹 Nitpick comments (17)
infrastructure/w3id/src/logs/log-manager.ts (2)
105-105: Consider adding more detailed error information.The error message "No proof found in the log event" is helpful, but could be enhanced with more context such as the log event ID to aid in troubleshooting.
- throw new BadSignatureError("No proof found in the log event."); + throw new BadSignatureError(`No proof found in the log event (ID: ${e.id}).`);
47-83: Consider adding log chain validation documentation.The validateLogChain method is critical for security but lacks documentation about its validation steps. Consider adding detailed comments explaining each validation step.
/** * Validate a chain of W3ID logs * + * Performs validation by: + * 1. Verifying sequential indexing (no gaps) + * 2. Verifying hash chain integrity (each entry references previous hash) + * 3. Verifying update keys are properly authorized by previous next key hashes + * 4. Verifying cryptographic signatures on each log event * * @param {LogEvent[]} log * @param {VerifierCallback} verifyCallback * @returns {Promise<true>} */infrastructure/w3id/tests/utils/crypto.ts (1)
10-29: Properly implemented multi-proof verification.The
verifierCallbackfunction has been successfully updated to handle an array ofProofobjects, aligning with the type changes. The implementation correctly verifies each proof and returns a combined result.Consider this optimization to short-circuit the verification process when an invalid signature is found:
export const verifierCallback: VerifierCallback = async ( message: string, proofs: Proof[], pubKey: string, ) => { - let isValid = true; - for (const proof of proofs) { + for (const proof of proofs) { const signatureBuffer = base58btc.decode(proof.signature); const messageBuffer = stringToUint8Array(message); const publicKey = hexToUint8Array(pubKey); const valid = nacl.sign.detached.verify( messageBuffer, signatureBuffer, publicKey, ); - if (!valid) isValid = false; + if (!valid) return false; } - return isValid; + return true; };infrastructure/evault-core/src/w3id/log-storage.ts (1)
81-94:findManyignores theoptionsfilterThe method signature suggests caller‑supplied filters, but the Cypher query returns all log events.
Either:a) Accept you don’t support filtering yet and drop the
optionsparameter, or
b) Build a dynamicWHEREclause using the provided partial fields.Returning unfiltered data may lead to huge result sets and unnecessary bandwidth / memory usage.
infrastructure/w3id/README.md (1)
171-179: Minor punctuation improvements for readabilityLanguageTool flagged a few missing commas around “for example” and before coordinating conjunctions. Adding them clarifies sentence boundaries without altering meaning.
-So for example a user "Jack" says I trust the notary but I also want "Bob" to approve the action each time a notary tries to change the keys which are controlled by Jack. +So, for example, a user “Jack” says, “I trust the notary, but I also want ‘Bob’ to approve the action each time a notary tries to change the keys that are controlled by Jack.”Pure documentation nit – feel free to ignore if house style differs.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~171-~171: This expression is usually spelled with a hyphen.
Context: ...t. ### Additional Considerations #### Friend Based Recovery 2-3 Friends may verify the id...(BASED_HYPHEN)
[typographical] ~172-~172: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...iderations #### Friend Based Recovery 2-3 Friends may verify the identity of a pe...(HYPHEN_TO_EN)
[uncategorized] ~173-~173: A comma might be missing here.
Context: ...l have access to their keys. This trust list by default would have a list of all not...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~173-~173: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... a list of all notaries in the ecosystem but the user may modify it and add people w...(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~174-~174: A comma might be missing here.
Context: ...of changing keys at their end as well. So for example a user "Jack" says I trust ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~175-~175: A comma might be missing here.
Context: ...ging keys at their end as well. So for example a user "Jack" says I trust the notary b...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~175-~175: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...le a user "Jack" says I trust the notary but I also want "Bob" to approve the action...(COMMA_COMPOUND_SENTENCE)
[grammar] ~175-~175: Do not use the singular ‘a’ before the plural noun ‘tries’.
Context: ...t "Bob" to approve the action each time a notary tries to change the keys which are controlled...(VB_A_JJ_NNS)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...Jack. #### Migration of eVault In the implementation it must be ensured that the file is sti...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~179-~179: After the expression ‘for example’ a comma is usually used.
Context: ...time someone migrates their eVault. For example if a user migrates evault `e4d909c2-5d2...(COMMA_FOR_EXAMPLE)
infrastructure/evault-core/src/utils/codec.ts (2)
18-20:TextEncodermay be undefined in older Node runtimes
TextEncoderis only global in Node ≥ v18. For Node 14/16 you need:
import { TextEncoder } from 'util';Consider adding a small helper (
getTextEncoder()) or documenting the minimum Node version.
25-46: Custom Base58 implementation is Node‑only & re‑implements a well‑tested library
- Uses
Buffer(not available in browsers unless poly‑filled).- Crypto‑heavy code tends to hide edge‑case bugs; the
multiformats/bs58packages are audited and already in your dependency tree.Unless you have a hard requirement to avoid external deps, prefer:
-import { ... } from "./codec"; // keep others +import { base58btc } from 'multiformats/bases/base58'; // … export function base58btcMultibaseEncode(u8: Uint8Array) { - return 'z' + base58btcEncode(u8); + return base58btc.encode(u8); } export function base58btcMultibaseDecode(str: string) { - if (!str.startsWith('z')) throw new Error(...); - return base58btcDecode(str.slice(1)); + return base58btc.decode(str); }Reduces maintenance & improves interop.
Also applies to: 48-61
infrastructure/evault-core/src/evault.ts (2)
25-38: Default Neo4j credentials expose data in non‑dev deploymentsFalling back to
neo4j/neo4jis convenient for local dev but dangerous if someone deploys without overriding env vars.Consider:
- Failing hard (
throw) when any of the three vars is missing unlessNODE_ENV === 'development'.- Logging a very loud warning indicating the DB is unsecured.
96-106: Missing graceful shutdown – driver & server remain open
fastify.listen()returns a server that should be closed, and the Neo4j driver leaks sockets.Add:
process.on('SIGTERM', async () => { await this.server.close(); await this.driver.close(); process.exit(0); });infrastructure/evault-core/src/secrets/secrets-store.ts (2)
53-56: Consider persisting objects directly instead of double‑serialising
writeStore()already stringifies the whole store. By stringifying eachStoredSeedagain (line 100) you end up with:{ "w3id‑alice": "{\"encrypted\":\"…\"}" }This adds complexity, inflates file size ~2× and requires extra
JSON.parse/stringifyhops. Storing the object directly keeps the file readable and avoids unnecessary processing.
78-90: Authentication tag coupling is brittleAppending the 16‑byte GCM tag to the ciphertext and slicing it back with the hard‑coded
TAG_LENGTHworks, but couples correctness to that constant. If the algorithm or tag length changes, decrypt will silently break.A more future‑proof layout is to store the tag separately (as is done for
iv&salt) e.g.:return { encrypted: uint8ArrayToHex(Buffer.concat([cipher.update(data), cipher.final()])), iv: uint8ArrayToHex(iv), salt: uint8ArrayToHex(salt), tag: uint8ArrayToHex(cipher.getAuthTag()) }and pass
tagexplicitly todecrypt.infrastructure/evault-core/src/http/server.ts (1)
87-88: Avoid banned{}type – useunknowninsteadStatic‑analysis flags the empty‑object type. Since
/whoishas no body you can omit the generic entirely:- async (request: TypedRequest<{}>, reply: TypedReply) => { + async (_request: TypedRequest<unknown>, reply: TypedReply) => {or simply
FastifyRequestif no type parameter is needed.🧰 Tools
🪛 Biome (1.9.4)
[error] 87-87: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
infrastructure/w3id/src/w3id.ts (2)
124-136: Simplify null‑checks using optional chaining & improve readabilityThe compound assignment to
this.idis a bit hard to parse and triggered a static‑analysis hint.
You can get the same semantics with cleaner code and avoid the “double evaluation” of
this.id:- this.id = - this.id && this.id?.includes("@") ? this.id.split("@")[1] : this.id; + // Strip leading '@' once, if present + this.id = this.id?.startsWith("@") ? this.id.slice(1) : this.id;This refactor also gets rid of the false‑positive about optional chaining.
🧰 Tools
🪛 Biome (1.9.4)
[error] 132-132: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
62-79: Minor typos in JSDoc
- “identifer” → “identifier” (twice)
- “rotateble” → “rotatable”
Fixing these improves generated docs and developer experience.
infrastructure/evault-core/README.md (1)
118-127: Avoid committing real credentials in sample.envblocksEven though this is documentation, using obvious values like
NEO4J_PASSWORD=your_password
sometimes encourages copy‑pasting insecure defaults into deployments. Consider replacing
with<password>placeholders and adding a short warning to change them.infrastructure/evault-core/docs/w3id-integration.md (2)
67-83: Document expected HTTP status codes to improve API clarityFor
/watchers/signyou list only a generic JSON body.
Adding the expected success status (201 Createdor200 OK) and possible failure
statuses (400,401,409, etc.) will make the contract unambiguous for clients.
142-160: Typo & style nitpick
- “Log entries are immutable once signed.” – consider clarifying what constitutes
“signed” (e.g. quorum achieved, first signature, etc.)- Missing article: “Signature Request Process” – “User requests a signature…”
Not blocking, but polishing wording helps future readers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (25)
evault.docker-compose.yml(2 hunks)infrastructure/evault-core/README.md(1 hunks)infrastructure/evault-core/docs/w3id-integration.md(1 hunks)infrastructure/evault-core/package.json(1 hunks)infrastructure/evault-core/src/evault.ts(1 hunks)infrastructure/evault-core/src/http/server.ts(1 hunks)infrastructure/evault-core/src/http/types.ts(1 hunks)infrastructure/evault-core/src/secrets/secrets-store.ts(1 hunks)infrastructure/evault-core/src/utils/codec.ts(1 hunks)infrastructure/evault-core/src/utils/signer.ts(1 hunks)infrastructure/evault-core/src/w3id/log-service.ts(1 hunks)infrastructure/evault-core/src/w3id/log-storage.ts(1 hunks)infrastructure/evault-core/src/w3id/w3id.ts(1 hunks)infrastructure/evault-core/tests/log-storage.spec.ts(1 hunks)infrastructure/evault-core/tsconfig.json(1 hunks)infrastructure/evault-provisioner/package.json(1 hunks)infrastructure/evault-provisioner/src/index.ts(3 hunks)infrastructure/evault-provisioner/src/templates/evault.nomad.ts(3 hunks)infrastructure/w3id/README.md(3 hunks)infrastructure/w3id/src/index.ts(1 hunks)infrastructure/w3id/src/logs/log-manager.ts(2 hunks)infrastructure/w3id/src/logs/log.types.ts(1 hunks)infrastructure/w3id/src/w3id.ts(1 hunks)infrastructure/w3id/tests/utils/crypto.ts(2 hunks)platforms/registry/src/consul.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (9)
infrastructure/evault-core/tests/log-storage.spec.ts (2)
infrastructure/evault-core/src/w3id/log-storage.ts (1)
Neo4jLogStorage(14-98)infrastructure/w3id/src/logs/log.types.ts (1)
LogEvent(7-15)
infrastructure/evault-core/src/w3id/log-service.ts (3)
infrastructure/evault-core/src/types/w3id.ts (1)
StorageSpec(1-9)infrastructure/w3id/src/logs/log.types.ts (1)
LogEvent(7-15)infrastructure/evault-core/src/w3id/log-storage.ts (1)
Neo4jLogStorage(14-98)
infrastructure/w3id/src/logs/log.types.ts (1)
infrastructure/evault-core/src/types/w3id.ts (1)
Signer(11-15)
infrastructure/evault-provisioner/src/index.ts (1)
infrastructure/w3id/src/w3id.ts (1)
W3IDBuilder(32-157)
infrastructure/w3id/tests/utils/crypto.ts (1)
infrastructure/w3id/src/logs/log.types.ts (1)
Proof(1-5)
infrastructure/evault-core/src/http/server.ts (5)
infrastructure/evault-core/src/http/types.ts (3)
TypedRequest(14-16)TypedReply(18-18)WatcherRequest(9-12)infrastructure/evault-core/src/w3id/w3id.ts (1)
W3ID(9-70)infrastructure/w3id/src/w3id.ts (1)
W3ID(9-30)infrastructure/w3id/src/logs/log.types.ts (1)
LogEvent(7-15)infrastructure/evault-core/src/utils/signer.ts (1)
verifierCallback(11-30)
infrastructure/evault-core/src/utils/signer.ts (2)
infrastructure/w3id/src/logs/log.types.ts (2)
VerifierCallback(17-21)Proof(1-5)infrastructure/evault-core/src/utils/codec.ts (5)
base58btcMultibaseDecode(81-86)stringToUint8Array(18-20)hexToUint8Array(7-16)uint8ArrayToHex(1-5)base58btcMultibaseEncode(77-79)
infrastructure/evault-core/src/secrets/secrets-store.ts (1)
infrastructure/evault-core/src/utils/codec.ts (2)
uint8ArrayToHex(1-5)hexToUint8Array(7-16)
infrastructure/evault-core/src/w3id/log-storage.ts (2)
infrastructure/evault-core/src/types/w3id.ts (1)
StorageSpec(1-9)infrastructure/w3id/src/logs/log.types.ts (1)
LogEvent(7-15)
🪛 GitHub Check: test
infrastructure/evault-core/tests/log-storage.spec.ts
[failure] 19-19: tests/log-storage.spec.ts > Neo4jLogStorage
TypeError: Neo4jLogStorage.build is not a function
❯ tests/log-storage.spec.ts:19:37
🪛 GitHub Actions: Tests [evault-core]
infrastructure/evault-core/tests/log-storage.spec.ts
[error] 19-19: TypeError: Neo4jLogStorage.build is not a function
🪛 GitHub Actions: Check Format
infrastructure/w3id/src/logs/log.types.ts
[error] 1-14: Formatter would have printed different content. Prettier formatting check failed. Run 'npx @biomejs/biome format ./src' to fix code style issues.
🪛 LanguageTool
infrastructure/w3id/README.md
[uncategorized] ~173-~173: A comma might be missing here.
Context: ...l have access to their keys. This trust list by default would have a list of all not...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~173-~173: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... a list of all notaries in the ecosystem but the user may modify it and add people w...
(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~174-~174: A comma might be missing here.
Context: ...of changing keys at their end as well. So for example a user "Jack" says I trust ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~175-~175: A comma might be missing here.
Context: ...ging keys at their end as well. So for example a user "Jack" says I trust the notary b...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~175-~175: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...le a user "Jack" says I trust the notary but I also want "Bob" to approve the action...
(COMMA_COMPOUND_SENTENCE)
[grammar] ~175-~175: Do not use the singular ‘a’ before the plural noun ‘tries’.
Context: ...t "Bob" to approve the action each time a notary tries to change the keys which are controlled...
(VB_A_JJ_NNS)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...Jack. #### Migration of eVault In the implementation it must be ensured that the file is sti...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~179-~179: After the expression ‘for example’ a comma is usually used.
Context: ...time someone migrates their eVault. For example if a user migrates evault `e4d909c2-5d2...
(COMMA_FOR_EXAMPLE)
infrastructure/evault-core/docs/w3id-integration.md
[uncategorized] ~133-~133: You might be missing the article “a” here.
Context: ...e Request Process** - User requests signature for a log entry - System verifies us...
(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~281-~281: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...S for all communications - Implement rate limiting - Monitor for suspicious activity #...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
infrastructure/evault-core/README.md
[uncategorized] ~89-~89: Loose punctuation mark.
Context: ...s #### Queries - getMetaEnvelopeById: Retrieve a specific MetaEnvelope - `fin...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~96-~96: Loose punctuation mark.
Context: ...s #### Mutations - storeMetaEnvelope: Create a new MetaEnvelope - `deleteMeta...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~102-~102: Loose punctuation mark.
Context: ...ontent ### HTTP Endpoints - /graphql: GraphQL API endpoint - /voyager: Grap...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~147-~147: You might be missing the article “the” here.
Context: ...Obtain a W3ID token 2. Include token in Authorization header 3. Access eVault resources based...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 Biome (1.9.4)
infrastructure/evault-core/src/http/server.ts
[error] 87-87: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
infrastructure/w3id/src/w3id.ts
[error] 132-132: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🔇 Additional comments (27)
infrastructure/evault-provisioner/package.json (1)
16-17: Added jose library for JWT verificationThe addition of the
josepackage at version^5.2.2is appropriate for JWT verification functionality that was introduced in the codebase. The express dependency has been maintained but repositioned in the list.infrastructure/evault-core/src/http/types.ts (1)
1-19: Well-structured TypeScript interfaces for HTTP request handlingThe type definitions are clear, well-organized, and follow TypeScript best practices. The interfaces properly define the structure for watcher signature requests and submissions, which aligns with the new Fastify-based HTTP routes for the eVault Core system.
The use of generic types for request bodies (
TypedRequest<T>) is a good practice for ensuring type safety in Fastify applications.infrastructure/evault-core/package.json (1)
27-40: Added appropriate dependencies for new featuresThe new dependencies are well-aligned with the described features of the pull request:
@fastify/swaggerand@fastify/swagger-uifor API documentationfastifyfor the HTTP servermultiformatsfor encoding utilitiestweetnaclfor cryptographic operationsaxiosfor HTTP requestsThese dependencies support the implementation of a Fastify-based HTTP server with GraphQL integration, W3ID log-based identity management, and secure storage features.
infrastructure/evault-core/tsconfig.json (2)
3-4: Modernized TypeScript configuration for better compatibility and optimization.The target has been lowered from ES2021 to ES2017 for broader runtime compatibility, while the module system has been upgraded to ESNext. This is a good balance between compatibility and modern features.
16-17: Simplified include/exclude configuration improves test integration.Simplifying these arrays, particularly removing spec file exclusions, aligns with the addition of new test suites mentioned in the PR objectives. This change ensures tests are properly compiled.
evault.docker-compose.yml (3)
14-16: Secure secrets management implementation.The addition of environment variables for secrets storage path, encryption password, and W3ID supports the new secure secrets management feature, enhancing the security of cryptographic materials.
17-18: Added persistent volume for secrets.The secrets volume mount provides persistent storage for cryptographic materials, crucial for maintaining identity across container restarts.
52-52: Added named volume declaration for secrets.The named volume definition ensures the secrets volume is properly recognized by Docker Compose.
infrastructure/evault-provisioner/src/templates/evault.nomad.ts (5)
40-57: Added persistent storage configuration for Nomad deployment.The CSI volume configuration for both evault-store and neo4j-data ensures data persistence and follows best practices with proper access modes and attachment settings.
76-82: Added volume mounts for Neo4j data persistence.Properly configuring the Neo4j data volume mount ensures database persistence across container restarts.
100-106: Added volume mounts for eVault data persistence.The evault-store volume mount ensures application data persistence and aligns with the Docker Compose configuration.
113-113: Added W3ID environment variable.The W3ID environment variable properly integrates with the new identity management system.
119-124: Improved task dependency specification.The explicit dependency condition ensures the evault service starts only when Neo4j is fully running, preventing connection issues during startup.
infrastructure/w3id/src/logs/log-manager.ts (3)
93-115: Enhanced signature verification to support multiple proofs.The refactored verification logic now properly handles multiple proofs, improving security and flexibility of the identity system. The implementation maintains the core validation checks while supporting multiple signers.
144-150: Implemented multi-signature support for log events.The updated appendEntry method now generates proof objects with complete metadata (kid, alg, signature), enhancing the log verification capabilities.
175-181: Consistent multi-signature implementation in genesis entries.The proof structure is consistently applied to genesis entries, ensuring uniform verification across all log entries.
infrastructure/w3id/src/logs/log.types.ts (3)
1-5: Well-structuredProoftype definition.This type effectively encapsulates all necessary information for signature verification, including key ID, signature value, and algorithm. This structured approach will make verification more robust compared to using a single string.
🧰 Tools
🪛 GitHub Actions: Check Format
[error] 1-14: Formatter would have printed different content. Prettier formatting check failed. Run 'npx @biomejs/biome format ./src' to fix code style issues.
7-15: Good refactoring from single proof to multiple proofs.Changing from a single
proofstring to an array ofProofobjects enables multi-signature verification workflows, which aligns well with the watchers logs feature being implemented.
17-21: TheVerifierCallbacksignature is appropriately updated.The signature now accepts an array of
Proofobjects, which is consistent with the changes to theLogEventtype.infrastructure/evault-core/tests/log-storage.spec.ts (2)
27-50: Well-structured test for creating and retrieving a log event.This test thoroughly verifies all fields of the created and retrieved log events, ensuring the storage implementation correctly persists and retrieves the data.
52-78: Good test for finding multiple log events.The test creates multiple log events and then verifies they can be retrieved with filtering. However, note that the test is not fully aligned with the implementation shown in the context.
Looking at the
findManyimplementation in the provided context, it doesn't actually filter by method:public async findMany(options: Partial<LogEvent>): Promise<LogEvent[]> { const session = this.driver.session(); try { const result = await session.run( ` MATCH (l:LogEvent) RETURN l ` ); const mapped = result.records.map((record) => this.mapToLogEvent(record.get("l").properties) ); return mapped; } finally { await session.close(); } }The query doesn't include any WHERE clause to filter by
method. Verify whether the actual implementation has been updated to support filtering or if this test's expectations need to be adjusted.infrastructure/evault-provisioner/src/index.ts (4)
7-7: Good addition of the jose library for JWT verification.Using the jose library for JWT verification is a solid choice for secure token validation.
16-19: Improved request interface with more explicit parameters.Changing from a single
w3idparameter to separateregistryEntropyandnamespaceparameters improves the API's clarity and security model.
43-52: Good input validation.The endpoint now properly validates the presence of both required fields with a clear error message.
61-68: Well-implemented W3ID creation using the builder pattern.The code properly creates two W3IDs: one for the eVault itself and one for the user, using the verified entropy and namespace. This approach provides more secure and structured identity management.
infrastructure/w3id/src/index.ts (1)
1-5: Potential duplicateStorageSpecexportThis barrel re‑exports
./logs/storage/storage-spec, butStorageSpecis also defined insideevault-core/src/types/w3id.ts.
If both are published under the same package name, consumers may import two distinct but identically named interfaces, leading to subtle type‑incompatibility errors.Consider centralising the type in one place and exporting it from there to avoid duplication.
infrastructure/evault-core/src/utils/signer.ts (1)
1-1: Module aliasw3idmay break outside monorepoImporting from
"w3id"assumes a path alias or published package. If consumers compile this sub‑package alone (e.g., in Lambda), the resolver will fail. Verify that:
tsconfig.pathsdefines"w3id"→infrastructure/w3id/src.- The alias is re‑mapped in the bundler (esbuild/webpack) or
package.json#exports.Otherwise switch to a relative import.
* feat: alloc according to entropy and namespace * chore: move exports * chore: docs * feat: `whois` endpoint * feat: watcher endpoints * chore: fix format and lint * chore: fix tests
* initial commit * chore: add w3id readme (#3) * chore: add w3id readme * chore: bold text * chore: better formatting * docs: add w3id details * chore: format * chore: add links * fix: id spec considerations addressal (#8) * fix: id spec considerations addressal * fix: identity -> indentifier * chore: expand on trust list based recovery * chore: expand on AKA --------- Co-authored-by: Merul Dhiman <[email protected]> * Docs/eid wallet (#10) * chore: add eid-wallet folder * chore: add eid wallet docs * feat: add (#9) * feat(w3id): basic setup (#11) * feat(w3id): basic setup * fix(root): add infrastructure workspaces * update: lock file * feat(eidw): setup tauri (#40) * Feat/setup daisyui (#46) * feat: setup-daisyui * fix: index file * feat: colors added * feat: Archivo font added * fix: postcss added * fix: +layout.svelte file added * fix: packages * fix: fully migrating to tailwind v4 * feat: add Archivo font * feat: add danger colors * feat: twmerge and clsx added * feat: shadcn function added --------- Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> * feat: add storybook (#45) * feat: add storybook * update: lockfile * feat: created connection button (#48) * created connection button * added restprops to parent class * added onClick btn and storybook * fix: make font work in storybook (#54) * Feat/header (#55) * feat: add icons lib * fix: make font work in storybook * feat: Header * feat: runtime global added, icon library created, icons added, type file added * feat: header props added * fix: remove icons and type file as we are using lib for icons * fix: heading style * fix: color and icons, git merge branch 51, 54 * fix: color * fix: header-styling * fix: classes * chore: handlers added * chore: handlers added * fix: added heading --------- Co-authored-by: Soham Jaiswal <[email protected]> * Alternative w3id diagram (#52) * Feat/cupertino pane (#49) * feat: Drawer * feat: Drawer and added a function for clickoutside in utils * fix: classes * fix: drawer button position * fix: style and clickoutside * fix: pane height * fix: border-radius * fix: drawer as bulletin * fix: styling * fix: component with inbuilt features * fix: remove redundant code * fix: remove redundant code * fix: cancel button * fix: css in storybook * fix: position * fix: height of pane * fix: remove redundant code * feat: add button action component (#47) * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * chore: add documentation * fix: configure Storybook * chore: storybook gunk removal * feat: enhance ButtonAction component with type prop and better error handling --------- Co-authored-by: JulienAuvo <[email protected]> * Feat/splash screen (#63) * feat: SplashScreen * fix: remove redundant code * fix: as per given suggestion * fix: font-size * fix: logo * feat: input-pin (#56) * feat: input-pin * fix: styling as per our design * fix: added small variant * fix: hide pin on select * fix: gap between pins * fix: color of focus state * fix: removed legacy code and also fix some css to tailwind css * fix: css * fix: optional props * feat: added color variants * Feat/improve button component (#60) * feat: add white variant * feat: add small variant * chore: update doc and story for button * chore: rename cb into callback * update: improve small size * update: modify loading style * fix: return getAbsolutePath function to storybook (#58) Co-authored-by: Bekiboo <[email protected]> * feat: add selector component (#59) * feat: add selector component * feat: improve selector + add flag-icon lib * feat: improve selector + doc * feat: add utility function to get language with country name * feat: test page for language selectors * chore: add Selector Story * chore: clean test page * fix: types * fix: normalize custom tailwind colors (#71) * feat: workflows (#64) * feat: workflows * fix: node version * fix: use pnpm 10 * fix: check message * Fix/codebase linting (#73) * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Code / lint * fix: Check Format / lint * fix: unknown property warning * fix: unknown property warning * chore: improve args type * settings nav button :) (#75) * setting bav button all done :) * lint fixski * added component to index.ts * Feat/#32 identity card fragment (#74) * identity card * identity card * lint fixski * lint fixski * lint fixski * fixed the font weight * added component to index.ts * changed span to buttton * feat: add icon button component (#68) * feat: add icon button component * feat: finish up buttonIcon + stories * fix: update with new color naming * feat: polish button icon (and button action too) * chore: format lint * chore: sort imports * chore: format, not sure why * Feat/onboarding flow (#67) * feat: onboarding-page * fix: line height and added handlers * fix: button variant * fix: text-decoration * fix: subtext * fix: underline * fix: padding and button spacing * fix: according to design update * feat: Drawer * feat: verify-pae * fix: verify-page styling * feat: drawer for both confirm pin and add bio metrics added * feat: modal added in fragments * fix: icons and flow * feat: Identifier Card * fix: copy to clipboard * feat: e-passport page * fix: error state * fix: colors * fix: lint error * fix: lint * feat: Typography * fix: typograpy * fix: as per given suggestion * fix: font-sizing * fix: identity card implementation * fix: spacing * fix: padding * fix: padding and spacing * fix: splashscreen * fix: error state * fix: styling to avoid * fix:typo * Fix/remove daisyui (#82) * refactoring: remove DaisyUI + refactor some tailwind classes and logic * refactoring: remove DaisyUI + refactor some tailwind classes and logic * feat: add Button.Nav (#77) * feat: add Button.Nav * chore: format * chore: sort imports * update: remove unused snippet and add missing props * feat: stick to fragment definition * update: documentation * fix: stories * chore: sort imports * Feat/splashscreen animation (#81) * feat: add animation to splashScreen * feat: implement data loading logic with splash screen delay * chore: sort import * update: use ButtonIcon is IdentityCard (#78) * update: use ButtonIcon is IdentityCard * feat: refactor ButtonIcon to be used anywhere in the app * chore: format indent * chore: remove useless change * feat: setup safe area (#80) * feat: setup safe area * chore: simplify implementation * chore: format * Feat/uuidv5 generation (#61) * feat: setup uuidv5 * chore: add test for deterministic UUID * feat: add Hero fragment (#88) * feat: add Hero fragment * chore: sort imports + add doc * feat: add storage specification abstract class (#92) * feat: add storage specification abstract class * chore: format and ignore lint * chore: change format checker on w3id * feat: settings-flow (#86) * feat: settings-flow * feat: settings and language page * feat : history page * feat: change pin page * fix: height of selector * fix: pin change page * fix: size of input pin * fix: spacing of pins * feat: AppNav fragment * fix: height of page * fix: padding * fix: remove redundant code * feat: privacy page * chore: add doc * fix: error state * feat: remove redundant code * chore: used app nav component --------- Co-authored-by: JulienAuvo <[email protected]> * feat: AppNav fragment (#90) * feat: AppNav fragment * chore: add doc * feat: Main page flow (#93) * feat: create root page + layout * feat: complete main page flow beta * chore: fix ts block * chore: sort imports * feat: integrate-flows (#94) * feat: intigrate-flows * fix: spacing in e-passport page * fix: page connectivity * feat: app page transitions * fix: z index * fix: pages * fix: view transition effect on splashscreen * fix: drawer pill and cancel button removed * fix: share button removed when onboarding * fix: remove share and view button when on onboarding flow * fix: remove view button * fix: ci checks * fix: transitions * fix: transititon according to direction * fix: lint error * fix: loop holes * Feat/w3id log generation (#98) * chore: create basic log generation mechanism * chore: add hashing utility function * chore: rotation event * feat: genesis entry * feat: generalize hash function * feat: append entry * chore: basic tests * chore: add tests for rotation * feat: add malform throws * chore: add the right errors * chore: fix CI stuff * chore: add missing file * chore: fix event type enum * chore: format * feat: add proper error * chore: format * chore: remove eventtypes enum * chore: add new error for bad options * chore: add options tests * feat: add codec tests * fix: err handling && jsdoc * fix: run format * fix: remove unused import * fix: improve default error messages * fix: move redundant logic to function * fix: run format * fix: type shadow * fix: useless conversion/cast * fix: run format --------- Co-authored-by: Soham Jaiswal <[email protected]> * Feat/core id creation logic (#99) * feat: create w3id builder * fix: w3id builder * feat: add global config var for w3id * chore: add docs * chore: change rand to crng * chore: add ts type again * chore: fix lint and format * chore: add w3id tests github workflow * Feat/evault core (#100) * feat: migrate neo4j * chore: envelope logic works * chore: envelope logic works * feat: parsed envelopes search * feat: generics * feat: protocol * feat: jwt sigs in w3id * chore: stuff works * chore: tests for evault core * chore: format * chore: fix test * Feat/docker compose and docs (#101) * chore: stash dockerfile progress * fix: getEnvelopesByOntology thing * chore: fix tests * Update infrastructure/evault-core/src/protocol/vault-access-guard.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: remove unused import * chore: remove package * chore: fix pnpm lock * chore: fix workflow * chore: fix port in dockerfile --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Feat/registry and evault provisioning (#106) * feat: evault provisioning * chore: fianlly fixed provisioner * feat: add logic for metadata in consul * feat: registry * chore: format * Feat/watchers logs (#114) * feat: alloc according to entropy and namespace * chore: move exports * chore: docs * feat: `whois` endpoint * feat: watcher endpoints * chore: fix format and lint * chore: fix tests * feat: web3 adapter (#115) * feat: tauri plugins setup (#97) * feat: tauri plugins setup * fix: add editorconfig * fix: add missing biome json * fix: run formatter * feat: biometry homework * feat: add pin set logic * feat: add biometric enabling logic * fix: sec controller qol * feat: stub user controller * fix: run format && lint * fix: sort imports * fix: import statement sort * feat: user controller * feat: pin flow * feat: biometrics unavailable * fix: pin input not working * feat: make checks pass * fix: scan works * fix: actions * feat: format on save * fix: coderabbit suggestions * chore: run format lint check * fix: scan on decline too * feat: documentation links (#117) * feat: bad namespace test (#116) * fix: layouts (#119) * fix: layouts * fix: Onboarding page scroll fixed * fix: page layout and prevent from scroll in all devices * fix: pages layout * chore: try to fix emulator * fix: units * fix: safezones for ios * fix: styling --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat: setup-metagram (#121) * feat: setup-metagram * chore: tailwind css worked * feat: fonts added * feat: typography * fix: removed stories and fixed setup for icons lib * feat: icons and story file * fix: type of args in story * fix: lint errors * feat: colors added * feat: Button * fix: format and lint * fix: colors * fix: spinner * fix: code rebbit suggestions * fix: code rebbit suggestions * fix: paraglide removed * fix: lock file * feat: added user avatar. (#130) * feat: Button (#129) * feat: Button * fix: colors of variants * feat: Input (#131) * feat: Input * feat: styling added * fix: styling * fix: styling * fix: added a new story * fix: focus states * fix: input states * Feat/settings navigation button (#140) * feat: settings-navigation-button * fix: handler added * chore: another variant added * fix: as per given suggestion * feat: BottomNav (#132) * feat: BottomNav * fix: icons * feat: profile icons created * feat: handler added * feat: handler added * fix: correct tags * fix: as per given suggestion, bottomnav moved to fragments and also implemented on page * fix: handler * chore: routes added * feat: app transitions added * fix: direction of transition * fix: transition css * fix: directionable transition * fix: used button instead of label, and used page from state * feat: added post fragment. (#137) * feat: FileInput (#150) * feat: FileInput * fix: added icon * feat: cancel upload * fix: remove redundant code * fix: usage docs added and as per requirements ' * fix: moved to framents * feat: Toggle Switch (#143) * feat: Toggle Switch * feat: Toggle Switch * fix: as per our design * fix: as per our design * feat: Label (#146) * feat: Select (#148) * feat: Select * fix: as per our design * fix: code format and as per svelte 5 * fix: font-size * fix: font-size * fix: icon * feat: message-input (#144) * feat: message-input * fix: classes merge and a files as a prop * feat: variant added * feat: icon replaced * fix: as per code rabbit suggestions * fix: icon * fix: input file button * fix: as per suggestion * fix: classes * fix: no need of error and disabled classes * fix: input * feat: invalid inputs * feat: add number input storybook --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat:Drawer (#152) * feat:Drawer * feat: Drawer with clickoutside * fix: settings * Feat/metagram header (#133) * feat: added metagram header primary linear gradient. * feat: added flash icon. * feat: added secondary state of header. * feat: added secondary state of header with menu. * chore: cleaned some code. * docs: updated component docs. --------- Co-authored-by: SoSweetHam <[email protected]> * Feat/metagram message (#135) * feat: added metagram message component. * feat: added both states of message component. * docs: added usage docs. * chore: exposed component from ui. * fix: component -> fragement --------- Co-authored-by: SoSweetHam <[email protected]> * feat: modal (#154) * fix: styling of modal * fix: modal props * fix: conflicting styles * fix: styles of drawer * fix: hide scrollbar in drawer * fix: padding * fix: used native method for dismissing of drawer * feat: Context-Menu (#156) * feat: Context-Menu * fix: name of component * fix: as per suggestion * fix: action menu position * fix: class * feat: responsive-setup (#157) * feat: responsive-setup * fix: background color * fix: added font fmaily * feat: responsive setup for mobile and desktop (#159) * feat: responsive setup for mobile and desktop * fix: width of sidebar and rightaside * fix: responsive layout * feat: SideBar * fix: added some finishing touches to sidebar and button * fix: prevent pages transition on desktop * fix: icon center * feat: settings page and icon added * feat/layout-enhancement (#168) * feat/infinite-scroll (#170) * feat/infinite-scroll * fix: aspect ratio of post * fix: bottom nav background * settings page (#169) * settings page layout done * settings page layout done * formt fix * format fix * format fix * routing for settings page fixed * settings page buttons * merge conflict * settings page tertiary pages * settings pages all done * settings pages unnecessary page deleted * requested changes done * requested changes done * Feat/comments pane (#171) * feat/comments-pane * fix: overflow and drawer swipe * feat: Comment fragment * fix: comments added * fix: comment fragment * feat: Comments reply * fix: message input position * fix: post type shifted to types file * fix: one level deep only * fix: drawer should only be render on mobile * fix: comments on layout page * fix: format * feat: messages (#174) * feat: messages * feat: ChatMessae * feat: messages by id * fix: messages page * fix: icon name * fix: hide bottom nav for chat * fix: header * fix: message bubble * fix: message bubble * fix: message bubble * fix: as per suggestion * fix: messaging * chore: change from nomad to k8s (#179) * chore: change from nomad to k8s * Update infrastructure/eid-wallet/src/routes/+layout.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: uri extraction * feat: regitry stuff * feat: registry using local db * 📝 Add docstrings to `feat/switch-to-k8s` (#181) Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: format --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: make scan qr page work again (#185) * feat: Discover Page (#180) * refactor/Post (#186) * refactor/Post * fix: format and lint * fix: added dots for gallery * fix: added dots for gallery * fix: added dots for gallery * fix: plural name * feat: splash-screen (#187) * Feat/evault provisioning via phone (#188) * feat: eid wallet basic ui for verification * chore: evault provisioning * feat: working wallet with provisioning * feat: restrict people on dupes * 📝 Add docstrings to `feat/evault-provisioning-via-phone` (#189) Docstrings generation was requested by @coodos. * #188 (comment) The following files were modified: * `infrastructure/eid-wallet/src/lib/utils/capitalize.ts` * `infrastructure/evault-provisioner/src/utils/hmac.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: added uploaded post view component. (#182) * feat: added uploaded post view component. * fix: fixed the outline and color. * fix: moved function to external definition. * fix: fixed the restProps. * profile page (#178) * basic layout for profile page * fixed alt text * merge conflict * profile page for other users implemented * fix: profile pages and logics * fixed all the pages of profile * fixed all the pages of profile * fix: format --------- Co-authored-by: gourav <[email protected]> * Feat/radio input (#176) * feat: added a radio button custom * docs: added name option in docs. * chore: cleaned the unnecessary classes and variables for input type radio. * fix: moved input radio to its own component. * fix: keydown events added. * feat: added settings tile component. (#184) * feat: added settings tile component. * chore: fixed the naming convention * chore: renamed callback to onclick * fix: fixed the use of restProps * fix: fixed the unnecessary onclick expose. * fix: fixed the join function params. * Feat/textarea (#194) * chore: removed redundant radio * feat: added textarea. * fix: tabindex * fix: removed type inconsitency. * Feat/mobile upload flow (#193) * fix: header logic in secondary * fix: fixed the text in header in post * feat: trying some hack to get file image input. * feat: added image input on clicking the post bottom nav * chore: got rid of non-required code. * feat: added the logic to get the images from user on clicking post tab. * feat: added store. * feat: added correct conversion of files. * feat: added the correct display of image when uploading. * feat: added settings tile to the post page and fixed the settingsTile component type of currentStatus * feat: added hte correct header for the audience page. * fix: fixed the page transition not happening to audience page. * feat: added audience setting * feat: added store to audience. * chore: removed console log * feat: added post button. * feat: correct button placement * fix: horizontal scroll * fix: positioning of the post button. * fix: protecting post route when no image is selected. * fix: improved type saftey * feat: added memory helper function * feat: added memory cleanup. * Feat/social media platforms (#195) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * Feat/social media platforms (#196) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * chore: add other socials * Feat/blabsy add clone (#198) * chore: clone twitter * feat: custom auth with firebase using w3ds * chore: add chat * feat: chat works with sync * feat: twittex * feat: global schemas * feat: blabsy adapter * refactor: shift some text messages to work on blabsy (#199) * chore: stash progress * chore: stash adapters * chore: stash working extractor * feat: adapter working properly for translating to global with globalIDs * feat: adapter toGlobal pristine * chore: stash * feat: adapter working * chore: stash until global translation from pictique * feat: bi-directional sync prestino * feat: bidir adapters * chore: login redir * chore: swap out for sqlite3 * chore: swap out for sqlite3 * chore: server conf * feat: messages one way * feat: ready to deploy * feat: ready to deploy * chore: auth thing pictique * chore: set adapter to node * chore: fix auth token thingy * chore: auth thing * chore: fix auth token thingy * chore: port for blabsy * feat: provision stuff * feat: provision * feat: provision * feat: provision * chore: fix sync * feat: temporary id thing * chore: android * chore: fix mapper sync * chore: fallback * feat: add error handling on stores * feat: fix issue with posts * chore: fix retry loop * Fix/author details (#229) * fix: author-details * fix: owner-details * fix: author avatar * fix: auth user avatar * fix: error handling * fix: author image in bottom nav --------- Co-authored-by: Merul Dhiman <[email protected]> * Fix/change name (#228) * fix: corrected the name to blabsy * fix: extra shit comming. * fix: fixed the alignment of the display in more to look more like current twitter. * fix: avatars (#226) * fix: avatars * fix: avatar in follow request page * fix: images uploaded shown in user profile * fix: button size * fix: avatar --------- Co-authored-by: Merul Dhiman <[email protected]> * chore: temp fix sync * chore: stash progress * Fix/post context menu (#231) * fix: post-context-menu * fix: user id with post * fix: removed redundant code * fix: images * fix: profile data * fix: profile data * fix: image cover * fix: logout * Fix/wallet text (#234) * changed text as per the request and fixed styling on pages with useless scroll * added settings button in main page which went missing somehow * fix: consistent padding * chore: change tags * feat: change icon * feat: webhook dynamic registry * feat: make camera permission work properlyh * chore: removed all locking mechanism thing from platforms * feat: synchronization works perfectly * feat: fixed everything up * feat: changes * chore: stats fix * chore: fix pictique visual issues * chore: fix cosmetic name issue * feat: fix sync issue * chore: fix logical issue here * chore: add qrcode ename * feat: add packages (#235) * feat: add packages * feat: add sample funcs + docs * fixed the filled color on like icon for liked post (#239) * feat: fake passport name * feat: double confirmation * chore: fix pictique login issue * fix: make no user case redir to login * fix: issues with wallet --------- Co-authored-by: Soham Jaiswal <[email protected]> Co-authored-by: SoSweetHam <[email protected]> Co-authored-by: Gourav Saini <[email protected]> Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Julien Connault <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Sahil Garg <[email protected]> Co-authored-by: Sahil Garg <[email protected]>
Description of change
Creates logs and watchers added docs
Issue Number
closes #103
closes #105
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
Tests
Style/Chores