fix: layouts

[ghost]

Description of change

Prevent page from scroll on smaller devices.

Issue Number

closes #118

Type of change

• Update (a change which updates existing functionality)
• Fix (a change which fixes an issue)

How the change has been tested

CI and Manual

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

Summary by CodeRabbit

• Style
  • Improved responsiveness of the onboarding page on mobile devices by updating spacing and sizing units to use dynamic viewport height (dvh).
  • Main container now uses a fixed height of 100dvh and flex column layout for better spacing.
  • Infographic image updated with explicit width and height, removing previous aspect ratio and rounded corners for a cleaner look.
  • Adjusted margins to optimize layout spacing on the onboarding page.
  • Updated vertical spacing units across multiple pages from viewport height (vh) to small viewport height (svh) for consistent and improved layout responsiveness.
  • Modified button size to small on the scan QR navigation button for a more compact appearance.
  • Enhanced viewport settings to allow content to extend into device safe areas for improved display on modern devices.
  • Added a default primary background color to the page body.
  • Wrapped main content in a container with white background, full viewport height, and scroll overflow for better layout control.

[coderabbitai]

"""

Walkthrough

The update modifies the styling across multiple Svelte components by replacing viewport height units (vh) with small viewport height units (svh or dsvh) for padding, margins, and container heights to improve responsiveness and fit within safe zones. The onboarding page container is set to 100 dynamic small viewport height units with a flex column layout and explicit sizing for an infographic image. Button sizing is adjusted in one component. These changes affect only styling and layout without altering component logic, event handling, or exported entities.

Changes

File(s)	Change Summary
infrastructure/eid-wallet/src/routes/(auth)/onboarding/+page.svelte	Replaced vh with dsvh/svh units for padding, margins, and container height; set main container to 100dsvh with flex column layout; resized infographic image with explicit width and height; removed margins on article and Hero section; adjusted Drawer margins.
infrastructure/eid-wallet/src/routes/(auth)/e-passport/+page.svelte,	Replaced vh units with svh units for vertical padding, margins, and spacing in main container and sections.
infrastructure/eid-wallet/src/routes/(auth)/login/+page.svelte,	Replaced vh units with svh units for vertical padding and margin in main container and error message paragraph.
infrastructure/eid-wallet/src/routes/(auth)/register/+page.svelte,	Replaced vh units with svh units for vertical padding and margins across multiple elements including main container, Hero, error messages, and Drawer content.
infrastructure/eid-wallet/src/routes/(auth)/review/+page.svelte,	Changed main container padding-top and padding-bottom from vh to svh units.
infrastructure/eid-wallet/src/routes/(auth)/verify/+page.svelte,	Changed main container padding-top and padding-bottom from vh to svh units.
infrastructure/eid-wallet/src/routes/(app)/settings/pin/+page.svelte,	Replaced vh units with svh units for height, padding, and margins in main container, paragraphs, and Drawer elements.
infrastructure/eid-wallet/src/routes/(app)/main/+page.svelte	Added size="sm" property to <Button.Action> inside <Button.Nav> linking to "/scan-qr".
infrastructure/eid-wallet/src/app.html	Added viewport-fit=cover to the viewport meta tag to enable content to extend into device safe areas.
infrastructure/eid-wallet/src/app.css	Added background-color set to CSS variable --color-primary on body.
infrastructure/eid-wallet/src/routes/+layout.svelte	Wrapped children content in a <div> with classes for white background, full dynamic viewport height, and scroll overflow.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure screens fit on pages without scrollbars; fix safe zones and layouts (#118)	✅	Replacing vh with svh/dsvh units and setting fixed container heights improves layout fit and prevents scrollbars.

Poem

A hop and a skip, the styles did shift,
From vh to dvh, a responsive gift.
The onboarding page now fits just right,
With corners smooth and spacing tight.
Rabbits cheer—no scroll in sight,
A perfect view, pure delight! 🐇✨
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11eed06 and 2ade163.

⛔ Files ignored due to path filters (1)

• infrastructure/eid-wallet/src-tauri/gen/android/.idea/AndroidProjectSystem.xml is excluded by !**/gen/**

📒 Files selected for processing (2)

• infrastructure/eid-wallet/src/app.css (1 hunks)
• infrastructure/eid-wallet/src/routes/+layout.svelte (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• infrastructure/eid-wallet/src/routes/+layout.svelte
• infrastructure/eid-wallet/src/app.css

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

infrastructure/eid-wallet/src/routes/(auth)/onboarding/+page.svelte (1)

44-44: Refine decimal-based spacing for consistency
You’ve used mt-[2.3dvh] mb-[0.5dvh] — consider rounding to whole or consistent decimals (e.g., 2dvh / 0.5dvh) if your design system avoids arbitrary fractions, to keep the vertical rhythm predictable.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa85d4 and bf27bd5.

📒 Files selected for processing (1)

• infrastructure/eid-wallet/src/routes/(auth)/onboarding/+page.svelte (2 hunks)

🔇 Additional comments (3)

infrastructure/eid-wallet/src/routes/(auth)/onboarding/+page.svelte (3)

20-20: Verify new bottom margin against design
Switching mb-[4dvh] aligns with dynamic spacing, but please confirm this exact value matches the design spec and doesn’t introduce too much gap on taller viewports.

---

36-36: Approve dynamic top margin
Using mt-[2dvh] here maintains consistency with the rest of your dynamic vertical spacing. This looks good, assuming it matches the rest of your spacing scale.

---

46-46: Approve drawer action spacing
The my-[2.3dvh] on the drawer button container is consistent with your dynamic unit usage. Looks good if it matches the intended spacing scale.

[coderabbitai]

💡 Verification agent

❓ Verification inconclusive

Add fallback for dvh units
Using 100dvh improves mobile resizing, but not all browsers support dynamic viewport units yet. Consider adding a vh fallback or a @supports rule. For example, via Tailwind you might write a custom CSS block:

.main {
  height: 100vh;
  height: 100dvh;
}

---

Add a vh fallback for dynamic viewport units
Some browsers don’t yet support dvh, so it’s safest to fall back to vh first and then override with dvh.

• File: infrastructure/eid-wallet/src/routes/(auth)/onboarding/+page.svelte
Line 19

Suggested change:

- <main class="h-[100dvh] pt-[3dvh] px-[5vw] pb-[4.5dvh] bg-red-300">
+ <main class="h-[100vh] h-[100dvh] pt-[3dvh] px-[5vw] pb-[4.5dvh] bg-red-300">

Alternatively, you can use a feature query in your global CSS (or Tailwind @layer utilities):

.main {
  height: 100vh;
}
@supports (height: 100dvh) {
  .main {
    height: 100dvh;
  }
}

[JulienAuvo]

lgtm

(honestly I thought "lgtm" meant "legitimate")