feat: Context-Menu #156
Merged
feat: Context-Menu #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
requested a review
from 
|
""" WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ActionMenu (Svelte)
User->>ActionMenu (Svelte): Passes options array with {name, handler}
ActionMenu (Svelte)->>User: Renders menu with options
User->>ActionMenu (Svelte): Clicks menu item
ActionMenu (Svelte)->>User: Calls handler function for clicked option
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
platforms/metagram/src/lib/fragments/ContextMenu/ContextMenu.stories.ts (1)
1-22: LGTM! Well-structured Storybook story.The story is well-organized and demonstrates the component's functionality with practical examples. Consider adding more variations to showcase different use cases (e.g., different number of options, styling variants).
platforms/metagram/src/lib/fragments/ContextMenu/ContextMenu.svelte (3)
5-7: Fix typo in interface name.There's a typo in the interface name:
IContexMenuPropsshould beIContextMenuProps.-interface IContexMenuProps extends HTMLAttributes<HTMLElement> { +interface IContextMenuProps extends HTMLAttributes<HTMLElement> { options: Array<{ name: string; handler: () => void }>; }
9-9: Update interface reference after renaming.After fixing the interface name, update this line to reference the corrected interface name.
-let { options = [], ...restProps }: IContexMenuProps = $props(); +let { options = [], ...restProps }: IContextMenuProps = $props();
1-23: Consider adding keyboard navigation and position management.The context menu currently lacks keyboard navigation and position management logic, which are common requirements for context menus.
Consider enhancing the component with:
- Keyboard navigation between menu items
- Auto-positioning relative to a trigger element or coordinates
- Auto-focus on open
- Close on Escape key or click outside
These features would greatly improve the usability of the component. You might want to use a library like
@floating-ui/domfor the positioning logic or implement a custom solution with event listeners for keyboard navigation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (9)
platforms/metagram/src/lib/fragments/ContextMenu/ContextMenu.stories.ts(1 hunks)platforms/metagram/src/lib/fragments/ContextMenu/ContextMenu.svelte(1 hunks)platforms/metagram/src/lib/fragments/Drawer/Drawer.stories.snippet.svelte(1 hunks)platforms/metagram/src/lib/fragments/Drawer/Drawer.stories.ts(1 hunks)platforms/metagram/src/lib/fragments/Drawer/Drawer.svelte(3 hunks)platforms/metagram/src/lib/fragments/Header/Header.stories.ts(1 hunks)platforms/metagram/src/lib/fragments/Message/Message.stories.ts(1 hunks)platforms/metagram/src/lib/fragments/index.ts(1 hunks)platforms/metagram/src/lib/ui/index.ts(1 hunks)
🔇 Additional comments (19)
platforms/metagram/src/lib/fragments/Header/Header.stories.ts (7)
1-2: Stylistic consistency in imports
Quotes converted to single quotes and indentation normalized; no change in import semantics.
5-12: Stylistic update for default export object
Storybook default export re-indented and quote style standardized, preserving original behavior.
14-20: Stylistic update: Primary story definition
Formatting adjusted (quotes, indentation) with no logic alteration.
22-27: Stylistic update: PrimaryWithNoFlash story definition
Line breaks and quotes standardized; behavior remains identical.
29-34: Stylistic update: Secondary story definition
Indentation and quote style updated; no change to functionality.
36-42: Stylistic update: SecondaryWithMenu story definition
Reformatted for consistency; logic unchanged.
44-50: Stylistic update: Tertiary story definition
Quotes and whitespace normalized; functional semantics preserved.platforms/metagram/src/lib/fragments/Message/Message.stories.ts (4)
1-2: Stylistic consistency in imports
Converted to single quotes and tab indentation; behavior unaffected.
5-11: Stylistic update for default export object
Formatting changes only (quotes, indentation); no impact on logic.
14-22: Stylistic update: Primary story definition
Quote style and indent normalized; functionality remains the same.
24-32: Stylistic update: Unread story definition
Only formatting changed (quotes, whitespace); no change in behavior.platforms/metagram/src/lib/fragments/Drawer/Drawer.stories.snippet.svelte (2)
2-3: Stylistic adjustment: export statement formatting
Spacing updated around export; no change to module exports.
5-84: Stylistic adjustment: snippet block indentation
Multiline snippet content re-indented for readability; snippet logic is unchanged.platforms/metagram/src/lib/ui/index.ts (1)
1-7: Stylistic normalization of exports
All export paths now use single quotes and consistent indentation; exported API is unchanged.platforms/metagram/src/lib/fragments/Drawer/Drawer.stories.ts (1)
17-18: Formatting adjustment in story args
Indentation and whitespace updated forchildren: DrawerContent; behavior remains identical.platforms/metagram/src/lib/fragments/index.ts (1)
8-8: LGTM! The ContextMenu component is properly exported.The export of the new ContextMenu component follows the established pattern and maintains consistency with other component exports.
platforms/metagram/src/lib/fragments/Drawer/Drawer.svelte (3)
7-7: LGTM! Improved import formatting.The import statement for SwipeCustomEvent has been properly formatted.
30-36: LGTM! Enhanced code formatting.The handleDrawerSwipe function has been reformatted with consistent indentation, improving readability while maintaining the same functionality.
73-73: LGTM! Consistent indentation.The indentation in the template section has been adjusted for consistency.
platforms/metagram/src/lib/fragments/ContextMenu/ContextMenu.svelte
Outdated
Show resolved
Hide resolved
sosweetham
requested changes
May 21, 2025
There was a problem hiding this comment.
https://svelte.dev/playground/6fb90919e24942b2b47d9ad154386b0c?version=3.49.0
refactor this from "context menu" to "actions menu" and also update the issue, also add the positioning logic from the reference above so that we dont have to do that manually everytime on the pages
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte (4)
5-7: Fix typo in interface name.The interface name
IContexMenuPropshas a typo - it should beIContextMenuProps(missing "t").-interface IContexMenuProps extends HTMLAttributes<HTMLElement> { +interface IContextMenuProps extends HTMLAttributes<HTMLElement> { options: Array<{ name: string; handler: () => void }>; }
11-11: Consider theme compatibility in base styling.The hardcoded
bg-whiteclass might not work well in dark mode themes.Consider using theme-compatible classes or making the background color configurable:
-const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-white'; +const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-surface';Or make it configurable with a prop:
+let { options = [], bgColor = 'bg-white', ...restProps }: IContextMenuProps & { bgColor?: string } = $props(); -const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-white'; +const cBase = `w-[max-content] py-2 px-5 rounded-2xl ${bgColor}`;
9-10: Enhance component with additional features.This component could benefit from additional functionality common in context menus.
Consider adding support for:
- Disabled options
- Dividers between items
- Icons or additional visual elements
- Nested submenus
- Keyboard navigation between items
Example of enhanced options interface:
interface MenuOption { name: string; handler: () => void; disabled?: boolean; icon?: string; divider?: boolean; subItems?: MenuOption[]; } interface IContextMenuProps extends HTMLAttributes<HTMLElement> { options: Array<MenuOption>; }
18-20: Add visual feedback for interactive items.Menu items should provide visual feedback when hovered or focused.
Add hover and focus states to improve user experience:
-<li class="py-3" onclick={option.handler}> +<li class="py-3 hover:bg-gray-100 focus-within:bg-gray-100 cursor-pointer" onclick={option.handler}>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (3)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.stories.ts(1 hunks)platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte(1 hunks)platforms/metagram/src/lib/fragments/index.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.stories.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- platforms/metagram/src/lib/fragments/index.ts
🔇 Additional comments (1)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte (1)
1-22: Overall implementation is clean and well-structured.The component follows good Svelte practices with clean separation of script and markup. The TypeScript typing is properly implemented, and the component is designed to be flexible with the spread of additional props.
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte
Outdated
Show resolved
Hide resolved
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte (2)
57-66: 🛠️ Refactor suggestionAddress accessibility issues instead of ignoring them.
The menu items are non-interactive elements with click handlers, and accessibility warnings are being ignored. This makes the menu inaccessible to keyboard users.
<ul use:clickOutside={() => closeMenu()} bind:this={menuEl} {...restProps} class={cBase}> {#each options as option} - <!-- svelte-ignore a11y_click_events_have_key_events --> - <!-- svelte-ignore a11y_no_noninteractive_element_interactions --> - <li class="py-3" onclick={() => { option.handler(); closeMenu(); }}> - <p class="text-black-800">{option.name}</p> + <li class="py-3"> + <button + class="w-full text-left bg-transparent border-0 p-0" + on:click={() => { option.handler(); closeMenu(); }} + on:keydown={(e) => e.key === 'Enter' && (option.handler(), closeMenu())}> + <span class="text-black-800">{option.name}</span> + </button> </li> {/each} </ul>
13-48: 🛠️ Refactor suggestionImplement proper focus management.
The context menu lacks focus management, which is important for both accessibility and usability.
Add focus management to the menu component:
let showActionMenu = $state(false); let menuEl: HTMLUListElement | null = $state(null); +let menuItems: HTMLButtonElement[] = $state([]); +let activeIndex = $state(-1); let mouseX = 0; let mouseY = 0; function openMenu(event: MouseEvent) { mouseX = event.clientX; mouseY = event.clientY; showActionMenu = true; tick().then(() => { if (menuEl) { // Position menu code... + // Focus first menu item + if (menuItems.length > 0) { + activeIndex = 0; + menuItems[0].focus(); + } } }); } function closeMenu() { showActionMenu = false; + activeIndex = -1; } +function handleKeyNavigation(event: KeyboardEvent) { + if (!showActionMenu) return; + + switch (event.key) { + case 'ArrowDown': + event.preventDefault(); + activeIndex = Math.min(activeIndex + 1, menuItems.length - 1); + menuItems[activeIndex].focus(); + break; + case 'ArrowUp': + event.preventDefault(); + activeIndex = Math.max(activeIndex - 1, 0); + menuItems[activeIndex].focus(); + break; + case 'Escape': + closeMenu(); + break; + } +}Then modify the template:
{#if showActionMenu} -<ul use:clickOutside={() => closeMenu()} bind:this={menuEl} {...restProps} class={cBase}> +<ul + use:clickOutside={() => closeMenu()} + bind:this={menuEl} + {...restProps} + class={cBase} + on:keydown={handleKeyNavigation} + role="menu" +> {#each options as option, i} <li class="py-3"> <button class="w-full text-left bg-transparent border-0 p-0" on:click={() => { option.handler(); closeMenu(); }} on:keydown={(e) => e.key === 'Enter' && (option.handler(), closeMenu())} + bind:this={menuItems[i]} + role="menuitem" + tabindex={activeIndex === i ? 0 : -1}> <span class="text-black-800">{option.name}</span> </button> </li> {/each} </ul> {/if}
🧹 Nitpick comments (4)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte (4)
8-10: Typo in interface name and inconsistent naming.The interface is named
IContexMenuProps(missing "t" in "Context") while the component is namedActionMenu. Consistent naming would improve maintainability.-interface IContexMenuProps extends HTMLAttributes<HTMLElement> { +interface IActionMenuProps extends HTMLAttributes<HTMLElement> {
8-12: Enhance the options interface for better flexibility.The current options interface is limited to just name and handler. Consider extending it to support icons, disabled state, dividers, and submenus.
interface IContexMenuProps extends HTMLAttributes<HTMLElement> { - options: Array<{ name: string; handler: () => void }>; + options: Array<{ + name: string; + handler: () => void; + icon?: any; // Component type for your icon system + disabled?: boolean; + divider?: boolean; + }>; }
49-49: Consider using CSS variables or a design system for consistent styling.The hardcoded CSS classes could be replaced with variables from your design system for better maintainability and consistency.
-const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-white'; +// Import from design system or define as CSS variables +const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-white shadow-md';
1-68: Add hover and focus styles for menu items.The current implementation lacks visual feedback for hover and focus states, which is important for usability.
Add hover and focus styles to the menu items:
<script> // Existing code... -const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-white'; +const cBase = 'w-[max-content] py-2 px-5 rounded-2xl bg-white shadow-md'; +const cMenuItem = 'w-full text-left bg-transparent border-0 p-0 hover:bg-gray-100 focus:bg-gray-100 focus:outline-none rounded px-2 transition-colors'; </script> // Then in your template: <li class="py-3"> <button - class="w-full text-left bg-transparent border-0 p-0" + class={cMenuItem} on:click={() => { option.handler(); closeMenu(); }} on:keydown={(e) => e.key === 'Enter' && (option.handler(), closeMenu())}> <span class="text-black-800">{option.name}</span> </button> </li>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte(1 hunks)
platforms/metagram/src/lib/fragments/ActionMenu/ActionMenu.svelte
Outdated
Show resolved
Hide resolved
sosweetham
approved these changes
May 22, 2025
Bekiboo
approved these changes
May 22, 2025
JulienAuvo
approved these changes
May 22, 2025
coodos
pushed a commit
that referenced
this pull request
Jul 7, 2025
* feat: Context-Menu * fix: name of component * fix: as per suggestion * fix: action menu position * fix: class
coodos
added a commit
that referenced
this pull request
Jul 7, 2025
* initial commit * chore: add w3id readme (#3) * chore: add w3id readme * chore: bold text * chore: better formatting * docs: add w3id details * chore: format * chore: add links * fix: id spec considerations addressal (#8) * fix: id spec considerations addressal * fix: identity -> indentifier * chore: expand on trust list based recovery * chore: expand on AKA --------- Co-authored-by: Merul Dhiman <[email protected]> * Docs/eid wallet (#10) * chore: add eid-wallet folder * chore: add eid wallet docs * feat: add (#9) * feat(w3id): basic setup (#11) * feat(w3id): basic setup * fix(root): add infrastructure workspaces * update: lock file * feat(eidw): setup tauri (#40) * Feat/setup daisyui (#46) * feat: setup-daisyui * fix: index file * feat: colors added * feat: Archivo font added * fix: postcss added * fix: +layout.svelte file added * fix: packages * fix: fully migrating to tailwind v4 * feat: add Archivo font * feat: add danger colors * feat: twmerge and clsx added * feat: shadcn function added --------- Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> * feat: add storybook (#45) * feat: add storybook * update: lockfile * feat: created connection button (#48) * created connection button * added restprops to parent class * added onClick btn and storybook * fix: make font work in storybook (#54) * Feat/header (#55) * feat: add icons lib * fix: make font work in storybook * feat: Header * feat: runtime global added, icon library created, icons added, type file added * feat: header props added * fix: remove icons and type file as we are using lib for icons * fix: heading style * fix: color and icons, git merge branch 51, 54 * fix: color * fix: header-styling * fix: classes * chore: handlers added * chore: handlers added * fix: added heading --------- Co-authored-by: Soham Jaiswal <[email protected]> * Alternative w3id diagram (#52) * Feat/cupertino pane (#49) * feat: Drawer * feat: Drawer and added a function for clickoutside in utils * fix: classes * fix: drawer button position * fix: style and clickoutside * fix: pane height * fix: border-radius * fix: drawer as bulletin * fix: styling * fix: component with inbuilt features * fix: remove redundant code * fix: remove redundant code * fix: cancel button * fix: css in storybook * fix: position * fix: height of pane * fix: remove redundant code * feat: add button action component (#47) * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * chore: add documentation * fix: configure Storybook * chore: storybook gunk removal * feat: enhance ButtonAction component with type prop and better error handling --------- Co-authored-by: JulienAuvo <[email protected]> * Feat/splash screen (#63) * feat: SplashScreen * fix: remove redundant code * fix: as per given suggestion * fix: font-size * fix: logo * feat: input-pin (#56) * feat: input-pin * fix: styling as per our design * fix: added small variant * fix: hide pin on select * fix: gap between pins * fix: color of focus state * fix: removed legacy code and also fix some css to tailwind css * fix: css * fix: optional props * feat: added color variants * Feat/improve button component (#60) * feat: add white variant * feat: add small variant * chore: update doc and story for button * chore: rename cb into callback * update: improve small size * update: modify loading style * fix: return getAbsolutePath function to storybook (#58) Co-authored-by: Bekiboo <[email protected]> * feat: add selector component (#59) * feat: add selector component * feat: improve selector + add flag-icon lib * feat: improve selector + doc * feat: add utility function to get language with country name * feat: test page for language selectors * chore: add Selector Story * chore: clean test page * fix: types * fix: normalize custom tailwind colors (#71) * feat: workflows (#64) * feat: workflows * fix: node version * fix: use pnpm 10 * fix: check message * Fix/codebase linting (#73) * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Code / lint * fix: Check Format / lint * fix: unknown property warning * fix: unknown property warning * chore: improve args type * settings nav button :) (#75) * setting bav button all done :) * lint fixski * added component to index.ts * Feat/#32 identity card fragment (#74) * identity card * identity card * lint fixski * lint fixski * lint fixski * fixed the font weight * added component to index.ts * changed span to buttton * feat: add icon button component (#68) * feat: add icon button component * feat: finish up buttonIcon + stories * fix: update with new color naming * feat: polish button icon (and button action too) * chore: format lint * chore: sort imports * chore: format, not sure why * Feat/onboarding flow (#67) * feat: onboarding-page * fix: line height and added handlers * fix: button variant * fix: text-decoration * fix: subtext * fix: underline * fix: padding and button spacing * fix: according to design update * feat: Drawer * feat: verify-pae * fix: verify-page styling * feat: drawer for both confirm pin and add bio metrics added * feat: modal added in fragments * fix: icons and flow * feat: Identifier Card * fix: copy to clipboard * feat: e-passport page * fix: error state * fix: colors * fix: lint error * fix: lint * feat: Typography * fix: typograpy * fix: as per given suggestion * fix: font-sizing * fix: identity card implementation * fix: spacing * fix: padding * fix: padding and spacing * fix: splashscreen * fix: error state * fix: styling to avoid * fix:typo * Fix/remove daisyui (#82) * refactoring: remove DaisyUI + refactor some tailwind classes and logic * refactoring: remove DaisyUI + refactor some tailwind classes and logic * feat: add Button.Nav (#77) * feat: add Button.Nav * chore: format * chore: sort imports * update: remove unused snippet and add missing props * feat: stick to fragment definition * update: documentation * fix: stories * chore: sort imports * Feat/splashscreen animation (#81) * feat: add animation to splashScreen * feat: implement data loading logic with splash screen delay * chore: sort import * update: use ButtonIcon is IdentityCard (#78) * update: use ButtonIcon is IdentityCard * feat: refactor ButtonIcon to be used anywhere in the app * chore: format indent * chore: remove useless change * feat: setup safe area (#80) * feat: setup safe area * chore: simplify implementation * chore: format * Feat/uuidv5 generation (#61) * feat: setup uuidv5 * chore: add test for deterministic UUID * feat: add Hero fragment (#88) * feat: add Hero fragment * chore: sort imports + add doc * feat: add storage specification abstract class (#92) * feat: add storage specification abstract class * chore: format and ignore lint * chore: change format checker on w3id * feat: settings-flow (#86) * feat: settings-flow * feat: settings and language page * feat : history page * feat: change pin page * fix: height of selector * fix: pin change page * fix: size of input pin * fix: spacing of pins * feat: AppNav fragment * fix: height of page * fix: padding * fix: remove redundant code * feat: privacy page * chore: add doc * fix: error state * feat: remove redundant code * chore: used app nav component --------- Co-authored-by: JulienAuvo <[email protected]> * feat: AppNav fragment (#90) * feat: AppNav fragment * chore: add doc * feat: Main page flow (#93) * feat: create root page + layout * feat: complete main page flow beta * chore: fix ts block * chore: sort imports * feat: integrate-flows (#94) * feat: intigrate-flows * fix: spacing in e-passport page * fix: page connectivity * feat: app page transitions * fix: z index * fix: pages * fix: view transition effect on splashscreen * fix: drawer pill and cancel button removed * fix: share button removed when onboarding * fix: remove share and view button when on onboarding flow * fix: remove view button * fix: ci checks * fix: transitions * fix: transititon according to direction * fix: lint error * fix: loop holes * Feat/w3id log generation (#98) * chore: create basic log generation mechanism * chore: add hashing utility function * chore: rotation event * feat: genesis entry * feat: generalize hash function * feat: append entry * chore: basic tests * chore: add tests for rotation * feat: add malform throws * chore: add the right errors * chore: fix CI stuff * chore: add missing file * chore: fix event type enum * chore: format * feat: add proper error * chore: format * chore: remove eventtypes enum * chore: add new error for bad options * chore: add options tests * feat: add codec tests * fix: err handling && jsdoc * fix: run format * fix: remove unused import * fix: improve default error messages * fix: move redundant logic to function * fix: run format * fix: type shadow * fix: useless conversion/cast * fix: run format --------- Co-authored-by: Soham Jaiswal <[email protected]> * Feat/core id creation logic (#99) * feat: create w3id builder * fix: w3id builder * feat: add global config var for w3id * chore: add docs * chore: change rand to crng * chore: add ts type again * chore: fix lint and format * chore: add w3id tests github workflow * Feat/evault core (#100) * feat: migrate neo4j * chore: envelope logic works * chore: envelope logic works * feat: parsed envelopes search * feat: generics * feat: protocol * feat: jwt sigs in w3id * chore: stuff works * chore: tests for evault core * chore: format * chore: fix test * Feat/docker compose and docs (#101) * chore: stash dockerfile progress * fix: getEnvelopesByOntology thing * chore: fix tests * Update infrastructure/evault-core/src/protocol/vault-access-guard.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: remove unused import * chore: remove package * chore: fix pnpm lock * chore: fix workflow * chore: fix port in dockerfile --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Feat/registry and evault provisioning (#106) * feat: evault provisioning * chore: fianlly fixed provisioner * feat: add logic for metadata in consul * feat: registry * chore: format * Feat/watchers logs (#114) * feat: alloc according to entropy and namespace * chore: move exports * chore: docs * feat: `whois` endpoint * feat: watcher endpoints * chore: fix format and lint * chore: fix tests * feat: web3 adapter (#115) * feat: tauri plugins setup (#97) * feat: tauri plugins setup * fix: add editorconfig * fix: add missing biome json * fix: run formatter * feat: biometry homework * feat: add pin set logic * feat: add biometric enabling logic * fix: sec controller qol * feat: stub user controller * fix: run format && lint * fix: sort imports * fix: import statement sort * feat: user controller * feat: pin flow * feat: biometrics unavailable * fix: pin input not working * feat: make checks pass * fix: scan works * fix: actions * feat: format on save * fix: coderabbit suggestions * chore: run format lint check * fix: scan on decline too * feat: documentation links (#117) * feat: bad namespace test (#116) * fix: layouts (#119) * fix: layouts * fix: Onboarding page scroll fixed * fix: page layout and prevent from scroll in all devices * fix: pages layout * chore: try to fix emulator * fix: units * fix: safezones for ios * fix: styling --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat: setup-metagram (#121) * feat: setup-metagram * chore: tailwind css worked * feat: fonts added * feat: typography * fix: removed stories and fixed setup for icons lib * feat: icons and story file * fix: type of args in story * fix: lint errors * feat: colors added * feat: Button * fix: format and lint * fix: colors * fix: spinner * fix: code rebbit suggestions * fix: code rebbit suggestions * fix: paraglide removed * fix: lock file * feat: added user avatar. (#130) * feat: Button (#129) * feat: Button * fix: colors of variants * feat: Input (#131) * feat: Input * feat: styling added * fix: styling * fix: styling * fix: added a new story * fix: focus states * fix: input states * Feat/settings navigation button (#140) * feat: settings-navigation-button * fix: handler added * chore: another variant added * fix: as per given suggestion * feat: BottomNav (#132) * feat: BottomNav * fix: icons * feat: profile icons created * feat: handler added * feat: handler added * fix: correct tags * fix: as per given suggestion, bottomnav moved to fragments and also implemented on page * fix: handler * chore: routes added * feat: app transitions added * fix: direction of transition * fix: transition css * fix: directionable transition * fix: used button instead of label, and used page from state * feat: added post fragment. (#137) * feat: FileInput (#150) * feat: FileInput * fix: added icon * feat: cancel upload * fix: remove redundant code * fix: usage docs added and as per requirements ' * fix: moved to framents * feat: Toggle Switch (#143) * feat: Toggle Switch * feat: Toggle Switch * fix: as per our design * fix: as per our design * feat: Label (#146) * feat: Select (#148) * feat: Select * fix: as per our design * fix: code format and as per svelte 5 * fix: font-size * fix: font-size * fix: icon * feat: message-input (#144) * feat: message-input * fix: classes merge and a files as a prop * feat: variant added * feat: icon replaced * fix: as per code rabbit suggestions * fix: icon * fix: input file button * fix: as per suggestion * fix: classes * fix: no need of error and disabled classes * fix: input * feat: invalid inputs * feat: add number input storybook --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat:Drawer (#152) * feat:Drawer * feat: Drawer with clickoutside * fix: settings * Feat/metagram header (#133) * feat: added metagram header primary linear gradient. * feat: added flash icon. * feat: added secondary state of header. * feat: added secondary state of header with menu. * chore: cleaned some code. * docs: updated component docs. --------- Co-authored-by: SoSweetHam <[email protected]> * Feat/metagram message (#135) * feat: added metagram message component. * feat: added both states of message component. * docs: added usage docs. * chore: exposed component from ui. * fix: component -> fragement --------- Co-authored-by: SoSweetHam <[email protected]> * feat: modal (#154) * fix: styling of modal * fix: modal props * fix: conflicting styles * fix: styles of drawer * fix: hide scrollbar in drawer * fix: padding * fix: used native method for dismissing of drawer * feat: Context-Menu (#156) * feat: Context-Menu * fix: name of component * fix: as per suggestion * fix: action menu position * fix: class * feat: responsive-setup (#157) * feat: responsive-setup * fix: background color * fix: added font fmaily * feat: responsive setup for mobile and desktop (#159) * feat: responsive setup for mobile and desktop * fix: width of sidebar and rightaside * fix: responsive layout * feat: SideBar * fix: added some finishing touches to sidebar and button * fix: prevent pages transition on desktop * fix: icon center * feat: settings page and icon added * feat/layout-enhancement (#168) * feat/infinite-scroll (#170) * feat/infinite-scroll * fix: aspect ratio of post * fix: bottom nav background * settings page (#169) * settings page layout done * settings page layout done * formt fix * format fix * format fix * routing for settings page fixed * settings page buttons * merge conflict * settings page tertiary pages * settings pages all done * settings pages unnecessary page deleted * requested changes done * requested changes done * Feat/comments pane (#171) * feat/comments-pane * fix: overflow and drawer swipe * feat: Comment fragment * fix: comments added * fix: comment fragment * feat: Comments reply * fix: message input position * fix: post type shifted to types file * fix: one level deep only * fix: drawer should only be render on mobile * fix: comments on layout page * fix: format * feat: messages (#174) * feat: messages * feat: ChatMessae * feat: messages by id * fix: messages page * fix: icon name * fix: hide bottom nav for chat * fix: header * fix: message bubble * fix: message bubble * fix: message bubble * fix: as per suggestion * fix: messaging * chore: change from nomad to k8s (#179) * chore: change from nomad to k8s * Update infrastructure/eid-wallet/src/routes/+layout.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: uri extraction * feat: regitry stuff * feat: registry using local db * 📝 Add docstrings to `feat/switch-to-k8s` (#181) Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: format --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: make scan qr page work again (#185) * feat: Discover Page (#180) * refactor/Post (#186) * refactor/Post * fix: format and lint * fix: added dots for gallery * fix: added dots for gallery * fix: added dots for gallery * fix: plural name * feat: splash-screen (#187) * Feat/evault provisioning via phone (#188) * feat: eid wallet basic ui for verification * chore: evault provisioning * feat: working wallet with provisioning * feat: restrict people on dupes * 📝 Add docstrings to `feat/evault-provisioning-via-phone` (#189) Docstrings generation was requested by @coodos. * #188 (comment) The following files were modified: * `infrastructure/eid-wallet/src/lib/utils/capitalize.ts` * `infrastructure/evault-provisioner/src/utils/hmac.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: added uploaded post view component. (#182) * feat: added uploaded post view component. * fix: fixed the outline and color. * fix: moved function to external definition. * fix: fixed the restProps. * profile page (#178) * basic layout for profile page * fixed alt text * merge conflict * profile page for other users implemented * fix: profile pages and logics * fixed all the pages of profile * fixed all the pages of profile * fix: format --------- Co-authored-by: gourav <[email protected]> * Feat/radio input (#176) * feat: added a radio button custom * docs: added name option in docs. * chore: cleaned the unnecessary classes and variables for input type radio. * fix: moved input radio to its own component. * fix: keydown events added. * feat: added settings tile component. (#184) * feat: added settings tile component. * chore: fixed the naming convention * chore: renamed callback to onclick * fix: fixed the use of restProps * fix: fixed the unnecessary onclick expose. * fix: fixed the join function params. * Feat/textarea (#194) * chore: removed redundant radio * feat: added textarea. * fix: tabindex * fix: removed type inconsitency. * Feat/mobile upload flow (#193) * fix: header logic in secondary * fix: fixed the text in header in post * feat: trying some hack to get file image input. * feat: added image input on clicking the post bottom nav * chore: got rid of non-required code. * feat: added the logic to get the images from user on clicking post tab. * feat: added store. * feat: added correct conversion of files. * feat: added the correct display of image when uploading. * feat: added settings tile to the post page and fixed the settingsTile component type of currentStatus * feat: added hte correct header for the audience page. * fix: fixed the page transition not happening to audience page. * feat: added audience setting * feat: added store to audience. * chore: removed console log * feat: added post button. * feat: correct button placement * fix: horizontal scroll * fix: positioning of the post button. * fix: protecting post route when no image is selected. * fix: improved type saftey * feat: added memory helper function * feat: added memory cleanup. * Feat/social media platforms (#195) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * Feat/social media platforms (#196) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * chore: add other socials * Feat/blabsy add clone (#198) * chore: clone twitter * feat: custom auth with firebase using w3ds * chore: add chat * feat: chat works with sync * feat: twittex * feat: global schemas * feat: blabsy adapter * refactor: shift some text messages to work on blabsy (#199) * chore: stash progress * chore: stash adapters * chore: stash working extractor * feat: adapter working properly for translating to global with globalIDs * feat: adapter toGlobal pristine * chore: stash * feat: adapter working * chore: stash until global translation from pictique * feat: bi-directional sync prestino * feat: bidir adapters * chore: login redir * chore: swap out for sqlite3 * chore: swap out for sqlite3 * chore: server conf * feat: messages one way * feat: ready to deploy * feat: ready to deploy * chore: auth thing pictique * chore: set adapter to node * chore: fix auth token thingy * chore: auth thing * chore: fix auth token thingy * chore: port for blabsy * feat: provision stuff * feat: provision * feat: provision * feat: provision * chore: fix sync * feat: temporary id thing * chore: android * chore: fix mapper sync * chore: fallback * feat: add error handling on stores * feat: fix issue with posts * chore: fix retry loop * Fix/author details (#229) * fix: author-details * fix: owner-details * fix: author avatar * fix: auth user avatar * fix: error handling * fix: author image in bottom nav --------- Co-authored-by: Merul Dhiman <[email protected]> * Fix/change name (#228) * fix: corrected the name to blabsy * fix: extra shit comming. * fix: fixed the alignment of the display in more to look more like current twitter. * fix: avatars (#226) * fix: avatars * fix: avatar in follow request page * fix: images uploaded shown in user profile * fix: button size * fix: avatar --------- Co-authored-by: Merul Dhiman <[email protected]> * chore: temp fix sync * chore: stash progress * Fix/post context menu (#231) * fix: post-context-menu * fix: user id with post * fix: removed redundant code * fix: images * fix: profile data * fix: profile data * fix: image cover * fix: logout * Fix/wallet text (#234) * changed text as per the request and fixed styling on pages with useless scroll * added settings button in main page which went missing somehow * fix: consistent padding * chore: change tags * feat: change icon * feat: webhook dynamic registry * feat: make camera permission work properlyh * chore: removed all locking mechanism thing from platforms * feat: synchronization works perfectly * feat: fixed everything up * feat: changes * chore: stats fix * chore: fix pictique visual issues * chore: fix cosmetic name issue * feat: fix sync issue * chore: fix logical issue here * chore: add qrcode ename * feat: add packages (#235) * feat: add packages * feat: add sample funcs + docs * fixed the filled color on like icon for liked post (#239) * feat: fake passport name * feat: double confirmation * chore: fix pictique login issue * fix: make no user case redir to login * fix: issues with wallet --------- Co-authored-by: Soham Jaiswal <[email protected]> Co-authored-by: SoSweetHam <[email protected]> Co-authored-by: Gourav Saini <[email protected]> Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Julien Connault <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Sahil Garg <[email protected]> Co-authored-by: Sahil Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Built a Context Menu
Issue Number
closes #155
Type of change
How the change has been tested
CI and Manual
Change checklist
Summary by CodeRabbit
New Features
Documentation