Skip to content

feat: responsive-setup #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

feat: responsive-setup #157

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15b655b
feat: responsive-setup
grv-saini-20 May 21, 2025
7c15672
Merge branch 'main' into feat/responsive-setup
grv-saini-20 May 22, 2025
5567e90
fix: background color
grv-saini-20 May 22, 2025
81691c4
fix: added font fmaily
grv-saini-20 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions platforms/metagram/src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
src: url('/fonts/Geist-VariableFont_wght.ttf') format('truetype');
}

body {
padding-top: env(safe-area-inset-top);
padding-bottom: env(safe-area-inset-bottom);
padding-left: env(safe-area-inset-left);
padding-right: env(safe-area-inset-right);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve safe-area padding with fallbacks and shorthand

To ensure broader browser support (including legacy iOS Safari) and simplify maintenance, add constant() fallbacks and consolidate the four individual declarations into a single shorthand with default values. Also align indentation with the project’s tab style. For example:

 body {
-       padding-top: env(safe-area-inset-top);
-       padding-bottom: env(safe-area-inset-bottom);
-       padding-left: env(safe-area-inset-left);
-       padding-right: env(safe-area-inset-right);
+       /* Legacy WebKit support */
+       padding-top: constant(safe-area-inset-top);
+       padding-right: constant(safe-area-inset-right);
+       padding-bottom: constant(safe-area-inset-bottom);
+       padding-left: constant(safe-area-inset-left);
+       /* Standard with fallbacks (0px) */
+       padding: env(safe-area-inset-top, 0px)
+               env(safe-area-inset-right, 0px)
+               env(safe-area-inset-bottom, 0px)
+               env(safe-area-inset-left, 0px);
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
body {
padding-top: env(safe-area-inset-top);
padding-bottom: env(safe-area-inset-bottom);
padding-left: env(safe-area-inset-left);
padding-right: env(safe-area-inset-right);
}
body {
/* Legacy WebKit support */
padding-top: constant(safe-area-inset-top);
padding-right: constant(safe-area-inset-right);
padding-bottom: constant(safe-area-inset-bottom);
padding-left: constant(safe-area-inset-left);
/* Standard with fallbacks (0px) */
padding: env(safe-area-inset-top, 0px)
env(safe-area-inset-right, 0px)
env(safe-area-inset-bottom, 0px)
env(safe-area-inset-left, 0px);
}
🤖 Prompt for AI Agents 
In platforms/metagram/src/app.css around lines 11 to 16, the safe-area padding
uses only env() which lacks fallback support for legacy browsers. Replace the
four separate padding properties with a single padding shorthand that includes
constant() fallbacks for each side and default values. Also, adjust the
indentation to match the project's tab style for consistency.


@layer base {
h1 {
@apply font-geist text-xl/[1] font-semibold;
Expand Down
Loading