feat: responsive setup for mobile and desktop #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
self-assigned this
|
""" WalkthroughThis update revises the responsive layout and styling of several Svelte components and CSS files. It adjusts grid and sidebar visibility for different screen sizes, modifies navigation bar breakpoints, updates padding and height utility classes, and simplifies the home page to a static main section. Additionally, a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AppLayout as +layout.svelte
participant ProtectedLayout as (protected)/+layout.svelte
participant BottomNav
participant SidebarLeft
participant SidebarRight
participant MainContent
User->>AppLayout: Load app
AppLayout->>ProtectedLayout: Render protected routes
ProtectedLayout->>SidebarLeft: Show (md and up)
ProtectedLayout->>MainContent: Show main content
ProtectedLayout->>SidebarRight: Show (md and up, except /messages route)
ProtectedLayout->>BottomNav: Show (hidden md and below)
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
platforms/metagram/src/routes/(protected)/home/+page.svelte (1)
4-4: Clarify or remove the placeholder content
The<main>Main</main>element is currently a bare placeholder. If this is intentional, please add a TODO or comment to indicate the planned content. Also, since the<script lang="ts">block is empty, consider removing it to reduce noise.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
platforms/metagram/src/app.css(1 hunks)platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte(1 hunks)platforms/metagram/src/routes/(protected)/+layout.svelte(1 hunks)platforms/metagram/src/routes/(protected)/home/+page.svelte(1 hunks)platforms/metagram/src/routes/+layout.svelte(1 hunks)
🔇 Additional comments (4)
platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (1)
43-43: Appropriate breakpoint adjustment for responsive design.The change from
sm:hiddentomd:hiddenaligns with the new layout structure that introduces sidebars on medium screens and larger, ensuring the bottom navigation remains visible on mobile while disappearing on desktop.platforms/metagram/src/routes/+layout.svelte (1)
36-36: Good use of responsive height and padding.Using
h-[100dvh]ensures proper viewport height across devices while the responsive padding (px-4 md:px-0) appropriately adds spacing on mobile views and removes it on desktop where the new grid layout takes over.platforms/metagram/src/app.css (1)
14-16: Consistent indentation formatting.The indentation has been standardized to use tabs, maintaining consistent code style without changing any functionality.
platforms/metagram/src/routes/(protected)/+layout.svelte (1)
6-6: Well-structured responsive grid layout.The grid setup with
grid-cols-[20%_auto_20%] md:gridcreates an appropriate three-column layout for desktop views while maintaining a single column on mobile. The use ofh-[100dvh]ensures consistent height across devices.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
platforms/metagram/src/routes/(protected)/+layout.svelte (1)
10-10: Replace development placeholders with production content.The placeholder text "Sidebar" and "Right Aside" should be replaced with actual content or components before production deployment. This addresses the same concern raised in previous reviews.
Replace the placeholder content:
-<aside class="hidden border border-y-0 border-e-gray-200 md:block">Sidebar</aside> +<aside class="hidden border border-y-0 border-e-gray-200 md:block"> + <!-- Add actual sidebar content/component here --> +</aside>-<aside class="hidden border border-y-0 border-s-gray-200 md:block">Right Aside</aside> +<aside class="hidden border border-y-0 border-s-gray-200 md:block"> + <!-- Add actual right aside content/component here --> +</aside>Also applies to: 15-15
🧹 Nitpick comments (1)
platforms/metagram/src/routes/(protected)/+layout.svelte (1)
9-9: Consider adjusting grid column proportions for better responsive design.The grid layout uses fixed viewport width units (
22vw,31vw) which may not provide optimal user experience across all screen sizes. Consider using more flexible units or CSS custom properties for better maintainability.-<main class="block h-[100dvh] grid-cols-[22vw_auto_31vw] md:grid"> +<main class="block h-[100dvh] grid-cols-[280px_1fr_400px] md:grid">Alternatively, define these widths as CSS custom properties for easier theming and maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
platforms/metagram/src/routes/(protected)/+layout.svelte(1 hunks)platforms/metagram/src/routes/(protected)/messages/+page.svelte(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- platforms/metagram/src/routes/(protected)/messages/+page.svelte
🔇 Additional comments (2)
platforms/metagram/src/routes/(protected)/+layout.svelte (2)
2-2: LGTM: Proper Svelte 5 state management.The import of
pagefrom$app/stateand the derived reactive variable for route tracking are correctly implemented using Svelte 5 syntax.Also applies to: 6-6
14-16: LGTM: Conditional rendering logic is well-implemented.The conditional rendering of the right aside based on the route ending with '/messages' is correctly implemented and follows good practices for responsive layout management.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (3)
8-8: Fix interface naming inconsistency.The interface is named
IBottomNavPropsbut this component is aSideBar. The naming should be consistent with the component's purpose.- interface IBottomNavProps extends HTMLAttributes<HTMLElement> { + interface ISideBarProps extends HTMLAttributes<HTMLElement> {- }: IBottomNavProps = $props(); + }: ISideBarProps = $props();
17-17: Remove unused tabs array.The
tabsarray is defined but never used in the component. Consider removing it to avoid dead code.- const tabs = ['home', 'discover', 'post', 'messages', 'profile'];
20-27: Simplify activeTab state management.The current implementation has redundant state updates. The
$effectupdatesactiveTabfrom the URL, buthandleNavClickalso updates it before navigation. This could cause unnecessary reactivity.Consider simplifying by removing the manual activeTab update in
handleNavClicksince the URL change will trigger the effect:const handleNavClick = (newTab: string) => { - activeTab = newTab; goto(`/${newTab}`); };Alternatively, if you want immediate UI feedback, consider debouncing or using a different approach to avoid potential race conditions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
platforms/metagram/src/lib/fragments/SideBar/SideBar.stories.ts(1 hunks)platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte(1 hunks)platforms/metagram/src/lib/fragments/index.ts(1 hunks)platforms/metagram/src/routes/(protected)/+layout.svelte(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- platforms/metagram/src/lib/fragments/index.ts
- platforms/metagram/src/lib/fragments/SideBar/SideBar.stories.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- platforms/metagram/src/routes/(protected)/+layout.svelte
🔇 Additional comments (3)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (3)
30-30: Review accessibility warning suppression.The
svelte-ignore a11y_no_noninteractive_element_to_interactive_roledirective is used. Ensure this is necessary and that the navigation is still accessible.The
<nav>element withrole="tablist"might be causing this warning. Consider ifrole="navigation"would be more appropriate, or if the tablist pattern is intentional for this UI component.
37-37: LGTM: Brand gradient application.Good use of CSS custom properties for the brand gradient on the logo. The text styling creates a nice visual hierarchy.
120-130: LGTM: Profile image with dynamic border.The profile button implementation with conditional border styling provides good visual feedback for the active state. The image handling with proper alt text and sizing is well implemented.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (1)
47-143: 🛠️ Refactor suggestionCode duplication noted in previous review still applies.
The repeated navigation button pattern identified in the previous review comment remains unaddressed. Each navigation button follows nearly identical structure with only icon, route, and label differences.
As suggested in the previous review, consider refactoring into a reusable pattern to improve maintainability.
🧹 Nitpick comments (1)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (1)
9-9: Fix interface naming inconsistency.The interface is named
IBottomNavPropsbut this component is calledSideBar. This creates confusion about the component's purpose.- interface IBottomNavProps extends HTMLAttributes<HTMLElement> { + interface ISideBarProps extends HTMLAttributes<HTMLElement> {And update the props destructuring:
- }: IBottomNavProps = $props(); + }: ISideBarProps = $props();
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte(1 hunks)platforms/metagram/src/lib/ui/Button/Button.svelte(5 hunks)platforms/metagram/src/routes/(protected)/+layout.svelte(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- platforms/metagram/src/routes/(protected)/+layout.svelte
🔇 Additional comments (6)
platforms/metagram/src/lib/ui/Button/Button.svelte (5)
6-6: LGTM: Secondary variant addition is well-implemented.The addition of the 'secondary' variant to the type definition is correct and follows TypeScript best practices.
41-53: LGTM: Variant styling is consistent and well-structured.The styling definitions for all variants, including the new secondary variant, are well-implemented:
- Consistent structure across all variants with background, text, and border properties
- Secondary variant uses brand colors appropriately
- Explicit border definitions improve consistency
55-71: LGTM: Disabled state styling follows consistent patterns.The disabled variant styling properly uses opacity to create disabled states for all variants, including the new secondary variant.
80-80: LGTM: Width change supports sidebar usage.Changing from
w-mintow-fullmakes the button span the full width, which is appropriate for the sidebar navigation context where this secondary variant will be used.
89-91: LGTM: Border styling integration is properly implemented.The border property is correctly added to the classes derived state and applied to the button element, completing the styling system for all variants.
Also applies to: 103-103
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (1)
144-146: LGTM: Conditional post button implementation is well done.The conditional rendering of the post button using the new secondary Button variant is implemented correctly and follows good practices.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
platforms/metagram/src/routes/(protected)/+layout.svelte (1)
41-43: Replace placeholder content in right aside.The right aside still contains placeholder text "Right Aside" which should be replaced with actual content before production deployment, as noted in previous reviews.
Replace the placeholder text with production-ready content:
-<aside class="hidden border border-y-0 border-s-gray-200 md:block md:pt-14"> - Right Aside -</aside> +<aside class="hidden border border-y-0 border-s-gray-200 md:block md:pt-14" aria-label="Secondary content panel"> + <!-- Add actual right sidebar content here --> +</aside>platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (3)
15-15: Fix circular dependency in activeTab state management.The
activeTabprop is bindable but also updated from URL-derived state, creating a potential circular dependency that could cause unexpected behavior or infinite loops.Choose either URL-driven navigation OR bindable state, not both:
let { - activeTab = $bindable('home'), + activeTab = 'home', profileSrc = 'https://picsum.photos/200', handlePost, ...restProps }: ISideBarProps = $props(); -let _activeTab = $derived(page.url.pathname); +let activeTab = $derived(page.url.pathname.split('/').pop() ?? 'home'); const handleNavClick = (newTab: string) => { - activeTab = newTab; goto(`/${newTab}`); }; -$effect(() => { - activeTab = _activeTab.split('/').pop() ?? ''; -});Also applies to: 21-21, 28-30
37-42: Fix ARIA compliance for navigation structure.The navigation uses
role="tablist"but the buttons lackrole="tab", breaking the expected ARIA pattern for screen readers.Either use proper tab roles or switch to a simpler navigation role:
<nav {...restProps} aria-label="Main navigation" class={cn([cBase, restProps.class].join(' '))} - role="tablist" + role="navigation" >Alternatively, if keeping the tablist pattern, add
role="tab"to each button and usearia-selectedinstead ofaria-current.
47-169: Refactor repeated navigation button patterns.The navigation buttons follow nearly identical patterns with only icon, route, and label differences, creating maintenance overhead and code duplication.
Extract the button logic into a reusable pattern:
<script lang="ts"> // ... existing imports and logic ... + const navigationItems = [ + { key: 'home', icon: Home, label: 'Feed', route: '/home' }, + { key: 'discover', icon: Search, label: 'Search', route: '/discover' }, + { key: 'post', icon: Camera, label: 'Upload a photo', route: '/post' }, + { key: 'messages', icon: CommentsTwo, label: 'Messages', route: '/messages' }, + { key: 'settings', icon: Settings, label: 'Settings', route: '/settings' } + ]; </script> <!-- Replace repetitive buttons with loop --> +{#each navigationItems as item} + <button + type="button" + class="flex items-center gap-2" + aria-current={activeTab === item.key ? 'page' : undefined} + onclick={() => handleNavClick(item.key)} + > + <svelte:component + this={item.icon} + size="24px" + color={activeTab === item.key ? 'var(--color-brand-burnt-orange)' : 'var(--color-black-400)'} + fill={activeTab === item.key ? 'var(--color-brand-burnt-orange)' : 'white'} + /> + <h3 class={`${activeTab === item.key ? 'text-brand-burnt-orange' : 'text-black-800'} mt-[4px]`}> + {item.label} + </h3> + </button> +{/each}
🧹 Nitpick comments (1)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte (1)
127-127: Fix inconsistent indentation.The settings button has inconsistent indentation compared to other navigation buttons.
Standardize the indentation:
- <button + <button
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
platforms/metagram/src/lib/fragments/SideBar/SideBar.svelte(1 hunks)platforms/metagram/src/lib/icons/Settings.svelte(1 hunks)platforms/metagram/src/lib/icons/index.ts(1 hunks)platforms/metagram/src/routes/(protected)/+layout.svelte(1 hunks)platforms/metagram/src/routes/(protected)/discover/+page.svelte(0 hunks)platforms/metagram/src/routes/(protected)/home/+page.svelte(0 hunks)platforms/metagram/src/routes/(protected)/messages/+page.svelte(0 hunks)platforms/metagram/src/routes/(protected)/post/+page.svelte(0 hunks)platforms/metagram/src/routes/(protected)/profile/+page.svelte(0 hunks)
💤 Files with no reviewable changes (5)
- platforms/metagram/src/routes/(protected)/discover/+page.svelte
- platforms/metagram/src/routes/(protected)/messages/+page.svelte
- platforms/metagram/src/routes/(protected)/profile/+page.svelte
- platforms/metagram/src/routes/(protected)/post/+page.svelte
- platforms/metagram/src/routes/(protected)/home/+page.svelte
✅ Files skipped from review due to trivial changes (2)
- platforms/metagram/src/lib/icons/index.ts
- platforms/metagram/src/lib/icons/Settings.svelte
🔇 Additional comments (1)
platforms/metagram/src/routes/(protected)/+layout.svelte (1)
10-31: Well-implemented dynamic heading management.The route-based heading logic using
$effectand$derivedprovides a clean, centralized approach to managing page headings. The implementation correctly maps routes to appropriate heading text and handles the reactive updates properly.
sosweetham
approved these changes
May 23, 2025
JulienAuvo
approved these changes
May 23, 2025
coodos
pushed a commit
that referenced
this pull request
Jul 7, 2025
* feat: responsive setup for mobile and desktop * fix: width of sidebar and rightaside * fix: responsive layout * feat: SideBar * fix: added some finishing touches to sidebar and button * fix: prevent pages transition on desktop * fix: icon center * feat: settings page and icon added
coodos
added a commit
that referenced
this pull request
Jul 7, 2025
* initial commit * chore: add w3id readme (#3) * chore: add w3id readme * chore: bold text * chore: better formatting * docs: add w3id details * chore: format * chore: add links * fix: id spec considerations addressal (#8) * fix: id spec considerations addressal * fix: identity -> indentifier * chore: expand on trust list based recovery * chore: expand on AKA --------- Co-authored-by: Merul Dhiman <[email protected]> * Docs/eid wallet (#10) * chore: add eid-wallet folder * chore: add eid wallet docs * feat: add (#9) * feat(w3id): basic setup (#11) * feat(w3id): basic setup * fix(root): add infrastructure workspaces * update: lock file * feat(eidw): setup tauri (#40) * Feat/setup daisyui (#46) * feat: setup-daisyui * fix: index file * feat: colors added * feat: Archivo font added * fix: postcss added * fix: +layout.svelte file added * fix: packages * fix: fully migrating to tailwind v4 * feat: add Archivo font * feat: add danger colors * feat: twmerge and clsx added * feat: shadcn function added --------- Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> * feat: add storybook (#45) * feat: add storybook * update: lockfile * feat: created connection button (#48) * created connection button * added restprops to parent class * added onClick btn and storybook * fix: make font work in storybook (#54) * Feat/header (#55) * feat: add icons lib * fix: make font work in storybook * feat: Header * feat: runtime global added, icon library created, icons added, type file added * feat: header props added * fix: remove icons and type file as we are using lib for icons * fix: heading style * fix: color and icons, git merge branch 51, 54 * fix: color * fix: header-styling * fix: classes * chore: handlers added * chore: handlers added * fix: added heading --------- Co-authored-by: Soham Jaiswal <[email protected]> * Alternative w3id diagram (#52) * Feat/cupertino pane (#49) * feat: Drawer * feat: Drawer and added a function for clickoutside in utils * fix: classes * fix: drawer button position * fix: style and clickoutside * fix: pane height * fix: border-radius * fix: drawer as bulletin * fix: styling * fix: component with inbuilt features * fix: remove redundant code * fix: remove redundant code * fix: cancel button * fix: css in storybook * fix: position * fix: height of pane * fix: remove redundant code * feat: add button action component (#47) * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * feat: add button action component * fix: add correct weights to Archivo fontt * feat: add base button * fix: set prop classes last * feat: improve loading state * chore: cleanup * chore: add documentation * fix: configure Storybook * chore: storybook gunk removal * feat: enhance ButtonAction component with type prop and better error handling --------- Co-authored-by: JulienAuvo <[email protected]> * Feat/splash screen (#63) * feat: SplashScreen * fix: remove redundant code * fix: as per given suggestion * fix: font-size * fix: logo * feat: input-pin (#56) * feat: input-pin * fix: styling as per our design * fix: added small variant * fix: hide pin on select * fix: gap between pins * fix: color of focus state * fix: removed legacy code and also fix some css to tailwind css * fix: css * fix: optional props * feat: added color variants * Feat/improve button component (#60) * feat: add white variant * feat: add small variant * chore: update doc and story for button * chore: rename cb into callback * update: improve small size * update: modify loading style * fix: return getAbsolutePath function to storybook (#58) Co-authored-by: Bekiboo <[email protected]> * feat: add selector component (#59) * feat: add selector component * feat: improve selector + add flag-icon lib * feat: improve selector + doc * feat: add utility function to get language with country name * feat: test page for language selectors * chore: add Selector Story * chore: clean test page * fix: types * fix: normalize custom tailwind colors (#71) * feat: workflows (#64) * feat: workflows * fix: node version * fix: use pnpm 10 * fix: check message * Fix/codebase linting (#73) * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Lint / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Format / lint * fix: Check Code / lint * fix: Check Code / lint * fix: Check Format / lint * fix: unknown property warning * fix: unknown property warning * chore: improve args type * settings nav button :) (#75) * setting bav button all done :) * lint fixski * added component to index.ts * Feat/#32 identity card fragment (#74) * identity card * identity card * lint fixski * lint fixski * lint fixski * fixed the font weight * added component to index.ts * changed span to buttton * feat: add icon button component (#68) * feat: add icon button component * feat: finish up buttonIcon + stories * fix: update with new color naming * feat: polish button icon (and button action too) * chore: format lint * chore: sort imports * chore: format, not sure why * Feat/onboarding flow (#67) * feat: onboarding-page * fix: line height and added handlers * fix: button variant * fix: text-decoration * fix: subtext * fix: underline * fix: padding and button spacing * fix: according to design update * feat: Drawer * feat: verify-pae * fix: verify-page styling * feat: drawer for both confirm pin and add bio metrics added * feat: modal added in fragments * fix: icons and flow * feat: Identifier Card * fix: copy to clipboard * feat: e-passport page * fix: error state * fix: colors * fix: lint error * fix: lint * feat: Typography * fix: typograpy * fix: as per given suggestion * fix: font-sizing * fix: identity card implementation * fix: spacing * fix: padding * fix: padding and spacing * fix: splashscreen * fix: error state * fix: styling to avoid * fix:typo * Fix/remove daisyui (#82) * refactoring: remove DaisyUI + refactor some tailwind classes and logic * refactoring: remove DaisyUI + refactor some tailwind classes and logic * feat: add Button.Nav (#77) * feat: add Button.Nav * chore: format * chore: sort imports * update: remove unused snippet and add missing props * feat: stick to fragment definition * update: documentation * fix: stories * chore: sort imports * Feat/splashscreen animation (#81) * feat: add animation to splashScreen * feat: implement data loading logic with splash screen delay * chore: sort import * update: use ButtonIcon is IdentityCard (#78) * update: use ButtonIcon is IdentityCard * feat: refactor ButtonIcon to be used anywhere in the app * chore: format indent * chore: remove useless change * feat: setup safe area (#80) * feat: setup safe area * chore: simplify implementation * chore: format * Feat/uuidv5 generation (#61) * feat: setup uuidv5 * chore: add test for deterministic UUID * feat: add Hero fragment (#88) * feat: add Hero fragment * chore: sort imports + add doc * feat: add storage specification abstract class (#92) * feat: add storage specification abstract class * chore: format and ignore lint * chore: change format checker on w3id * feat: settings-flow (#86) * feat: settings-flow * feat: settings and language page * feat : history page * feat: change pin page * fix: height of selector * fix: pin change page * fix: size of input pin * fix: spacing of pins * feat: AppNav fragment * fix: height of page * fix: padding * fix: remove redundant code * feat: privacy page * chore: add doc * fix: error state * feat: remove redundant code * chore: used app nav component --------- Co-authored-by: JulienAuvo <[email protected]> * feat: AppNav fragment (#90) * feat: AppNav fragment * chore: add doc * feat: Main page flow (#93) * feat: create root page + layout * feat: complete main page flow beta * chore: fix ts block * chore: sort imports * feat: integrate-flows (#94) * feat: intigrate-flows * fix: spacing in e-passport page * fix: page connectivity * feat: app page transitions * fix: z index * fix: pages * fix: view transition effect on splashscreen * fix: drawer pill and cancel button removed * fix: share button removed when onboarding * fix: remove share and view button when on onboarding flow * fix: remove view button * fix: ci checks * fix: transitions * fix: transititon according to direction * fix: lint error * fix: loop holes * Feat/w3id log generation (#98) * chore: create basic log generation mechanism * chore: add hashing utility function * chore: rotation event * feat: genesis entry * feat: generalize hash function * feat: append entry * chore: basic tests * chore: add tests for rotation * feat: add malform throws * chore: add the right errors * chore: fix CI stuff * chore: add missing file * chore: fix event type enum * chore: format * feat: add proper error * chore: format * chore: remove eventtypes enum * chore: add new error for bad options * chore: add options tests * feat: add codec tests * fix: err handling && jsdoc * fix: run format * fix: remove unused import * fix: improve default error messages * fix: move redundant logic to function * fix: run format * fix: type shadow * fix: useless conversion/cast * fix: run format --------- Co-authored-by: Soham Jaiswal <[email protected]> * Feat/core id creation logic (#99) * feat: create w3id builder * fix: w3id builder * feat: add global config var for w3id * chore: add docs * chore: change rand to crng * chore: add ts type again * chore: fix lint and format * chore: add w3id tests github workflow * Feat/evault core (#100) * feat: migrate neo4j * chore: envelope logic works * chore: envelope logic works * feat: parsed envelopes search * feat: generics * feat: protocol * feat: jwt sigs in w3id * chore: stuff works * chore: tests for evault core * chore: format * chore: fix test * Feat/docker compose and docs (#101) * chore: stash dockerfile progress * fix: getEnvelopesByOntology thing * chore: fix tests * Update infrastructure/evault-core/src/protocol/vault-access-guard.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: remove unused import * chore: remove package * chore: fix pnpm lock * chore: fix workflow * chore: fix port in dockerfile --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Feat/registry and evault provisioning (#106) * feat: evault provisioning * chore: fianlly fixed provisioner * feat: add logic for metadata in consul * feat: registry * chore: format * Feat/watchers logs (#114) * feat: alloc according to entropy and namespace * chore: move exports * chore: docs * feat: `whois` endpoint * feat: watcher endpoints * chore: fix format and lint * chore: fix tests * feat: web3 adapter (#115) * feat: tauri plugins setup (#97) * feat: tauri plugins setup * fix: add editorconfig * fix: add missing biome json * fix: run formatter * feat: biometry homework * feat: add pin set logic * feat: add biometric enabling logic * fix: sec controller qol * feat: stub user controller * fix: run format && lint * fix: sort imports * fix: import statement sort * feat: user controller * feat: pin flow * feat: biometrics unavailable * fix: pin input not working * feat: make checks pass * fix: scan works * fix: actions * feat: format on save * fix: coderabbit suggestions * chore: run format lint check * fix: scan on decline too * feat: documentation links (#117) * feat: bad namespace test (#116) * fix: layouts (#119) * fix: layouts * fix: Onboarding page scroll fixed * fix: page layout and prevent from scroll in all devices * fix: pages layout * chore: try to fix emulator * fix: units * fix: safezones for ios * fix: styling --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat: setup-metagram (#121) * feat: setup-metagram * chore: tailwind css worked * feat: fonts added * feat: typography * fix: removed stories and fixed setup for icons lib * feat: icons and story file * fix: type of args in story * fix: lint errors * feat: colors added * feat: Button * fix: format and lint * fix: colors * fix: spinner * fix: code rebbit suggestions * fix: code rebbit suggestions * fix: paraglide removed * fix: lock file * feat: added user avatar. (#130) * feat: Button (#129) * feat: Button * fix: colors of variants * feat: Input (#131) * feat: Input * feat: styling added * fix: styling * fix: styling * fix: added a new story * fix: focus states * fix: input states * Feat/settings navigation button (#140) * feat: settings-navigation-button * fix: handler added * chore: another variant added * fix: as per given suggestion * feat: BottomNav (#132) * feat: BottomNav * fix: icons * feat: profile icons created * feat: handler added * feat: handler added * fix: correct tags * fix: as per given suggestion, bottomnav moved to fragments and also implemented on page * fix: handler * chore: routes added * feat: app transitions added * fix: direction of transition * fix: transition css * fix: directionable transition * fix: used button instead of label, and used page from state * feat: added post fragment. (#137) * feat: FileInput (#150) * feat: FileInput * fix: added icon * feat: cancel upload * fix: remove redundant code * fix: usage docs added and as per requirements ' * fix: moved to framents * feat: Toggle Switch (#143) * feat: Toggle Switch * feat: Toggle Switch * fix: as per our design * fix: as per our design * feat: Label (#146) * feat: Select (#148) * feat: Select * fix: as per our design * fix: code format and as per svelte 5 * fix: font-size * fix: font-size * fix: icon * feat: message-input (#144) * feat: message-input * fix: classes merge and a files as a prop * feat: variant added * feat: icon replaced * fix: as per code rabbit suggestions * fix: icon * fix: input file button * fix: as per suggestion * fix: classes * fix: no need of error and disabled classes * fix: input * feat: invalid inputs * feat: add number input storybook --------- Co-authored-by: Soham Jaiswal <[email protected]> * feat:Drawer (#152) * feat:Drawer * feat: Drawer with clickoutside * fix: settings * Feat/metagram header (#133) * feat: added metagram header primary linear gradient. * feat: added flash icon. * feat: added secondary state of header. * feat: added secondary state of header with menu. * chore: cleaned some code. * docs: updated component docs. --------- Co-authored-by: SoSweetHam <[email protected]> * Feat/metagram message (#135) * feat: added metagram message component. * feat: added both states of message component. * docs: added usage docs. * chore: exposed component from ui. * fix: component -> fragement --------- Co-authored-by: SoSweetHam <[email protected]> * feat: modal (#154) * fix: styling of modal * fix: modal props * fix: conflicting styles * fix: styles of drawer * fix: hide scrollbar in drawer * fix: padding * fix: used native method for dismissing of drawer * feat: Context-Menu (#156) * feat: Context-Menu * fix: name of component * fix: as per suggestion * fix: action menu position * fix: class * feat: responsive-setup (#157) * feat: responsive-setup * fix: background color * fix: added font fmaily * feat: responsive setup for mobile and desktop (#159) * feat: responsive setup for mobile and desktop * fix: width of sidebar and rightaside * fix: responsive layout * feat: SideBar * fix: added some finishing touches to sidebar and button * fix: prevent pages transition on desktop * fix: icon center * feat: settings page and icon added * feat/layout-enhancement (#168) * feat/infinite-scroll (#170) * feat/infinite-scroll * fix: aspect ratio of post * fix: bottom nav background * settings page (#169) * settings page layout done * settings page layout done * formt fix * format fix * format fix * routing for settings page fixed * settings page buttons * merge conflict * settings page tertiary pages * settings pages all done * settings pages unnecessary page deleted * requested changes done * requested changes done * Feat/comments pane (#171) * feat/comments-pane * fix: overflow and drawer swipe * feat: Comment fragment * fix: comments added * fix: comment fragment * feat: Comments reply * fix: message input position * fix: post type shifted to types file * fix: one level deep only * fix: drawer should only be render on mobile * fix: comments on layout page * fix: format * feat: messages (#174) * feat: messages * feat: ChatMessae * feat: messages by id * fix: messages page * fix: icon name * fix: hide bottom nav for chat * fix: header * fix: message bubble * fix: message bubble * fix: message bubble * fix: as per suggestion * fix: messaging * chore: change from nomad to k8s (#179) * chore: change from nomad to k8s * Update infrastructure/eid-wallet/src/routes/+layout.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: uri extraction * feat: regitry stuff * feat: registry using local db * 📝 Add docstrings to `feat/switch-to-k8s` (#181) Docstrings generation was requested by @coodos. * #179 (comment) The following files were modified: * `infrastructure/evault-provisioner/src/templates/evault.nomad.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: format --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: make scan qr page work again (#185) * feat: Discover Page (#180) * refactor/Post (#186) * refactor/Post * fix: format and lint * fix: added dots for gallery * fix: added dots for gallery * fix: added dots for gallery * fix: plural name * feat: splash-screen (#187) * Feat/evault provisioning via phone (#188) * feat: eid wallet basic ui for verification * chore: evault provisioning * feat: working wallet with provisioning * feat: restrict people on dupes * 📝 Add docstrings to `feat/evault-provisioning-via-phone` (#189) Docstrings generation was requested by @coodos. * #188 (comment) The following files were modified: * `infrastructure/eid-wallet/src/lib/utils/capitalize.ts` * `infrastructure/evault-provisioner/src/utils/hmac.ts` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat: added uploaded post view component. (#182) * feat: added uploaded post view component. * fix: fixed the outline and color. * fix: moved function to external definition. * fix: fixed the restProps. * profile page (#178) * basic layout for profile page * fixed alt text * merge conflict * profile page for other users implemented * fix: profile pages and logics * fixed all the pages of profile * fixed all the pages of profile * fix: format --------- Co-authored-by: gourav <[email protected]> * Feat/radio input (#176) * feat: added a radio button custom * docs: added name option in docs. * chore: cleaned the unnecessary classes and variables for input type radio. * fix: moved input radio to its own component. * fix: keydown events added. * feat: added settings tile component. (#184) * feat: added settings tile component. * chore: fixed the naming convention * chore: renamed callback to onclick * fix: fixed the use of restProps * fix: fixed the unnecessary onclick expose. * fix: fixed the join function params. * Feat/textarea (#194) * chore: removed redundant radio * feat: added textarea. * fix: tabindex * fix: removed type inconsitency. * Feat/mobile upload flow (#193) * fix: header logic in secondary * fix: fixed the text in header in post * feat: trying some hack to get file image input. * feat: added image input on clicking the post bottom nav * chore: got rid of non-required code. * feat: added the logic to get the images from user on clicking post tab. * feat: added store. * feat: added correct conversion of files. * feat: added the correct display of image when uploading. * feat: added settings tile to the post page and fixed the settingsTile component type of currentStatus * feat: added hte correct header for the audience page. * fix: fixed the page transition not happening to audience page. * feat: added audience setting * feat: added store to audience. * chore: removed console log * feat: added post button. * feat: correct button placement * fix: horizontal scroll * fix: positioning of the post button. * fix: protecting post route when no image is selected. * fix: improved type saftey * feat: added memory helper function * feat: added memory cleanup. * Feat/social media platforms (#195) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * Feat/social media platforms (#196) * chore: this part works now wooohooo * chore: stash progress * chore: stash progress * chore: init message data models * feat: different socials * chore: blabsy ready for redesign * chore: add other socials * Feat/blabsy add clone (#198) * chore: clone twitter * feat: custom auth with firebase using w3ds * chore: add chat * feat: chat works with sync * feat: twittex * feat: global schemas * feat: blabsy adapter * refactor: shift some text messages to work on blabsy (#199) * chore: stash progress * chore: stash adapters * chore: stash working extractor * feat: adapter working properly for translating to global with globalIDs * feat: adapter toGlobal pristine * chore: stash * feat: adapter working * chore: stash until global translation from pictique * feat: bi-directional sync prestino * feat: bidir adapters * chore: login redir * chore: swap out for sqlite3 * chore: swap out for sqlite3 * chore: server conf * feat: messages one way * feat: ready to deploy * feat: ready to deploy * chore: auth thing pictique * chore: set adapter to node * chore: fix auth token thingy * chore: auth thing * chore: fix auth token thingy * chore: port for blabsy * feat: provision stuff * feat: provision * feat: provision * feat: provision * chore: fix sync * feat: temporary id thing * chore: android * chore: fix mapper sync * chore: fallback * feat: add error handling on stores * feat: fix issue with posts * chore: fix retry loop * Fix/author details (#229) * fix: author-details * fix: owner-details * fix: author avatar * fix: auth user avatar * fix: error handling * fix: author image in bottom nav --------- Co-authored-by: Merul Dhiman <[email protected]> * Fix/change name (#228) * fix: corrected the name to blabsy * fix: extra shit comming. * fix: fixed the alignment of the display in more to look more like current twitter. * fix: avatars (#226) * fix: avatars * fix: avatar in follow request page * fix: images uploaded shown in user profile * fix: button size * fix: avatar --------- Co-authored-by: Merul Dhiman <[email protected]> * chore: temp fix sync * chore: stash progress * Fix/post context menu (#231) * fix: post-context-menu * fix: user id with post * fix: removed redundant code * fix: images * fix: profile data * fix: profile data * fix: image cover * fix: logout * Fix/wallet text (#234) * changed text as per the request and fixed styling on pages with useless scroll * added settings button in main page which went missing somehow * fix: consistent padding * chore: change tags * feat: change icon * feat: webhook dynamic registry * feat: make camera permission work properlyh * chore: removed all locking mechanism thing from platforms * feat: synchronization works perfectly * feat: fixed everything up * feat: changes * chore: stats fix * chore: fix pictique visual issues * chore: fix cosmetic name issue * feat: fix sync issue * chore: fix logical issue here * chore: add qrcode ename * feat: add packages (#235) * feat: add packages * feat: add sample funcs + docs * fixed the filled color on like icon for liked post (#239) * feat: fake passport name * feat: double confirmation * chore: fix pictique login issue * fix: make no user case redir to login * fix: issues with wallet --------- Co-authored-by: Soham Jaiswal <[email protected]> Co-authored-by: SoSweetHam <[email protected]> Co-authored-by: Gourav Saini <[email protected]> Co-authored-by: Bekiboo <[email protected]> Co-authored-by: Julien <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: Sergey <[email protected]> Co-authored-by: Julien Connault <[email protected]> Co-authored-by: Ananya Rana <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Sahil Garg <[email protected]> Co-authored-by: Sahil Garg <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Page layout added
Issue Number
closes #158
Type of change
How the change has been tested
CI and Manual
Change checklist
Summary by CodeRabbit
New Features
Style
Refactor
Enhancements