Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import type { ComponentProps } from "svelte";
import UploadedPostView from "./UploadedPostView.svelte";

export default {
title: "UI/UploadedPostView",
component: UploadedPostView,
tags: ["autodocs"],
render: (args: {
Component: UploadedPostView;
props: ComponentProps<typeof UploadedPostView>;
}) => ({
Component: UploadedPostView,
props: args,
}),
};

let images = [
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
];
Comment on lines +17 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve mock data diversity and accessibility.

All images have identical URLs and alt text, which reduces the effectiveness of testing and could cause accessibility issues. Consider using diverse sample data to better demonstrate the component's functionality.

 let images = [
     {
         url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
-        alt: "Sample Image 1",
+        alt: "Avatar image 1",
     },
     {
-        url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
-        alt: "Sample Image 1",
+        url: "https://picsum.photos/250/250?random=1",
+        alt: "Sample landscape image",
     },
     {
-        url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
-        alt: "Sample Image 1",
+        url: "https://picsum.photos/250/250?random=2", 
+        alt: "Sample portrait image",
     },
     {
-        url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
-        alt: "Sample Image 1",
+        url: "https://picsum.photos/250/250?random=3",
+        alt: "Sample nature image",
     },
     {
-        url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
-        alt: "Sample Image 1",
+        url: "https://picsum.photos/250/250?random=4",
+        alt: "Sample architecture image",
     },
     {
-        url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
-        alt: "Sample Image 1",
+        url: "https://picsum.photos/250/250?random=5",
+        alt: "Sample abstract image",
     },
 ];
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
let images = [
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
];
let images = [
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Avatar image 1",
},
{
url: "https://picsum.photos/250/250?random=1",
alt: "Sample landscape image",
},
{
url: "https://picsum.photos/250/250?random=2",
alt: "Sample portrait image",
},
{
url: "https://picsum.photos/250/250?random=3",
alt: "Sample nature image",
},
{
url: "https://picsum.photos/250/250?random=4",
alt: "Sample architecture image",
},
{
url: "https://picsum.photos/250/250?random=5",
alt: "Sample abstract image",
},
];
🤖 Prompt for AI Agents
In
platforms/metagram/src/lib/fragments/UploadedPostView/UploadedPostView.stories.ts
between lines 17 and 42, the mock images array uses identical URLs and alt text
for all entries, which limits testing effectiveness and accessibility. Update
the array to include diverse image URLs and unique, descriptive alt text for
each image to better showcase the component's functionality and improve
accessibility.


export const Primary = {
args: {
images: images,
callback: (i: number) => {
images = images.filter((_, index) => index !== i);
},
},
};
Comment on lines +44 to +51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix state management issue with module-level variable mutation.

The callback function mutates the module-level images variable, which can cause unexpected behavior in Storybook. Changes will persist across story reloads and interactions, making the story unpredictable.

Move the images array inside the story to ensure proper state isolation:

+const getInitialImages = () => [
+    {
+        url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
+        alt: "Avatar image 1",
+    },
+    // ... other images
+];

 export const Primary = {
     args: {
-        images: images,
+        images: getInitialImages(),
         callback: (i: number) => {
-            images = images.filter((_, index) => index !== i);
+            // This should be handled by the parent component's state management
+            console.log(`Removing image at index ${i}`);
         },
     },
 };

Alternatively, use Storybook's play function or actions addon to demonstrate the removal functionality without actual state mutation.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
export const Primary = {
args: {
images: images,
callback: (i: number) => {
images = images.filter((_, index) => index !== i);
},
},
};
const getInitialImages = () => [
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Avatar image 1",
},
// ... other images
];
export const Primary = {
args: {
images: getInitialImages(),
callback: (i: number) => {
// This should be handled by the parent component's state management
console.log(`Removing image at index ${i}`);
},
},
};
🤖 Prompt for AI Agents
In
platforms/metagram/src/lib/fragments/UploadedPostView/UploadedPostView.stories.ts
around lines 44 to 51, the callback function mutates the module-level images
variable, causing state to persist across story reloads and leading to
unpredictable behavior. To fix this, move the images array inside the Primary
story's args or component state to isolate state per story instance.
Alternatively, avoid direct mutation by using Storybook's play function or
actions addon to simulate image removal without changing the module-level
variable.

Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
<script lang="ts">
import { Cross } from '$lib/icons';
import { cn } from '$lib/utils';
import type { HTMLAttributes } from 'svelte/elements';

interface IImage {
url: string;
alt: string;
}

interface IUploadedPostViewProps extends HTMLAttributes<HTMLElement> {
images: IImage[];
width?: string;
height?: string;
callback: (i: number) => void;
}

let {
images,
width = 'w-full',
height = 'h-full',
callback,
...restProps
}: IUploadedPostViewProps = $props();
</script>

<article
{...restProps}
class={cn(
['max-w-screen flex flex-row items-center gap-4 scroll-auto', restProps.class].join(' ')
)}
>
{#each images as image, i}
<div class={cn(['group relative shrink-0'])}>
<Cross
class="absolute right-0 top-0 hidden -translate-y-1/2 translate-x-1/2 cursor-pointer group-hover:block"
onclick={() => callback(i)}
/>
<img
src={image.url}
alt={image.alt}
class={cn(['rounded-lg outline-[#DA4A11] group-hover:outline-2', width, height])}
/>
</div>
{/each}
</article>

<!--
@component
export default UploadedPostView
@description
This component is a view for displaying uploaded images in a post. It allows users to see the images they have uploaded and provides a way to remove individual images.

@props
- images: An array of image objects, each containing a `url` and `alt` text.
- width: The width of the image container. Default is `w-full`.
- height: The height of the image container. Default is `h-full`.
- callback: A function that is called when the cross on the image is clicked, passing the index of the clicked image.
- ...restProps: Any other props that can be passed to a image container element.

@usage
```html
<script lang="ts">
import { UploadedPostView } from '$lib/fragments';
</script>

<UploadedPostView
images={[
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
},
{
url: "https://www.gravatar.com/avatar/2c7d99fe281ecd3bcd65ab915bac6dd5?s=250",
alt: "Sample Image 1",
}]}
callback={(i: number) => {
images = images.filter((_, index) => index !== i);
}}
/>
```
-->
35 changes: 18 additions & 17 deletions platforms/metagram/src/lib/fragments/index.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
export { default as Header } from './Header/Header.svelte';
export { default as BottomNav } from './BottomNav/BottomNav.svelte';
export { default as SettingsNavigationButton } from './SettingsNavigationButton/SettingsNavigationButton.svelte';
export { default as MessageInput } from './MessageInput/MessageInput.svelte';
export { default as InputFile } from './InputFile/InputFile.svelte';
export { default as Drawer } from './Drawer/Drawer.svelte';
export { default as Message } from './Message/Message.svelte';
export { default as ActionMenu } from './ActionMenu/ActionMenu.svelte';
export { default as Modal } from './Modal/Modal.svelte';
export { default as SideBar } from './SideBar/SideBar.svelte';
export { default as RightAside } from './RightAside/RightAside.svelte';
export { default as SettingsToggleButton } from './SettingsToggleButton/SettingsToggleButton.svelte';
export { default as Post } from './Post/Post.svelte';
export { default as ChatMessage } from './ChatMessage/ChatMessage.svelte';
export { default as Comment } from './Comment/Comment.svelte';
export { default as SettingsDeleteButton } from './SettingsDeleteButton/SettingsDeleteButton.svelte';
export { default as UserRequest } from './UserRequest/UserRequest.svelte';
export { default as Header } from "./Header/Header.svelte";
export { default as BottomNav } from "./BottomNav/BottomNav.svelte";
export { default as SettingsNavigationButton } from "./SettingsNavigationButton/SettingsNavigationButton.svelte";
export { default as MessageInput } from "./MessageInput/MessageInput.svelte";
export { default as InputFile } from "./InputFile/InputFile.svelte";
export { default as Drawer } from "./Drawer/Drawer.svelte";
export { default as Message } from "./Message/Message.svelte";
export { default as ActionMenu } from "./ActionMenu/ActionMenu.svelte";
export { default as Modal } from "./Modal/Modal.svelte";
export { default as SideBar } from "./SideBar/SideBar.svelte";
export { default as RightAside } from "./RightAside/RightAside.svelte";
export { default as SettingsToggleButton } from "./SettingsToggleButton/SettingsToggleButton.svelte";
export { default as Post } from "./Post/Post.svelte";
export { default as ChatMessage } from "./ChatMessage/ChatMessage.svelte";
export { default as Comment } from "./Comment/Comment.svelte";
export { default as SettingsDeleteButton } from "./SettingsDeleteButton/SettingsDeleteButton.svelte";
export { default as UserRequest } from "./UserRequest/UserRequest.svelte";
export { default as UploadedPostView } from "./UploadedPostView/UploadedPostView.svelte";
23 changes: 23 additions & 0 deletions platforms/metagram/src/lib/icons/Cross.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<script lang="ts">
import type { ISvgProps } from './../types';

let { size = '20px', color = '#DA4A11', ...restProps }: ISvgProps = $props();
</script>

<svg
width={size}
height={size}
viewBox="0 0 24 24"
fill="none"
xmlns="http://www.w3.org/2000/svg"
{...restProps}
>
<rect width="24" height="24" rx="12" fill={color} />
<path
d="M16.0837 7.91663L7.91699 16.0833M7.91699 7.91663L16.0837 16.0833"
stroke="white"
stroke-width="1.75"
stroke-linecap="round"
stroke-linejoin="round"
/>
</svg>
23 changes: 12 additions & 11 deletions platforms/metagram/src/lib/icons/index.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
export { default as Icons } from './Icons.svelte';
export { default as Like } from './Like.svelte';
export { default as Refresh } from './Refresh.svelte';
export { default as CommentIcon } from './CommentIcon.svelte';
export { default as VerticalDots } from './VerticalDots.svelte';
export { default as Home } from './Home.svelte';
export { default as Flash } from './Flash.svelte';
export { default as CommentsTwo } from './CommentsTwo.svelte';
export { default as Search } from './Search.svelte';
export { default as Camera } from './Camera.svelte';
export { default as Settings } from './Settings.svelte';
export { default as Icons } from "./Icons.svelte";
export { default as Like } from "./Like.svelte";
export { default as Refresh } from "./Refresh.svelte";
export { default as CommentIcon } from "./CommentIcon.svelte";
export { default as VerticalDots } from "./VerticalDots.svelte";
export { default as Home } from "./Home.svelte";
export { default as Flash } from "./Flash.svelte";
export { default as CommentsTwo } from "./CommentsTwo.svelte";
export { default as Search } from "./Search.svelte";
export { default as Camera } from "./Camera.svelte";
export { default as Settings } from "./Settings.svelte";
export { default as Cross } from "./Cross.svelte";
Loading