-
Notifications
You must be signed in to change notification settings - Fork 4
fix: metadata #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: metadata #289
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
data/* |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -9,14 +9,14 @@ | |||||||||||||||||||||||||||||||||||||||||||||||
"orientation": "portrait", | ||||||||||||||||||||||||||||||||||||||||||||||||
"icons": [ | ||||||||||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||||||||||
"src": "/logo192.png", | ||||||||||||||||||||||||||||||||||||||||||||||||
"type": "image/png", | ||||||||||||||||||||||||||||||||||||||||||||||||
"sizes": "192x192" | ||||||||||||||||||||||||||||||||||||||||||||||||
"src": "/logo.svg", | ||||||||||||||||||||||||||||||||||||||||||||||||
"type": "image/svg+xml", | ||||||||||||||||||||||||||||||||||||||||||||||||
"sizes": "any" | ||||||||||||||||||||||||||||||||||||||||||||||||
}, | ||||||||||||||||||||||||||||||||||||||||||||||||
{ | ||||||||||||||||||||||||||||||||||||||||||||||||
"src": "/logo512.png", | ||||||||||||||||||||||||||||||||||||||||||||||||
"src": "/logo.png", | ||||||||||||||||||||||||||||||||||||||||||||||||
"type": "image/png", | ||||||||||||||||||||||||||||||||||||||||||||||||
"sizes": "512x512" | ||||||||||||||||||||||||||||||||||||||||||||||||
"sizes": "any" | ||||||||||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+17
to
20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PNG icon should declare explicit sizes; avoid "any" For raster icons, set concrete sizes (e.g., 192x192, 512x512). Keep SVG with sizes:any, but add PNG fallbacks with explicit sizes. Apply a revision like: "icons": [
{
"src": "/logo.svg",
"type": "image/svg+xml",
"sizes": "any",
"purpose": "any maskable"
},
- {
- "src": "/logo.png",
- "type": "image/png",
- "sizes": "any"
- }
+ {
+ "src": "/logo-192.png",
+ "type": "image/png",
+ "sizes": "192x192"
+ },
+ {
+ "src": "/logo-512.png",
+ "type": "image/png",
+ "sizes": "512x512"
+ }
] Ensure the new PNGs exist in public/, and consider adding an apple-touch-icon in HTML head for iOS (iOS ignores manifest icons). 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||||||||||||||||||||||||||
] | ||||||||||||||||||||||||||||||||||||||||||||||||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -39,7 +39,7 @@ export function DisplayModal({ closeModal }: DisplayModalProps): JSX.Element { | |||||
border-light-border px-4 py-3 dark:border-dark-border' | ||||||
> | ||||||
<div className='grid grid-cols-[auto,1fr] gap-3'> | ||||||
<UserAvatar src='/assets/twitter-avatar.jpg' alt='Blabsy' /> | ||||||
<UserAvatar src='logo.png' alt='Blabsy' /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Broken asset path: use absolute public path 'logo.png' is a relative URL and will likely 404 on nested routes. Public assets should be referenced with a leading slash. Apply this diff: - <UserAvatar src='logo.png' alt='Blabsy' />
+ <UserAvatar src='/logo.png' alt='Blabsy' /> 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||
<div> | ||||||
<div className='flex gap-1'> | ||||||
<UserName verified name='Blabsy' /> | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2,7 +2,7 @@ | |||||
<html lang="en"> | ||||||
<head> | ||||||
<meta charset="utf-8" /> | ||||||
<link rel="icon" href="%sveltekit.assets%/favicon.png" /> | ||||||
<link rel="icon" href="%sveltekit.assets%/Logo.svg" /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainNormalize asset case and add type/sizes for SVG The path uses an uppercase L (Logo.svg) whereas other apps use lowercase (logo.svg). On case-sensitive filesystems this can 404 if the filename differs. Also add type/sizes. - <link rel="icon" href="%sveltekit.assets%/Logo.svg" />
+ <link rel="icon" href="%sveltekit.assets%/logo.svg" type="image/svg+xml" sizes="any" /> Run to verify asset existence and references: 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "References in pictique app.html:"
rg -n 'Logo\.svg|logo\.svg' platforms/pictique/src/app.html || true
echo ""
echo "Matching files in repo (case-insensitive):"
fd -a -i 'logo.svg' || true
fd -a -i 'Logo.svg' || true Length of output: 821 Add SVG favicon type and sizes (retain existing filename casing) Verified that the pictique app’s static assets use – platforms/pictique/src/app.html (line 5) - <link rel="icon" href="%sveltekit.assets%/Logo.svg" />
+ <link rel="icon" href="%sveltekit.assets%/Logo.svg" type="image/svg+xml" sizes="any" /> If you’d rather normalize to lowercase across all apps, you’ll need to:
📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||||||
%sveltekit.head% | ||||||
</head> | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Good move to SVG; add maskable purpose and consider PNG fallbacks for iOS
SVG with sizes "any" is fine for many platforms. Add purpose "any maskable" for better Android adaptive icons, and consider providing PNG fallbacks (192x192, 512x512) plus an apple-touch-icon for iOS (iOS ignores Web Manifest icons).
Optional: add additional PNG entries and an <link rel="apple-touch-icon" ...> in the HTML head.
📝 Committable suggestion
🤖 Prompt for AI Agents