-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/evoting fixes #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/evoting fixes #303
Conversation
Caution Review failedThe pull request is closed. WalkthroughIntroduces a new BlindVote TypeScript package and integrates blind voting across the eVoting frontend and API. Adds Loki-based log streaming and a platform registry to the Control Panel. Updates the eID Wallet to handle blind-vote deep links and submission. Removes Grafana/Promtail and large portions of the Web3 Adapter. Adds DB entity/migration and routes for blind voting. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant FE as eVoting Frontend
participant Wallet as eID Wallet
participant API as eVoting API
participant BV as BlindVote Lib (API)
participant DB as DB
rect rgb(235,245,255)
note right of FE: Private poll
User->>FE: Open poll
FE->>FE: Generate w3ds:// blind-vote deep link
FE-->>User: Show QR / Open Wallet
end
rect rgb(245,255,245)
User->>Wallet: Scan QR / Open deep link
Wallet->>API: Check/register voter (POST /api/votes/:pollId/register)
API->>DB: Upsert voting state
API-->>Wallet: OK
Wallet->>BV: Generate commitments/anchors (local)
Wallet->>API: Submit blind vote (POST /api/votes/:pollId/blind)
API->>DB: Store commitments/anchors
API-->>Wallet: Success
Wallet-->>User: Confirm submission
end
rect rgb(255,245,235)
note over API,BV: Tally (on demand / deadline)
FE->>API: GET /api/polls/:pollId/blind-tally
API->>DB: Load blind votes
API->>BV: Rebuild VotingSystem, tally
BV-->>API: Counts + (C_agg, H_S, X)
API-->>FE: Blind results
FE-->>User: Display tallies
end
sequenceDiagram
autonumber
participant CP as Control Panel (SSE)
participant Loki as Loki
participant WA as Web3 Adapter
rect rgb(240,240,255)
CP->>Loki: streamLogs({app="web3-adapter"})
Loki-->>CP: log lines (polling)
CP->>CP: parse -> FlowEvent
CP-->>Client: SSE evault_sync_event
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit