Fix/control panel button issue #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughRefactors a crypto equality helper; updates control-panel to persist selections, validate before navigating, and gate monitoring UI on selections; tweaks an eID wallet settings label and Vite config; and secures polls listing with auth plus group/owner-based filtering via an updated PollService signature and controller usage. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as Client
participant API as API Router
participant AG as authGuard
participant PC as PollController
participant PS as PollService
participant GR as Group (model)
participant DB as DB
U->>API: GET /api/polls?page&limit&search&sort...
API->>AG: authGuard
AG-->>API: user (req.user) or 401
API->>PC: getAllPolls(req, res)
PC->>PS: getAllPolls(page, limit, search, sortField, sortDir, userId)
alt userId provided
PS->>GR: find groups by userId
GR-->>PS: userGroupIds
PS->>DB: query polls (search/sort)
PS->>PS: filter by public OR groupId∈userGroupIds OR creator=userId
else no userId
PS->>DB: query polls (search/sort) without group filtering
end
PS-->>PC: { polls, total, page, limit, totalPages }
PC-->>U: 200 JSON
sequenceDiagram
autonumber
actor User
participant Sel as +page.svelte (selection)
participant SS as sessionStorage
participant Lay as +layout.svelte (Start)
participant Nav as Router
participant Mon as monitoring/+page.svelte
participant Flow as SvelteFlow
User->>Sel: select EVaults/Platforms
Sel->>SS: set('selectedEVaults'/'selectedPlatforms', JSON)
User->>Lay: click "Start Monitoring"
Lay->>SS: get selections
alt none/empty
Lay-->>User: alert "Select items"
else valid
Lay->>Nav: goto('/monitoring')
Nav->>Mon: mount
Mon->>SS: read selections
alt selections empty
Mon-->>User: Empty-state UI
else selections exist
Mon->>Flow: init + render
Note over Mon,Flow: Event handlers log flow/sync events and map evault indices
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit