Skip to content

Conversation

coodos
Copy link
Contributor

@coodos coodos commented Aug 22, 2025

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of system message recognition in message streams by detecting the marker anywhere within the message text.
    • Reduced missed system messages, ensuring they are consistently processed when present, even if not at the beginning.
    • Aligned behavior across platforms for consistent handling of system messages.
    • Enhances overall stability of automated processing dependent on system messages, leading to fewer false negatives and more predictable outcomes for end-users.

Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated system-message detection in two Postgres subscriber handlers: checks now use data.text.includes('$$system-message$$') instead of data.content.startsWith('$$system-message$$'). Non-system messages continue to be skipped with a log and early return; system messages continue through existing processing.

Changes

Cohort / File(s) Summary
Cerberus subscriber logic
platforms/cerberus/src/web3adapter/watchers/subscriber.ts
Switched system-message check from content.startsWith('$$system-message$$') to text.includes('$$system-message$$') within handleChange.
Evoting API subscriber logic
platforms/evoting-api/src/web3adapter/watchers/subscriber.ts
Same change: use data.text.includes('$$system-message$$') instead of data.content.startsWith('$$system-message$$') in message handling.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant PG as Postgres
  participant Sub as Subscriber
  participant Log as Logger
  participant Proc as SystemMsgProcessor

  PG->>Sub: NOTIFY Message change (row data)
  Sub->>Sub: Extract data.text
  alt Contains "$$system-message$$"
    Note right of Sub: Detection changed to substring match on text
    Sub->>Proc: Process system message
    Proc-->>Sub: Done
  else Not a system message
    Sub->>Log: Debug: skip non-system message
    Sub-->>PG: Return
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitch my ears at hidden signs,
From prefix trails to text that shines—
A secret tag within the line,
I sniff it out, a subtle sign.
Hop, log, hop—skip the rest—
System whispers pass my test. 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cb3eae3 and 26b4216.

📒 Files selected for processing (2)
  • platforms/cerberus/src/web3adapter/watchers/subscriber.ts (1 hunks)
  • platforms/evoting-api/src/web3adapter/watchers/subscriber.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/message-spam

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coodos coodos merged commit 6bea83f into main Aug 22, 2025
0 of 3 checks passed
@coodos coodos deleted the fix/message-spam branch August 22, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant