chore: fix group issue #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughInternal data-fetching logic was refactored in two services and a controller: PollService now derives user group memberships via direct group queries; AuthController’s login path calls a stricter UserService method that no longer auto-creates users and returns 404 when absent; UserService implements multi-step ename lookup and token issuance. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor C as Client
participant A as AuthController
participant U as UserService
participant R as UserRepository
participant T as TokenSigner
C->>A: POST /login { ename }
A->>U: findUserByEname(ename)
rect rgba(200,230,255,0.3)
note over U: Multi-step lookup
U->>R: findByEname(ename)
alt not found AND ename starts with "@"
U->>R: findByEname(ename without "@")
else not found AND ename lacks "@"
U->>R: findByEname("@" + ename)
end
end
alt user found
U->>T: signToken(user)
T-->>U: token
U-->>A: { user, token }
A-->>C: 200 OK { user, token }
else user not found
U-->>A: throws "not found"
A-->>C: 404 Not Found { error, message, details }
end
sequenceDiagram
autonumber
actor C as Client
participant P as PollService
participant G as GroupRepository
participant PR as PollRepository
C->>P: getAllPolls(userId)
rect rgba(230,255,230,0.4)
P->>G: query groups where userId in members/admins/participants (left joins)
G-->>P: groups[]
P->>P: derive userGroupIds from groups
end
P->>PR: query polls (public OR in userGroupIds OR createdBy userId)
PR-->>P: polls[]
P-->>C: polls[]
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
Bug Fixes
Refactor
Chores