fix: deeplink issue

[coodos]

Description of change

Issue Number

Type of change

• Breaking (any change that would cause existing functionality to not work as expected)
• New (a change which implements a new feature)
• Update (a change which updates existing functionality)
• Fix (a change which fixes an issue)
• Docs (changes to the documentation)
• Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

• New Features

  • In-drawer success screen with an Okay button for signing and blind voting.
  • App-wide deep-link handling that routes payloads to the scan screen automatically.

• UX Improvements

  • Consistent success experience for signing and blind voting with clearer visuals.
  • Manual acknowledgement replaces auto-dismiss, giving users control.

• Behavior Changes

  • Camera stops on success; deep-link actions resume scanning immediately.
  • Session info shown for added context during signing.

• Reliability

  • More robust deep-link processing with duplicate guards and session-backed persistence.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors scan-qr page to show an in-drawer persistent success UI for signing/blind voting, adds a confirm handler, and aligns camera control. Introduces a global deep-link event bridge in layout, dispatching/storing payloads and routing to scan-qr, with listeners and cleanup. Adds guards to prevent duplicate deep-link processing.

Changes

Cohort / File(s)	Summary
Scan QR sign/vote flow refactor infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte	Replaced transient success flags with in-drawer success state (showSigningSuccess), added handleSuccessOkay, unified success handling for sign and blind-vote, adjusted camera start/stop sequencing, added deep-link duplicate guards and event listener cleanup, restructured drawer content.
Global deep-link event bridge infrastructure/eid-wallet/src/routes/+layout.svelte	Added global deepLinkReceived event dispatch/listening, sessionStorage backup (deepLinkData), conditional navigation to /scan-qr, lifecycle wiring (onMount/onDestroy), and updated branches to dispatch events instead of direct-only navigation.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant OS as OS/Browser
  participant Layout as +layout.svelte
  participant Session as sessionStorage
  participant Scan as scan-qr/+page.svelte

  OS->>Layout: Deep link arrives (auth/sign/reveal data)
  Note over Layout: Dispatch CustomEvent "deepLinkReceived"
  Layout->>Session: Save deepLinkData (backup)
  alt Current route != /scan-qr
    Layout->>OS: navigate(/scan-qr)
  end
  Layout-->>Scan: Event "deepLinkReceived" (if on page)
  Scan->>Scan: Guard against duplicate/in-flight\nprocessing
  Scan->>Scan: Process deep link payload
  Scan->>Scan: startScan or cancelScan per flow

Loading

sequenceDiagram
  autonumber
  participant Scan as scan-qr/+page.svelte
  participant Camera as Camera
  participant Drawer as Signing Drawer
  participant Nav as Router

  Scan->>Camera: startScan()
  Camera-->>Scan: QR data → sign/blind-vote
  Scan->>Scan: Perform sign / submit blind vote
  Scan->>Camera: cancelScan()
  Scan->>Drawer: showSigningSuccess = true
  Note over Drawer: Success screen shown with “Okay”
  User->>Drawer: Click Okay
  Drawer->>Scan: handleSuccessOkay()
  Scan->>Scan: Reset state
  Scan->>Nav: navigate(/main)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: blind vote deeplink bug #335: Touches the same files, evolving deep-link event handling and scan-QR signing flow.
• chore: signing bug #315: Related signing/blind-vote logic changes in scan-qr; complements this refactor.
• Fix/final UI fixes #301: Adjusts scan permission/start logic in the same scan-qr page; overlaps with camera lifecycle changes.

Suggested reviewers

• sosweetham

Poem

A hop, a scan, a gleam so bright,
The drawer whispers, “Success tonight.”
Events dispatched, the links now sing,
I thump my paws—what joy they bring! 🥕
One click “Okay,” then off I run,
To /main I bounce—deployments done.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 38688c1 and d25399a.

📒 Files selected for processing (2)

• infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (9 hunks)
• infrastructure/eid-wallet/src/routes/+layout.svelte (7 hunks)

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/eid-wallet-issues

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.