-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/pictique search #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/pictique search #342
Conversation
Caution Review failedThe pull request is closed. WalkthroughUpdates user search: modifies existing search response to return only users; adds a new /api/users/search/ename-name endpoint with validation and pagination; enhances service search logic with relevance scoring, exact/fuzzy queries, case-insensitive-style matching, and dedicated ename/name search and count methods; wires new route under auth. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant R as API Router
participant A as Auth Middleware
participant UC as UserController
participant US as UserService
participant DB as Database
C->>R: GET /api/users/search/ename-name?q=...&page=&limit=&verified=
R->>A: Authenticate request
A-->>R: OK
R->>UC: searchByEnameOrName(req,res)
UC->>UC: Validate q (min 2), parse pagination/verified
UC->>US: searchUsersByEnameOrName(q, page, limit, verified)
US->>DB: Query with exact/fuzzy, relevance scoring, filters
DB-->>US: Rows (users, ename, relevance_score)
US-->>UC: users[]
UC-->>C: 200 OK, { users: [...] }
note over UC,C: Response excludes pagination metadata
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Description of change
fix search
Issue Number
closes #340
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Improvements
Breaking Changes